dockview-core - npm Package Compare versions

Comparing version 3.0.1 to 3.0.2

dist/cjs/dockview/dockviewComponent.d.ts

@@ -210,3 +210,3 @@ import { SerializedGridObject } from '../gridview/gridview';
     get floatingGroups(): DockviewFloatingGroupPanel[];
-    constructor(parentElement: HTMLElement, options: DockviewComponentOptions);
+    constructor(container: HTMLElement, options: DockviewComponentOptions);
     setVisible(panel: DockviewGroupPanel, visible: boolean): void;
@@ -213,0 +213,0 @@ addPopoutGroup(itemToPopout: DockviewPanel | DockviewGroupPanel, options?: DockviewPopoutGroupOptions): Promise<boolean>;

dist/cjs/gridview/baseComponentGridview.d.ts

@@ -84,3 +84,3 @@ import { Event, AsapEvent } from '../events';
     set locked(value: boolean);
-    constructor(parentElement: HTMLElement, options: BaseGridOptions);
+    constructor(container: HTMLElement, options: BaseGridOptions);
     abstract toJSON(): object;
@@ -87,0 +87,0 @@ abstract fromJSON(data: any): void;

dist/cjs/gridview/baseComponentGridview.js

@@ -56,5 +56,5 @@ "use strict";
     __extends(BaseGrid, _super);
-    function BaseGrid(parentElement, options) {
+    function BaseGrid(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
@@ -78,2 +78,4 @@ _this._groups = new Map();
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this.gridview = new gridview_1.Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
@@ -80,0 +82,0 @@ _this.gridview.locked = !!options.locked;

dist/cjs/gridview/gridviewComponent.d.ts

@@ -64,3 +64,3 @@ import { SerializedGridview } from './gridview';
     set deserializer(value: IPanelDeserializer | undefined);
-    constructor(parentElement: HTMLElement, options: GridviewComponentOptions);
+    constructor(container: HTMLElement, options: GridviewComponentOptions);
     updateOptions(options: Partial<GridviewComponentOptions>): void;
@@ -67,0 +67,0 @@ removePanel(panel: GridviewPanel): void;

dist/cjs/gridview/gridviewComponent.js

@@ -64,5 +64,5 @@ "use strict";
     __extends(GridviewComponent, _super);
-    function GridviewComponent(parentElement, options) {
+    function GridviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, {
+        var _this = _super.call(this, container, {
             proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
@@ -69,0 +69,0 @@ orientation: options.orientation,

dist/cjs/paneview/paneviewComponent.d.ts

@@ -113,3 +113,3 @@ import { Event } from '../events';
     get options(): PaneviewComponentOptions;
-    constructor(parentElement: HTMLElement, options: PaneviewComponentOptions);
+    constructor(container: HTMLElement, options: PaneviewComponentOptions);
     setVisible(panel: PaneviewPanel, visible: boolean): void;
@@ -116,0 +116,0 @@ focus(): void;

dist/cjs/paneview/paneviewComponent.js

@@ -86,5 +86,5 @@ "use strict";
     __extends(PaneviewComponent, _super);
-    function PaneviewComponent(parentElement, options) {
+    function PaneviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
@@ -105,5 +105,9 @@ _this._disposable = new lifecycle_1.MutableDisposable();
         _this.onUnhandledDragOverEvent = _this._onUnhandledDragOverEvent.event;
+        _this.element.style.height = '100%';
+        _this.element.style.width = '100%';
         _this.addDisposables(_this._onDidLayoutChange, _this._onDidLayoutfromJSON, _this._onDidDrop, _this._onDidAddView, _this._onDidRemoveView, _this._onUnhandledDragOverEvent);
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this._options = options;
@@ -110,0 +114,0 @@ _this.paneview = new paneview_1.Paneview(_this.element, {

dist/cjs/splitview/splitview.d.ts

@@ -17,3 +17,3 @@ import { Event } from '../events';
 export interface SplitViewOptions {
-    orientation: Orientation;
+    orientation?: Orientation;
     descriptor?: ISplitViewDescriptor;
@@ -20,0 +20,0 @@ proportionalLayout?: boolean;

dist/cjs/splitview/splitview.js

@@ -82,3 +82,3 @@ "use strict";
         var _this = this;
-        var _a;
+        var _a, _b;
         this.container = container;
@@ -205,5 +205,5 @@ this.viewItems = [];
         };
-        this._orientation = options.orientation;
+        this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : Orientation.VERTICAL;
         this.element = this.createContainer();
-        this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+        this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
         this.proportionalLayout =
@@ -210,0 +210,0 @@ options.proportionalLayout === undefined

dist/cjs/splitview/splitviewComponent.d.ts

@@ -86,3 +86,3 @@ import { IDisposable } from '../lifecycle';
     get width(): number;
-    constructor(parentElement: HTMLElement, options: SplitviewComponentOptions);
+    constructor(container: HTMLElement, options: SplitviewComponentOptions);
     updateOptions(options: Partial<SplitviewComponentOptions>): void;
@@ -89,0 +89,0 @@ focus(): void;

dist/cjs/splitview/splitviewComponent.js

@@ -67,5 +67,5 @@ "use strict";
     __extends(SplitviewComponent, _super);
-    function SplitviewComponent(parentElement, options) {
+    function SplitviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._splitviewChangeDisposable = new lifecycle_1.MutableDisposable();
@@ -81,4 +81,8 @@ _this._panels = new Map();
         _this.onDidLayoutChange = _this._onDidLayoutChange.event;
+        _this.element.style.height = '100%';
+        _this.element.style.width = '100%';
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this._options = options;
@@ -85,0 +89,0 @@ _this.splitview = new splitview_1.Splitview(_this.element, options);

dist/esm/dockview/dockviewComponent.d.ts

@@ -210,3 +210,3 @@ import { SerializedGridObject } from '../gridview/gridview';
     get floatingGroups(): DockviewFloatingGroupPanel[];
-    constructor(parentElement: HTMLElement, options: DockviewComponentOptions);
+    constructor(container: HTMLElement, options: DockviewComponentOptions);
     setVisible(panel: DockviewGroupPanel, visible: boolean): void;
@@ -213,0 +213,0 @@ addPopoutGroup(itemToPopout: DockviewPanel | DockviewGroupPanel, options?: DockviewPopoutGroupOptions): Promise<boolean>;

dist/esm/gridview/baseComponentGridview.d.ts

@@ -84,3 +84,3 @@ import { Event, AsapEvent } from '../events';
     set locked(value: boolean);
-    constructor(parentElement: HTMLElement, options: BaseGridOptions);
+    constructor(container: HTMLElement, options: BaseGridOptions);
     abstract toJSON(): object;
@@ -87,0 +87,0 @@ abstract fromJSON(data: any): void;

dist/esm/gridview/baseComponentGridview.js

@@ -61,5 +61,5 @@ import { Emitter, Event, AsapEvent } from '../events';
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, options.disableAutoResizing);
+        super(document.createElement('div'), options.disableAutoResizing);
         this._id = nextLayoutId.next();
@@ -83,2 +83,4 @@ this._groups = new Map();
         this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(this.element);
         this.gridview = new Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
@@ -85,0 +87,0 @@ this.gridview.locked = !!options.locked;

dist/esm/gridview/gridviewComponent.d.ts

@@ -64,3 +64,3 @@ import { SerializedGridview } from './gridview';
     set deserializer(value: IPanelDeserializer | undefined);
-    constructor(parentElement: HTMLElement, options: GridviewComponentOptions);
+    constructor(container: HTMLElement, options: GridviewComponentOptions);
     updateOptions(options: Partial<GridviewComponentOptions>): void;
@@ -67,0 +67,0 @@ removePanel(panel: GridviewPanel): void;

dist/esm/gridview/gridviewComponent.js

@@ -22,5 +22,5 @@ import { getRelativeLocation, getGridLocation, } from './gridview';
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, {
+        super(container, {
             proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
@@ -27,0 +27,0 @@ orientation: options.orientation,

dist/esm/paneview/paneviewComponent.d.ts

@@ -113,3 +113,3 @@ import { Event } from '../events';
     get options(): PaneviewComponentOptions;
-    constructor(parentElement: HTMLElement, options: PaneviewComponentOptions);
+    constructor(container: HTMLElement, options: PaneviewComponentOptions);
     setVisible(panel: PaneviewPanel, visible: boolean): void;
@@ -116,0 +116,0 @@ focus(): void;

dist/esm/paneview/paneviewComponent.js

@@ -59,5 +59,5 @@ import { PaneviewApi } from '../api/component.api';
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, options.disableAutoResizing);
+        super(document.createElement('div'), options.disableAutoResizing);
         this._id = nextLayoutId.next();
@@ -78,5 +78,9 @@ this._disposable = new MutableDisposable();
         this.onUnhandledDragOverEvent = this._onUnhandledDragOverEvent.event;
+        this.element.style.height = '100%';
+        this.element.style.width = '100%';
         this.addDisposables(this._onDidLayoutChange, this._onDidLayoutfromJSON, this._onDidDrop, this._onDidAddView, this._onDidRemoveView, this._onUnhandledDragOverEvent);
         this._classNames = new Classnames(this.element);
         this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(this.element);
         this._options = options;
@@ -83,0 +87,0 @@ this.paneview = new Paneview(this.element, {

dist/esm/splitview/splitview.d.ts

@@ -17,3 +17,3 @@ import { Event } from '../events';
 export interface SplitViewOptions {
-    orientation: Orientation;
+    orientation?: Orientation;
     descriptor?: ISplitViewDescriptor;
@@ -20,0 +20,0 @@ proportionalLayout?: boolean;

dist/esm/splitview/splitview.js

@@ -117,3 +117,3 @@ /*---------------------------------------------------------------------------------------------
     constructor(container, options) {
-        var _a;
+        var _a, _b;
         this.container = container;
@@ -216,5 +216,5 @@ this.viewItems = [];
         };
-        this._orientation = options.orientation;
+        this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : Orientation.VERTICAL;
         this.element = this.createContainer();
-        this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+        this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
         this.proportionalLayout =
@@ -221,0 +221,0 @@ options.proportionalLayout === undefined

dist/esm/splitview/splitviewComponent.d.ts

@@ -86,3 +86,3 @@ import { IDisposable } from '../lifecycle';
     get width(): number;
-    constructor(parentElement: HTMLElement, options: SplitviewComponentOptions);
+    constructor(container: HTMLElement, options: SplitviewComponentOptions);
     updateOptions(options: Partial<SplitviewComponentOptions>): void;
@@ -89,0 +89,0 @@ focus(): void;

dist/esm/splitview/splitviewComponent.js

@@ -47,5 +47,5 @@ import { CompositeDisposable, MutableDisposable, } from '../lifecycle';
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, options.disableAutoResizing);
+        super(document.createElement('div'), options.disableAutoResizing);
         this._splitviewChangeDisposable = new MutableDisposable();
@@ -61,4 +61,8 @@ this._panels = new Map();
         this.onDidLayoutChange = this._onDidLayoutChange.event;
+        this.element.style.height = '100%';
+        this.element.style.width = '100%';
         this._classNames = new Classnames(this.element);
         this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(this.element);
         this._options = options;
@@ -65,0 +69,0 @@ this.splitview = new Splitview(this.element, options);

package.json

 {
   "name": "dockview-core",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Zero dependency layout manager supporting tabs, grids and splitviews",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

12815162

increased by0.26%

Lines of code

96895

increased by0.17%

No dependency changes