dual-listbox - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

build/tasks/watch.js

@@ -24,2 +24,2 @@ var gulp = require('gulp');
 
-gulp.task('watch', ['watch-sass', 'watch-js']);
+gulp.task('watch', ['build', 'watch-sass', 'watch-js']);

dist/dual-listbox.js

@@ -1,1 +0,1 @@
-!function(t,e){if("object"==typeof exports&&"object"==typeof module)module.exports=e();else if("function"==typeof define&&define.amd)define([],e);else{var i=e();for(var s in i)("object"==typeof exports?exports:t)[s]=i[s]}}(this,function(){return function(t){function e(s){if(i[s])return i[s].exports;var l=i[s]={exports:{},id:s,loaded:!1};return t[s].call(l.exports,l,l.exports,e),l.loaded=!0,l.exports}var i={};return e.m=t,e.c=i,e.p="",e(0)}([function(t,e){"use strict";function i(t,e){if(!(t instanceof e))throw new TypeError("Cannot call a class as a function")}Object.defineProperty(e,"__esModule",{value:!0});var s=function(){function t(t,e){for(var i=0;i<e.length;i++){var s=e[i];s.enumerable=s.enumerable||!1,s.configurable=!0,"value"in s&&(s.writable=!0),Object.defineProperty(t,s.key,s)}}return function(e,i,s){return i&&t(e.prototype,i),s&&t(e,s),e}}(),l="dual-listbox",a="dual-lsitbox__container",n="dual-listbox__available",o="dual-listbox__selected",d="dual-listbox__title",r="dual-listbox__item",c="dual-listbox__buttons",u="dual-listbox__button",h="dual-listbox__search",v="dual-listbox__item--selected",b=function(){function t(e){var s=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};i(this,t),this.select=document.querySelector(e),this.selected=[],this.available=[],this._initOptions(s),this._initReusableElements(),this._splitSelectOptions(this.select),this._buildDualListbox(this.select.parentNode),this._addActions(),this.redraw()}return s(t,[{key:"addSelected",value:function(t){var e=this.available.indexOf(t);e>-1&&this.available.splice(e,1),this.selected.push(t),this._selectOption(t.dataset.id),this.redraw()}},{key:"redraw",value:function(){this.updateAvailableListbox(),this.updateSelectedListbox()}},{key:"removeSelected",value:function(t){var e=this.selected.indexOf(t);e>-1&&this.selected.splice(e,1),this.available.push(t),this._deselectOption(t.dataset.id),this.redraw()}},{key:"searchLists",value:function(t){this.dualListbox.querySelectorAll("."+r).forEach(function(e){t?e.innerText.includes(t)?e.style.display="block":e.style.display="none":e.style.display="block"})}},{key:"updateAvailableListbox",value:function(){this.availebleList.innerHTML="",this.availebleList.appendChild(this.availableListTitle);var t=!0,e=!1,i=void 0;try{for(var s,l=this.available[Symbol.iterator]();!(t=(s=l.next()).done);t=!0){var a=s.value;this.availebleList.appendChild(this._addClickActions(a))}}catch(t){e=!0,i=t}finally{try{!t&&l.return&&l.return()}finally{if(e)throw i}}}},{key:"updateSelectedListbox",value:function(){this.selectedList.innerHTML="",this.selectedList.appendChild(this.selectedListTitle);var t=!0,e=!1,i=void 0;try{for(var s,l=this.selected[Symbol.iterator]();!(t=(s=l.next()).done);t=!0){var a=s.value;this.selectedList.appendChild(this._addClickActions(a))}}catch(t){e=!0,i=t}finally{try{!t&&l.return&&l.return()}finally{if(e)throw i}}}},{key:"_addActions",value:function(){this._addButtonActions(),this._addSearchActions()}},{key:"_addButtonActions",value:function(){var t=this;this.add_all_button.onclick=function(e){for(e.preventDefault();t.available.length>0;)t.addSelected(t.available[0])},this.add_button.onclick=function(e){e.preventDefault();var i=t.dualListbox.querySelector("."+v);i&&t.addSelected(i)},this.remove_button.onclick=function(e){e.preventDefault();var i=t.dualListbox.querySelector("."+v);i&&t.removeSelected(i)},this.remove_all_button.onclick=function(e){for(e.preventDefault();t.selected.length>0;)t.removeSelected(t.selected[0])}}},{key:"_addClickActions",value:function(t){var e=this;return t.ondblclick=function(){e.selected.indexOf(this)>-1?e.removeSelected(t):e.addSelected(t)},t.onclick=function(){e.dualListbox.querySelectorAll("."+r).forEach(function(t){t.classList.remove(v)}),this.classList.contains(v)?this.classList.remove(v):this.classList.add(v)},t}},{key:"_addSearchActions",value:function(){var t=this;this.search.onchange=function(e){return t.searchLists(e.target.value)},this.search.onkeyup=function(e){return t.searchLists(e.target.value)}}},{key:"_buildDualListbox",value:function(t){this.select.style.display="none",this.dualListBoxContainer.appendChild(this.availebleList),this.dualListBoxContainer.appendChild(this.buttons),this.dualListBoxContainer.appendChild(this.selectedList),this.dualListbox.appendChild(this.search),this.dualListbox.appendChild(this.dualListBoxContainer),t.insertBefore(this.dualListbox,this.select)}},{key:"_createButtons",value:function(){this.buttons=document.createElement("div"),this.buttons.classList.add(c),this.add_all_button=document.createElement("button"),this.add_all_button.classList.add(u),this.add_all_button.innerHTML=this.addAllButtonText,this.add_button=document.createElement("button"),this.add_button.classList.add(u),this.add_button.innerHTML=this.addButtonText,this.remove_button=document.createElement("button"),this.remove_button.classList.add(u),this.remove_button.innerHTML=this.removeButtonText,this.remove_all_button=document.createElement("button"),this.remove_all_button.classList.add(u),this.remove_all_button.innerHTML=this.removeAllButtonText,this.buttons.appendChild(this.add_all_button),this.buttons.appendChild(this.add_button),this.buttons.appendChild(this.remove_button),this.buttons.appendChild(this.remove_all_button)}},{key:"_createListItem",value:function(t){var e=document.createElement("li");return e.classList.add(r),e.innerHTML=t.innerHTML,e.dataset.id=t.value,e}},{key:"_createSearch",value:function(){this.search=document.createElement("input"),this.search.classList.add(h)}},{key:"_deselectOption",value:function(t){var e=this.select.options,i=!0,s=!1,l=void 0;try{for(var a,n=e[Symbol.iterator]();!(i=(a=n.next()).done);i=!0){var o=a.value;o.value===t&&(o.selected=!1)}}catch(t){s=!0,l=t}finally{try{!i&&n.return&&n.return()}finally{if(s)throw l}}this.removeEvent&&this.removeEvent(t)}},{key:"_initOptions",value:function(t){this.addEvent=t.addEvent,this.removeEvent=t.removeEvent,this.availableTitle=t.availableTitle||"Available options",this.selectedTitle=t.selectedTitle||"Selected options",this.addButtonText=t.addButtonText||"add",this.removeButtonText=t.removeButtonText||"remove",this.addAllButtonText=t.addAllButtonText||"add all",this.removeAllButtonText=t.removeAllButtonText||"remove all"}},{key:"_initReusableElements",value:function(){this.dualListbox=document.createElement("div"),this.dualListbox.classList.add(l),this.select.id&&this.dualListbox.classList.add(this.select.id),this.dualListBoxContainer=document.createElement("div"),this.dualListBoxContainer.classList.add(a),this.availebleList=document.createElement("ul"),this.availebleList.classList.add(n),this.selectedList=document.createElement("ul"),this.selectedList.classList.add(o),this.availableListTitle=document.createElement("li"),this.availableListTitle.classList.add(d),this.availableListTitle.innerText=this.availableTitle,this.selectedListTitle=document.createElement("li"),this.selectedListTitle.classList.add(d),this.selectedListTitle.innerText=this.selectedTitle,this._createButtons(),this._createSearch()}},{key:"_selectOption",value:function(t){var e=this.select.options,i=!0,s=!1,l=void 0;try{for(var a,n=e[Symbol.iterator]();!(i=(a=n.next()).done);i=!0){var o=a.value;o.value===t&&(o.selected=!0)}}catch(t){s=!0,l=t}finally{try{!i&&n.return&&n.return()}finally{if(s)throw l}}this.addEvent&&this.addEvent(t)}},{key:"_splitSelectOptions",value:function(t){var e=this,i=t.options;[].forEach.call(i,function(t){var i=e._createListItem(t);t.attributes.selected?e.selected.push(i):e.available.push(i)})}}]),t}();e.default=b,e.DualListbox=b}])});
+!function(t,e){if("object"==typeof exports&&"object"==typeof module)module.exports=e();else if("function"==typeof define&&define.amd)define([],e);else{var i=e();for(var s in i)("object"==typeof exports?exports:t)[s]=i[s]}}(this,function(){return function(t){function e(s){if(i[s])return i[s].exports;var l=i[s]={exports:{},id:s,loaded:!1};return t[s].call(l.exports,l,l.exports,e),l.loaded=!0,l.exports}var i={};return e.m=t,e.c=i,e.p="",e(0)}([function(t,e){"use strict";function i(t,e){if(!(t instanceof e))throw new TypeError("Cannot call a class as a function")}Object.defineProperty(e,"__esModule",{value:!0});var s=function(){function t(t,e){for(var i=0;i<e.length;i++){var s=e[i];s.enumerable=s.enumerable||!1,s.configurable=!0,"value"in s&&(s.writable=!0),Object.defineProperty(t,s.key,s)}}return function(e,i,s){return i&&t(e.prototype,i),s&&t(e,s),e}}(),l="dual-listbox",a="dual-lsitbox__container",n="dual-listbox__available",d="dual-listbox__selected",o="dual-listbox__title",c="dual-listbox__item",u="dual-listbox__buttons",r="dual-listbox__button",h="dual-listbox__search",v="dual-listbox__item--selected",b=function(){function t(e){var s=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};i(this,t),this.select=document.querySelector(e),this.selected=[],this.available=[],this._initOptions(s),this._initReusableElements(),this._splitSelectOptions(this.select),this._buildDualListbox(this.select.parentNode),this._addActions(),this.redraw()}return s(t,[{key:"addSelected",value:function(t){var e=this.available.indexOf(t);e>-1&&(this.available.splice(e,1),this.selected.push(t),this._selectOption(t.dataset.id),this.redraw())}},{key:"redraw",value:function(){this.updateAvailableListbox(),this.updateSelectedListbox()}},{key:"removeSelected",value:function(t){var e=this.selected.indexOf(t);e>-1&&(this.selected.splice(e,1),this.available.push(t),this._deselectOption(t.dataset.id),this.redraw())}},{key:"searchLists",value:function(t,e){for(var i=e.querySelectorAll("."+c),s=0;s<i.length;s++){var l=i[s];t&&l.textContent.indexOf(t)===-1?l.style.display="none":l.style.display="list-item"}}},{key:"updateAvailableListbox",value:function(){this.availebleList.innerHTML="",this.availebleList.appendChild(this.availableListTitle);for(var t=0;t<this.available.length;t++){var e=this.available[t];this.availebleList.appendChild(e)}}},{key:"updateSelectedListbox",value:function(){this.selectedList.innerHTML="",this.selectedList.appendChild(this.selectedListTitle);for(var t=0;t<this.selected.length;t++){var e=this.selected[t];this.selectedList.appendChild(e)}}},{key:"_actionAllSelected",value:function(t){for(t.preventDefault();this.available.length>0;)this.addSelected(this.available[0])}},{key:"_actionItemSelected",value:function(t){t.preventDefault();var e=this.dualListbox.querySelector("."+v);e&&this.addSelected(e)}},{key:"_actionAllDeselected",value:function(t){for(t.preventDefault();this.selected.length>0;)this.removeSelected(this.selected[0])}},{key:"_actionItemDeselected",value:function(t){t.preventDefault();var e=this.dualListbox.querySelector("."+v);e&&this.removeSelected(e)}},{key:"_actionItemDoubleClick",value:function(t){var e=arguments.length>1&&void 0!==arguments[1]?arguments[1]:null;e&&(e.preventDefault(),e.stopPropagation()),this.selected.indexOf(t)>-1?this.removeSelected(t):this.addSelected(t)}},{key:"_actionItemClick",value:function(t,e){var i=arguments.length>2&&void 0!==arguments[2]?arguments[2]:null;i&&i.preventDefault();for(var s=e.querySelectorAll("."+c),l=0;l<s.length;l++){var a=s[l];a!==t&&a.classList.remove(v)}t.classList.contains(v)?t.classList.remove(v):t.classList.add(v)}},{key:"_addActions",value:function(){this._addButtonActions(),this._addSearchActions()}},{key:"_addButtonActions",value:function(){var t=this;this.add_all_button.addEventListener("click",function(e){return t._actionAllSelected(e)}),this.add_button.addEventListener("click",function(e){return t._actionItemSelected(e)}),this.remove_button.addEventListener("click",function(e){return t._actionItemDeselected(e)}),this.remove_all_button.addEventListener("click",function(e){return t._actionAllDeselected(e)})}},{key:"_addClickActions",value:function(t){var e=this;return t.addEventListener("dblclick",function(i){return e._actionItemDoubleClick(t,i)}),t.addEventListener("click",function(i){return e._actionItemClick(t,e.dualListbox,i)}),t}},{key:"_addSearchActions",value:function(){var t=this;this.search.addEventListener("change",function(e){return t.searchLists(e.target.value,t.dualListbox)}),this.search.addEventListener("keyup",function(e){return t.searchLists(e.target.value,t.dualListbox)})}},{key:"_buildDualListbox",value:function(t){this.select.style.display="none",this.dualListBoxContainer.appendChild(this.availebleList),this.dualListBoxContainer.appendChild(this.buttons),this.dualListBoxContainer.appendChild(this.selectedList),this.dualListbox.appendChild(this.search),this.dualListbox.appendChild(this.dualListBoxContainer),t.insertBefore(this.dualListbox,this.select)}},{key:"_createButtons",value:function(){this.buttons=document.createElement("div"),this.buttons.classList.add(u),this.add_all_button=document.createElement("button"),this.add_all_button.classList.add(r),this.add_all_button.innerHTML=this.addAllButtonText,this.add_button=document.createElement("button"),this.add_button.classList.add(r),this.add_button.innerHTML=this.addButtonText,this.remove_button=document.createElement("button"),this.remove_button.classList.add(r),this.remove_button.innerHTML=this.removeButtonText,this.remove_all_button=document.createElement("button"),this.remove_all_button.classList.add(r),this.remove_all_button.innerHTML=this.removeAllButtonText,this.buttons.appendChild(this.add_all_button),this.buttons.appendChild(this.add_button),this.buttons.appendChild(this.remove_button),this.buttons.appendChild(this.remove_all_button)}},{key:"_createListItem",value:function(t){var e=document.createElement("li");return e.classList.add(c),e.innerHTML=t.innerHTML,e.dataset.id=t.value,this._addClickActions(e),e}},{key:"_createSearch",value:function(){this.search=document.createElement("input"),this.search.classList.add(h),this.search.attributes.placehold=this.searchPlaceholder}},{key:"_deselectOption",value:function(t){for(var e=this.select.options,i=0;i<e.length;i++){var s=e[i];s.value===t&&(s.selected=!1)}this.removeEvent&&this.removeEvent(t)}},{key:"_initOptions",value:function(t){this.addEvent=t.addEvent,this.removeEvent=t.removeEvent,this.availableTitle=t.availableTitle||"Available options",this.selectedTitle=t.selectedTitle||"Selected options",this.addButtonText=t.addButtonText||"add",this.removeButtonText=t.removeButtonText||"remove",this.addAllButtonText=t.addAllButtonText||"add all",this.removeAllButtonText=t.removeAllButtonText||"remove all",this.searchPlaceholder=t.searchPlaceholder||"Search"}},{key:"_initReusableElements",value:function(){this.dualListbox=document.createElement("div"),this.dualListbox.classList.add(l),this.select.id&&this.dualListbox.classList.add(this.select.id),this.dualListBoxContainer=document.createElement("div"),this.dualListBoxContainer.classList.add(a),this.availebleList=document.createElement("ul"),this.availebleList.classList.add(n),this.selectedList=document.createElement("ul"),this.selectedList.classList.add(d),this.availableListTitle=document.createElement("li"),this.availableListTitle.classList.add(o),this.availableListTitle.innerText=this.availableTitle,this.selectedListTitle=document.createElement("li"),this.selectedListTitle.classList.add(o),this.selectedListTitle.innerText=this.selectedTitle,this._createButtons(),this._createSearch()}},{key:"_selectOption",value:function(t){for(var e=this.select.options,i=0;i<e.length;i++){var s=e[i];s.value===t&&(s.selected=!0)}this.addEvent&&this.addEvent(t)}},{key:"_splitSelectOptions",value:function(t){for(var e=t.options,i=0;i<e.length;i++){var s=e[i],l=this._createListItem(s);s.attributes.selected?this.selected.push(l):this.available.push(l)}}}]),t}();e.default=b,e.DualListbox=b}])});

karma.conf.js

@@ -23,2 +23,7 @@ var clone= require('clone');
     config.set({
+        browserStack: {
+            username: '',
+            accessKey: ''
+        },
+
         frameworks: [
@@ -31,3 +36,3 @@ 'jasmine-jquery',
         files: [
-            'test/*.spec.js',
+            'test/*.spec.js'
         ],
@@ -38,3 +43,3 @@
                 'webpack'
-            ],
+            ]
         },
@@ -44,4 +49,3 @@
             reporters: [
-                { type: 'cobertura', dir: paths.coverageDir, subdir: '.', file: 'coverage.xml' },
-                { type: 'html', dir: paths.coverageDir, subdir: 'html' },
+                { type: 'lcov', dir: paths.coverageDir },
                 { type: 'text' }
@@ -57,6 +61,33 @@ ]
 
-        reporters: ['spec', 'coverage'],
+        reporters: (process.env.TRAVIS) ? ['spec', 'coverage', 'coveralls'] : ['spec', 'coverage'],
 
-        browsers: ['Chrome', 'Firefox'],
+        customLaunchers: {
+            edge14: {
+                base: 'BrowserStack',
+                browser: 'edge',
+                browser_version: '14',
+                os: 'Windows',
+                os_version: '10'
+            },
+
+            edge15: {
+                base: 'BrowserStack',
+                browser: 'edge',
+                browser_version: '15',
+                os: 'Windows',
+                os_version: '10'
+            },
+
+            ie11: {
+                base: 'BrowserStack',
+                browser: 'ie',
+                browser_version: '11',
+                os: 'Windows',
+                os_version: '7'
+            }
+        },
+
+        browsers: ['Chrome', 'Firefox', 'edge14', 'edge15', 'ie11']
+//        browsers: ['Chrome', 'Firefox']
     });
 }

package.json

 {
   "name": "dual-listbox",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Dual listbox for multi-select elements",
@@ -27,4 +27,6 @@ "main": "dist/dual-listbox.js",
     "karma": "^1.1.0",
+    "karma-browserstack-launcher": "^1.2.0",
     "karma-chrome-launcher": "^1.0.1",
     "karma-coverage": "^1.0.0",
+    "karma-coveralls": "^1.1.2",
     "karma-es6-shim": "^1.0.0",
@@ -31,0 +33,0 @@ "karma-firefox-launcher": "^1.0.0",

README.md

@@ -1,2 +0,5 @@
-[![Build Status](https://travis-ci.org/maykinmedia/dual-listbox.svg?branch=1.0)](https://travis-ci.org/maykinmedia/dual-listbox)
+[![Build Status](https://travis-ci.org/maykinmedia/dual-listbox.svg?branch=master)](https://travis-ci.org/maykinmedia/dual-listbox)
+[![Coverage Status](https://coveralls.io/repos/github/maykinmedia/dual-listbox/badge.svg?branch=master)](https://coveralls.io/github/maykinmedia/dual-listbox?branch=master)
+[![Code Climate](https://codeclimate.com/github/maykinmedia/dual-listbox/badges/gpa.svg)](https://codeclimate.com/github/maykinmedia/dual-listbox)
+[![Lintly](https://lintly.com/gh/maykinmedia/dual-listbox/badge.svg)](https://lintly.com/gh/maykinmedia/dual-listbox/)
 
@@ -3,0 +6,0 @@ # Dual Listbox

src/dual-listbox.js

@@ -78,16 +78,18 @@ const MAIN_BLOCK = 'dual-listbox';
      */
-    searchLists(searchString) {
-        let items = this.dualListbox.querySelectorAll(`.${ITEM_ELEMENT}`);
+    searchLists(searchString, dualListbox) {
+        let items = dualListbox.querySelectorAll(`.${ITEM_ELEMENT}`);
 
-        items.forEach(function(item) {
+        for(let i = 0; i < items.length; i++) {
+            let item = items[i];
+
             if(searchString) {
-                if(!item.innerText.includes(searchString)) {
+                if(item.textContent.indexOf(searchString) === -1) {
                     item.style.display = 'none';
                 } else {
-                    item.style.display = 'block';
+                    item.style.display = 'list-item';
                 }
             } else {
-                item.style.display = 'block';
+                item.style.display = 'list-item';
             }
-        });
+        }
     }
@@ -101,4 +103,5 @@
         this.availebleList.appendChild(this.availableListTitle);
-        for(let listItem of this.available){
-            this.availebleList.appendChild(this._addClickActions(listItem));
+        for(let i = 0; i < this.available.length; i++) {
+            let listItem= this.available[i];
+            this.availebleList.appendChild(listItem);
         }
@@ -113,4 +116,5 @@ }
         this.selectedList.appendChild(this.selectedListTitle);
-        for(let listItem of this.selected){
-            this.selectedList.appendChild(this._addClickActions(listItem));
+        for(let i = 0; i < this.selected.length; i++) {
+            let listItem= this.selected[i];
+            this.selectedList.appendChild(listItem);
         }
@@ -174,4 +178,9 @@ }
      */
-    _actionItemDoubleClick(listItem) {
-        if (this.selected.indexOf(this) > -1) {
+    _actionItemDoubleClick(listItem, event=null) {
+        if(event) {
+            event.preventDefault();
+            event.stopPropagation();
+        }
+
+        if (this.selected.indexOf(listItem) > -1) {
             this.removeSelected(listItem);
@@ -186,10 +195,15 @@ } else {
      */
-    _actionItemClick(listItem) {
-        let items = this.dualListbox.querySelectorAll(`.${ITEM_ELEMENT}`);
+    _actionItemClick(listItem, dualListbox, event=null) {
+        if(event) {
+            event.preventDefault();
+        }
 
-        items.forEach(function(value) {
+        let items = dualListbox.querySelectorAll(`.${ITEM_ELEMENT}`);
+
+        for(let i = 0; i < items.length; i++) {
+            let value = items[i];
             if (value !== listItem) {
                 value.classList.remove(SELECTED_MODIFIER);
             }
-        });
+        }
 
@@ -216,6 +230,6 @@ if(listItem.classList.contains(SELECTED_MODIFIER)) {
     _addButtonActions() {
-        this.add_all_button.addEventListener('click', this._actionAllSelected);
-        this.add_button.addEventListener('click', this._actionItemSelected);
-        this.remove_button.addEventListener('click', this._actionItemDeselected);
-        this.remove_all_button.addEventListener('click', this._actionAllDeselected);
+        this.add_all_button.addEventListener('click', (event) => this._actionAllSelected(event));
+        this.add_button.addEventListener('click', (event) => this._actionItemSelected(event));
+        this.remove_button.addEventListener('click', (event) => this._actionItemDeselected(event));
+        this.remove_all_button.addEventListener('click', (event) => this._actionAllDeselected(event));
     }
@@ -229,4 +243,4 @@
     _addClickActions(listItem) {
-        listItem.addEventListener('dblclick', () => this._actionItemDoubleClick(listItem));
-        listItem.addEventListener('click', () => this._actionItemClick(listItem));
+        listItem.addEventListener('dblclick', (event) => this._actionItemDoubleClick(listItem, event));
+        listItem.addEventListener('click', (event) => this._actionItemClick(listItem, this.dualListbox, event));
         return listItem;
@@ -240,4 +254,4 @@ }
     _addSearchActions() {
-        this.search.addEventListener('change', (event) => this.searchLists(event.target.value));
-        this.search.addEventListener('keyup', (event) => this.searchLists(event.target.value));
+        this.search.addEventListener('change', (event) => this.searchLists(event.target.value, this.dualListbox));
+        this.search.addEventListener('keyup', (event) => this.searchLists(event.target.value, this.dualListbox));
     }
@@ -302,2 +316,4 @@
 
+        this._addClickActions(listItem);
+
         return listItem;
@@ -313,2 +329,3 @@ }
         this.search.classList.add(SEARCH_ELEMENT);
+        this.search.attributes.placehold = this.searchPlaceholder;
     }
@@ -325,3 +342,4 @@
 
-        for(let option of options) {
+        for(let i = 0; i < options.length; i++) {
+            let option = options[i];
             if(option.value === value) {
@@ -350,2 +368,3 @@ option.selected = false;
         this.removeAllButtonText = options.removeAllButtonText || 'remove all';
+        this.searchPlaceholder = options.searchPlaceholder || 'Search';
     }
@@ -394,3 +413,4 @@
 
-        for(let option of options) {
+        for(let i = 0; i < options.length; i++) {
+            let option = options[i];
             if(option.value === value) {
@@ -412,3 +432,5 @@ option.selected = true;
         let options = select.options;
-        [].forEach.call(options, (option) => {
+
+        for(let i = 0; i < options.length; i++) {
+            let option = options[i];
             let listItem = this._createListItem(option);
@@ -421,3 +443,3 @@
             }
-        });
+        }
     }
@@ -424,0 +446,0 @@ }

test/dual-listbox.spec.js

@@ -147,3 +147,3 @@ import DualListbox, { DualListbox as DualListbox2 } from '../src/dual-listbox.js';
         let dlb = new DualListbox(`.${SELECT_CLASS}`);
-        dlb.searchLists('One');
+        dlb.searchLists('One', dlb.dualListbox);
         expect(dlb.available.length).toBe(10);
@@ -156,3 +156,3 @@ expect(dlb.selected.length).toBe(0);
         let dlb = new DualListbox(`.${SELECT_CLASS}`);
-        dlb.searchLists('');
+        dlb.searchLists('', dlb.dualListbox);
         expect(dlb.available.length).toBe(10);
@@ -159,0 +159,0 @@ expect(dlb.selected.length).toBe(0);

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

69486

increased by3.94%

Lines of code

822

increased by5.66%

Number of lines in readme file

69

increased by4.55%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Dev dependency count

35

increased by6.06%

Number of low supply chain risk alerts

2

increased by100%

No dependency changes