dynamic-virtual-scroller - npm Package Compare versions

Comparing version 3.0.32 to 3.0.33

package.json

 {
   "name": "dynamic-virtual-scroller",
-  "version": "3.0.32",
+  "version": "3.0.33",
   "description": "A virtual scroller for the web that can handle dynamic row and column sizes.",
@@ -5,0 +5,0 @@ "main": "virtual-scroller.js",

src/js/ScrollManager.js

 import {ATTRIBUTES, EVENTS, CLASSES} from "./constants";
 import utils from './utils';
 import validateParameters from './validateParameters';
-var {$, _} = window;
+var {_} = window;
 
@@ -273,2 +273,12 @@ var globalState = {
             config.container.on('touchmove.' + NAMESPACE, touchmoveEvent => {
+
+                /*
+                    I'm not sure why we need this check. But without it, scrolling can't be
+                    properly stopped, even though we remove all event listeners from the container
+                    in scrollManager.stop(). #whyDoWeNeedToCheckForInactiveState
+                */
+                if (state.isActive === false) {
+                    setIsScrolling(false);
+                    return;
+                }
                 
@@ -339,2 +349,7 @@ if (globalState.activeScrollerId !== undefined && globalState.activeScrollerId !== config.scrollerId) {
                 }
+
+                if (state.isActive === false) { // #whyDoWeNeedToCheckForInactiveState
+                    setIsScrolling(false);
+                    return;
+                }
                 
@@ -346,3 +361,3 @@ easingLoop = setInterval(function () {
                     // cancel if speed is not set or too low
-                    if (lowSpeed) { 
+                    if (lowSpeed || state.isActive === false) { // #whyDoWeNeedToCheckForInactiveState
                         clearInterval(easingLoop);
@@ -349,0 +364,0 @@ setIsScrolling(false);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

562002

increased by0.25%

Lines of code

8149

increased by0.33%

No dependency changes