dynamodb-recs - npm Package Compare versions

Comparing version 1.0.12 to 1.0.13

handlers/logsProcess.js

@@ -1,2 +0,1 @@
-const _ = require('lodash');
 const error = require('simple-beauty-error');
@@ -19,3 +18,3 @@
             .subscribe(response => {
-                callback(null, toResponse(_.size(response), 200, isApiGateway));
+                callback(null, toResponse(response, 200, isApiGateway));
             }, err => {
@@ -22,0 +21,0 @@ console.log(JSON.stringify(error(err, event, 5), null, 2));

handlers/logsProcess.spec.js

@@ -17,3 +17,3 @@ const chai = require('chai');
         sinon.stub(app.models.logs, 'process')
-            .returns(rx.of([]));
+            .returns(rx.of(0));
     });
@@ -20,0 +20,0 @@

models/Logs.js

@@ -135,3 +135,3 @@ const _ = require('lodash');
 
-                    return request.limit(args.limit)
+                    return request.limit(this.options.process.concurrency)
                         .queryScan(
@@ -148,6 +148,8 @@ `#namespace = :namespace AND #updatedAt <= :updatedAt`,
                                                 );
-                                        }, this.options.process.concurrency),
+                                        }),
                                         rxop.toArray(),
                                         rxop.mergeMap(response => {
-                                            if (_.size(response)) {
+                                            const processed = _.size(response);
+
+                                            if (processed) {
                                                 return this.request.batchWrite(_.map(response, data => {
@@ -160,7 +162,7 @@ return {
                                                     .pipe(
-                                                        rxop.mapTo(response)
+                                                        rxop.mapTo(processed)
                                                     );
                                             }
 
-                                            return rx.of(response);
+                                            return rx.of(processed);
                                         })
@@ -171,5 +173,5 @@ );
                         .pipe(
-                            rxop.reduce((reduction, response) => {
-                               return reduction.concat(response);
-                            }, [])
+                            rxop.reduce((reduction, processed) => {
+                               return reduction += processed;
+                            }, 0)
                         );
@@ -176,0 +178,0 @@ })

models/Logs.spec.js

@@ -178,3 +178,3 @@ const chai = require('chai');
                 .subscribe(response => {
-                    expect(response).to.deep.equal([]);
+                    expect(response).to.deep.equal(0);
                     expect(app.models.recs.ingest).to.not.have.been.called;
@@ -190,3 +190,4 @@ }, null, done);
                     rxop.tap(response => {
-                        expect(response).to.deep.equal([{
+                        expect(response).to.equal(1);
+                        expect(app.models.recs.ingest).to.have.been.calledOnceWithExactly({
                             collection: [
@@ -200,6 +201,4 @@ '0',
                             id: 'id',
-                            ttl: response[0].ttl
-                        }]);
-
-                        expect(app.models.recs.ingest).to.have.been.calledOnceWithExactly(response[0]);
+                            ttl: sinon.match.number
+                        });
                     }),
@@ -213,3 +212,3 @@ rxop.mergeMap(response => {
                 .subscribe(response => {
-                    expect(response).to.deep.equal([]);
+                    expect(response).to.deep.equal(0);
                 }, null, done);
@@ -216,0 +215,0 @@ });

models/schema/logs.js

@@ -41,5 +41,3 @@ const joi = require('@hapi/joi');
 const process_ = joi.object({
-    immediate: joi.boolean(),
-    limit: joi.number()
-        .default(200)
+    immediate: joi.boolean()
 });
@@ -46,0 +44,0 @@

package.json

 {
     "name": "dynamodb-recs",
-    "version": "1.0.12",
+    "version": "1.0.13",
     "main": "index.js",
@@ -5,0 +5,0 @@ "license": "MIT",

No alert changes

Worsened metrics

Total package byte prevSize

70737

decreased by-0.06%

Lines of code

1967

decreased by-0.1%

No dependency changes