effection - npm Package Compare versions

Comparing version 0.4.0-aa88a97 to 0.4.0-bbebdf3

dist-node/index.js

@@ -33,5 +33,11 @@ 'use strict';
 
-    let noop = x => x;
+    let noop = x => x; // return values of succeed and fail are deliberately ignored.
+    // see https://github.com/thefrontside/effection.js/pull/44
 
-    promise.then(value => succeed(value), error => fail(error)); // this execution has passed out of scope, so we don't care
+
+    promise.then(value => {
+      succeed(value);
+    }, error => {
+      fail(error);
+    }); // this execution has passed out of scope, so we don't care
     // what happened to the promise, so make the callbacks noops.
@@ -38,0 +44,0 @@ // this effectively "unsubscribes" to the promise.

dist-src/promise-of.js

@@ -11,5 +11,11 @@ /**
 
-    let noop = x => x;
+    let noop = x => x; // return values of succeed and fail are deliberately ignored.
+    // see https://github.com/thefrontside/effection.js/pull/44
 
-    promise.then(value => succeed(value), error => fail(error)); // this execution has passed out of scope, so we don't care
+
+    promise.then(value => {
+      succeed(value);
+    }, error => {
+      fail(error);
+    }); // this execution has passed out of scope, so we don't care
     // what happened to the promise, so make the callbacks noops.
@@ -16,0 +22,0 @@ // this effectively "unsubscribes" to the promise.

dist-web/index.js

@@ -30,5 +30,11 @@ /**
 
-    let noop = x => x;
+    let noop = x => x; // return values of succeed and fail are deliberately ignored.
+    // see https://github.com/thefrontside/effection.js/pull/44
 
-    promise.then(value => succeed(value), error => fail(error)); // this execution has passed out of scope, so we don't care
+
+    promise.then(value => {
+      succeed(value);
+    }, error => {
+      fail(error);
+    }); // this execution has passed out of scope, so we don't care
     // what happened to the promise, so make the callbacks noops.
@@ -35,0 +41,0 @@ // this effectively "unsubscribes" to the promise.

index.d.ts

 declare module "effection" {
-  export type Operation = SequenceFn | Sequence | Promise<any> | Controller | undefined;
+  export type Operation = SequenceFn | Sequence | Promise<any> | Controller | Execution<any> | undefined;
   export type SequenceFn = (this: Execution) => Sequence;
@@ -4,0 +4,0 @@ export type Controller = (execution: Execution) => void | (() => void);

package.json

 {
   "name": "effection",
   "description": "Effortlessly composable structured concurrency primitive for JavaScript",
-  "version": "0.4.0-aa88a97",
+  "version": "0.4.0-bbebdf3",
   "license": "MIT",
@@ -6,0 +6,0 @@ "files": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

37857

increased by1.31%

Lines of code

921

increased by1.66%

No dependency changes