egg-jaeger - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

app/extend/application.js

@@ -20,8 +20,5 @@ 'use strict';
   },
-  startSpan(name, tags) {
+  startSpan(name, tags = {}) {
     const childOf = als.get('span');
-    const span = this.jaeger.startSpan(name, childOf ? { childOf } : { });
-    if (tags) {
-      span.addTags(tags);
-    }
+    const span = this.jaeger.startSpan(name, childOf ? { childOf, tags } : { tags });
     als.set('span', span);
@@ -28,0 +25,0 @@ return span;

app/middleware/jaeger.js

@@ -11,2 +11,3 @@ 'use strict';
     await next();
+    span.finish();
   } catch (err) {
@@ -20,4 +21,5 @@ span.setTag(app.opentracing.Tags.ERROR, true);
     });
+    span.finish();
+    throw err;
   }
-  span.finish();
 };

package.json

 {
   "name": "egg-jaeger",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "",
@@ -5,0 +5,0 @@ "eggPlugin": {

No alert changes

Improved metrics

Total package byte prevSize

6416

increased by0.06%

Worsened metrics

Lines of code

96

decreased by-1.03%

No dependency changes