electron-chromedriver - npm Package Compare versions

Comparing version 2.0.0 to 3.0.0-beta.1

download-chromedriver.js

@@ -5,15 +5,4 @@ var fs = require('fs')
 var extractZip = require('extract-zip')
-
 var versionToDownload = require('./package').version
 
-download(versionToDownload, function (err, zipPath) {
-  if (err) {
-    var versionSegments = versionToDownload.split('.')
-    var baseVersion = versionSegments[0] + '.' + versionSegments[1] + '.0'
-    download(baseVersion, processDownload)
-  } else {
-    processDownload(err, zipPath)
-  }
-})
-
 function download (version, callback) {
@@ -34,3 +23,2 @@ electronDownload({
     if (error != null) throw error
-    console.log('successfully downloaded and extracted!')
     if (process.platform !== 'win32') {
@@ -43,1 +31,11 @@ fs.chmod(path.join(__dirname, 'bin', 'chromedriver'), '755', function (error) {
 }
+
+download(versionToDownload, function (err, zipPath) {
+  if (err) {
+    var versionSegments = versionToDownload.split('.')
+    var baseVersion = versionSegments[0] + '.' + versionSegments[1] + '.0'
+    download(baseVersion, processDownload)
+  } else {
+    processDownload(err, zipPath)
+  }
+})

package.json

 {
   "name": "electron-chromedriver",
-  "version": "2.0.0",
+  "version": "3.0.0-beta.1",
   "description": "Electron ChromeDriver",
@@ -5,0 +5,0 @@ "repository": "https://github.com/electron/chromedriver",

README.md

 # Electron ChromeDriver
 
-[![Linux Build Status](https://circleci.com/gh/electron/chromedriver/tree/master.svg?style=shield)](https://circleci.com/gh/electron/chromedriver/tree/master)
-[![Mac Build Status](https://mac-ci.electronjs.org/buildStatus/icon?job=Electron%20org/chromedriver/master)](https://mac-ci.electronjs.org/blue/organizations/jenkins/Electron%20org%2Fchromedriver/activity?branch=master)
+[![Linux and Mac Build Status](https://circleci.com/gh/electron/chromedriver/tree/master.svg?style=shield)](https://circleci.com/gh/electron/chromedriver/tree/master)
 [![Windows Build status](https://ci.appveyor.com/api/projects/status/43safb37jdlaeviw/branch/master?svg=true)](https://ci.appveyor.com/project/electron-bot/chromedriver/branch/master)
@@ -11,3 +10,3 @@ <br>
 [![license:mit](https://img.shields.io/badge/license-mit-blue.svg)](https://opensource.org/licenses/MIT)
-[![npm:](https://img.shields.io/npm/v/electron-chromedriver.svg)](https://www.npmjs.com/packages/electron-chromedriver)
+[![npm:](https://img.shields.io/npm/v/electron-chromedriver.svg)](https://www.npmjs.com/package/electron-chromedriver)
 [![dependencies:?](https://img.shields.io/npm/dm/electron-chromedriver.svg)](https://www.npmjs.com/packages/electron-chromedriver)
@@ -18,5 +17,5 @@
 
-This minor version of this library tracks the minor version of the Electron
-versions released. So if you are using Electron `1.0.x` you would want to use
-an `electron-chromedriver` dependency of `~1.0.0` in your `package.json` file.
+The major version of this library tracks the major version of the Electron
+versions released. So if you are using Electron `2.0.x` you would want to use
+an `electron-chromedriver` dependency of `~2.0.0` in your `package.json` file.
 
@@ -23,0 +22,0 @@ This library is used by [spectron](https://github.com/electron/spectron).

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6030

increased by1.98%

Worsened metrics

Number of package files

5

decreased by-16.67%

Lines of code

54

decreased by-1.82%

Number of low quality alerts

2

increased by100%

Number of lines in readme file

42

decreased by-2.33%

No dependency changes