electron-installer-snap - npm Package Compare versions

Comparing version 3.0.0 to 3.0.1

package.json

 {
   "name": "electron-installer-snap",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "Build snapcraft packages for Electron applications",
   "author": "Mark Lee",
-  "license": "MIT",
+  "license": "Apache-2.0",
   "main": "src/index.js",
@@ -20,3 +20,4 @@ "bin": {
     "lint": "eslint .",
-    "test": "npm run lint && npm run ava"
+    "test": "npm run lint && npm run ava",
+    "test:fast": "cross-env FAST_TESTS_ONLY=1 npm test"
   },
@@ -32,17 +33,19 @@ "repository": "electron-userland/electron-installer-snap",
   "devDependencies": {
-    "ava": "^0.25.0",
-    "codecov": "^3.0.0",
-    "eslint": "^4.7.2",
-    "eslint-config-standard": "^11.0.0",
-    "eslint-plugin-ava": "^4.4.0",
-    "eslint-plugin-import": "^2.7.0",
-    "eslint-plugin-node": "^6.0.0",
-    "eslint-plugin-promise": "^3.5.0",
-    "eslint-plugin-standard": "^3.0.1",
-    "nyc": "^11.4.1"
+    "ava": "^1.0.1",
+    "codecov": "^3.1.0",
+    "cross-env": "^5.2.0",
+    "eslint": "^5.11.0",
+    "eslint-config-standard": "^12.0.0",
+    "eslint-plugin-ava": "^5.1.1",
+    "eslint-plugin-import": "^2.14.0",
+    "eslint-plugin-node": "^8.0.0",
+    "eslint-plugin-promise": "^4.0.1",
+    "eslint-plugin-standard": "^4.0.0",
+    "nyc": "^13.1.0"
   },
   "dependencies": {
-    "asar": "^0.14.0",
+    "asar": "^0.14.6",
     "cross-spawn-promise": "^0.10.1",
-    "debug": "^3.0.1",
+    "debug": "^4.1.1",
+    "electron-installer-common": "^0.3.0",
     "fs-extra": "^5.0.0",
@@ -55,7 +58,6 @@ "js-yaml": "^3.10.0",
     "nodeify": "^1.0.1",
-    "pify": "^3.0.0",
-    "semver": "^5.5.0",
+    "pify": "^4.0.1",
     "tmp-promise": "^1.0.3",
     "which": "^1.3.0",
-    "yargs": "^11.0.0"
+    "yargs": "^12.0.5"
   },
@@ -62,0 +64,0 @@ "engines": {

src/yaml.js

@@ -19,2 +19,3 @@ 'use strict'
 const debug = require('debug')('electron-installer-snap:yaml')
+const dependencies = require('electron-installer-common/src/dependencies')
 const fs = require('fs-extra')
@@ -24,3 +25,3 @@ const merge = require('lodash.merge')
 const pull = require('lodash.pull')
-const semver = require('semver')
+const readElectronVersion = require('electron-installer-common/src/readelectronversion')
 const yaml = require('js-yaml')
@@ -30,2 +31,9 @@
 
+const DEPENDENCY_MAP = {
+  gconf: 'libgconf2-4',
+  gtk2: 'desktop-gtk2',
+  gtk3: 'desktop-gtk3',
+  uuid: 'libuuid1'
+}
+
 const FEATURES = {
@@ -156,22 +164,14 @@ audio: {
 
-    return this.updateGTKDependency(packageDir)
+    return readElectronVersion(packageDir)
+      .then(version => this.updateDependencies(version))
   }
 
-  updateGTKDependency (packageDir) {
-    return this.readElectronVersion(packageDir)
-      .then(version => {
-        if (semver.gte(version, '2.0.0-beta.1')) {
-          this.parts.after[0] = 'desktop-gtk3'
-        }
+  updateDependencies (version) {
+    this.parts.after[0] = dependencies.getGTKDepends(version, DEPENDENCY_MAP)
+    this.parts['stage-packages'] = this.parts['stage-packages'].concat(dependencies.getGConfDepends(version, DEPENDENCY_MAP))
+      .concat(dependencies.getUUIDDepends(version, DEPENDENCY_MAP))
 
-        return this.data
-      })
+    return this.data
   }
 
-  readElectronVersion (packageDir) {
-    return fs.readFile(path.resolve(packageDir, 'version'))
-      // The content of the version file is the tag name, e.g. "v1.8.1"
-      .then(tag => tag.toString().slice(1).trim())
-  }
-
   transform (packageDir, userSupplied) {
@@ -178,0 +178,0 @@ this.appName = userSupplied.name

Fixed alerts

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

362432

increased by0.07%

Number of low license alerts

0

decreased by-100%

Worsened metrics

Dev dependency count

11

increased by10%

Dependency changes

• + Addedelectron-installer-common@^0.3.0

• + Added@types/glob@8.1.0(transitive)

• + Added@types/minimatch@5.1.2(transitive)

• + Added@types/node@22.10.7(transitive)

• + Addedauthor-regex@1.0.0(transitive)

• + Addedcamelcase@5.3.1(transitive)

• + Addeddebug@4.4.0(transitive)

• + Addedelectron-installer-common@0.3.0(transitive)

• + Addedfind-up@3.0.0(transitive)

• + Addedfs-extra@7.0.1(transitive)

• + Addedglob-promise@3.4.0(transitive)

• + Addedlocate-path@3.0.0(transitive)

• + Addedlodash@4.17.21(transitive)

• + Addedp-limit@2.3.0(transitive)

• + Addedp-locate@3.0.0(transitive)

• + Addedp-try@2.2.0(transitive)

• + Addedparse-author@2.0.0(transitive)

• + Addedpify@4.0.1(transitive)

• + Addedundici-types@6.20.0(transitive)

• + Addedy18n@4.0.3(transitive)

• + Addedyargs@12.0.5(transitive)

• + Addedyargs-parser@11.1.1(transitive)

• - Removedsemver@^5.5.0

• - Removedcamelcase@4.1.0(transitive)

• - Removeddebug@3.2.7(transitive)

• - Removedfind-up@2.1.0(transitive)

• - Removedlocate-path@2.0.0(transitive)

• - Removedp-limit@1.3.0(transitive)

• - Removedp-locate@2.0.0(transitive)

• - Removedp-try@1.0.0(transitive)

• - Removedpify@3.0.0(transitive)

• - Removedy18n@3.2.2(transitive)

• - Removedyargs@11.1.1(transitive)

• - Removedyargs-parser@9.0.2(transitive)

• Updatedasar@^0.14.6

• Updateddebug@^4.1.1

• Updatedpify@^4.0.1

• Updatedyargs@^12.0.5