electron-notarize - npm Package Compare versions

Comparing version 0.0.5 to 0.1.0

lib/index.d.ts

@@ -9,6 +9,9 @@ export interface NotarizeCredentials {
 }
+export interface TransporterOptions {
+    ascProvider?: string;
+}
 export interface NotarizeResult {
     uuid: string;
 }
-export declare type NotarizeStartOptions = NotarizeAppOptions & NotarizeCredentials;
+export declare type NotarizeStartOptions = NotarizeAppOptions & NotarizeCredentials & TransporterOptions;
 export declare type NotarizeWaitOptions = NotarizeResult & NotarizeCredentials;
@@ -20,2 +23,2 @@ export declare type NotarizeStapleOptions = Pick<NotarizeAppOptions, 'appPath'>;
 export declare function stapleApp(opts: NotarizeStapleOptions): Promise<void>;
-export declare function notarize({ appBundleId, appPath, appleId, appleIdPassword, }: NotarizeOptions): Promise<void>;
+export declare function notarize({ appBundleId, appPath, appleId, appleIdPassword, ascProvider, }: NotarizeOptions): Promise<void>;

lib/index.js

@@ -50,3 +50,3 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
                     return [4 /*yield*/, helpers_1.withTempDir(function (dir) { return __awaiter(_this, void 0, void 0, function () {
-                            var zipPath, zipResult, result, uuidMatch;
+                            var zipPath, zipResult, notarizeArgs, result, uuidMatch;
                             return __generator(this, function (_a) {
@@ -71,14 +71,18 @@ switch (_a.label) {
                                         d('zip succeeded, attempting to upload to apple');
-                                        return [4 /*yield*/, spawn_1.spawn('xcrun', [
-                                                'altool',
-                                                '--notarize-app',
-                                                '-f',
-                                                zipPath,
-                                                '--primary-bundle-id',
-                                                opts.appBundleId,
-                                                '-u',
-                                                helpers_1.makeSecret(opts.appleId),
-                                                '-p',
-                                                helpers_1.makeSecret(opts.appleIdPassword),
-                                            ])];
+                                        notarizeArgs = [
+                                            'altool',
+                                            '--notarize-app',
+                                            '-f',
+                                            zipPath,
+                                            '--primary-bundle-id',
+                                            opts.appBundleId,
+                                            '-u',
+                                            helpers_1.makeSecret(opts.appleId),
+                                            '-p',
+                                            helpers_1.makeSecret(opts.appleIdPassword),
+                                        ];
+                                        if (opts.ascProvider) {
+                                            notarizeArgs.push('-itc_provider', opts.ascProvider);
+                                        }
+                                        return [4 /*yield*/, spawn_1.spawn('xcrun', notarizeArgs)];
                                     case 2:
@@ -179,3 +183,3 @@ result = _a.sent();
 function notarize(_a) {
-    var appBundleId = _a.appBundleId, appPath = _a.appPath, appleId = _a.appleId, appleIdPassword = _a.appleIdPassword;
+    var appBundleId = _a.appBundleId, appPath = _a.appPath, appleId = _a.appleId, appleIdPassword = _a.appleIdPassword, ascProvider = _a.ascProvider;
     return __awaiter(this, void 0, void 0, function () {
@@ -190,2 +194,3 @@ var uuid;
                         appleIdPassword: appleIdPassword,
+                        ascProvider: ascProvider,
                     })];
@@ -192,0 +197,0 @@ case 1:

package.json

 {
   "name": "electron-notarize",
-  "version": "0.0.5",
+  "version": "0.1.0",
   "description": "Notarize your Electron app",
@@ -14,14 +14,18 @@ "main": "lib/index.js",
   },
+  "files": [
+    "lib",
+    "README.md"
+  ],
   "devDependencies": {
-    "@types/debug": "^0.0.31",
-    "@types/fs-extra": "^5.0.4",
-    "electron": "^3.0.5",
-    "tslint": "^5.11.0",
-    "tslint-config-airbnb": "^5.11.0",
-    "typescript": "^3.1.3"
+    "@types/debug": "^4.1.4",
+    "@types/fs-extra": "^7.0.0",
+    "electron": "^5.0.2",
+    "tslint": "^5.16.0",
+    "tslint-config-airbnb": "^5.11.1",
+    "typescript": "^3.4.5"
   },
   "dependencies": {
-    "debug": "^4.1.0",
-    "fs-extra": "^7.0.0"
+    "debug": "^4.1.1",
+    "fs-extra": "^8.0.1"
   }
 }

README.md

@@ -36,2 +36,3 @@ Electron Notarize
   * `appleIdPassword` String - The password for your apple developer account
+  * `ascProvider` String (optional) - Your [Team ID](https://developer.apple.com/account/#/membership) in App Store Connect. This is necessary if you are part of multiple teams
 
@@ -60,4 +61,5 @@ #### Safety when using `appleIdPassword`
     appleIdPassword,
+    ascProvider, // This parameter is optional
   });
 }
 ```

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of lines in readme file

64

increased by3.23%

Worsened metrics

Total package byte prevSize

28926

decreased by-56.88%

Number of package files

11

decreased by-15.38%

Dependency changes

• + Addedfs-extra@8.1.0(transitive)

• - Removedfs-extra@7.0.1(transitive)

• Updateddebug@^4.1.1

• Updatedfs-extra@^8.0.1