electron-notarize - npm Package Compare versions

Comparing version 1.1.1 to 1.2.1

lib/notarytool.js

@@ -40,3 +40,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
     else {
-        return ['--keychain', opts.keychain, '--keychain-profile', opts.keychainProfile];
+        // --keychain is optional -- when not specified, the iCloud keychain is used by notarytool
+        if (opts.keychain) {
+            return ['--keychain', opts.keychain, '--keychain-profile', opts.keychainProfile];
+        }
+        return ['--keychain-profile', opts.keychainProfile];
     }
@@ -55,3 +59,3 @@ }
         return yield helpers_1.withTempDir((dir) => __awaiter(this, void 0, void 0, function* () {
-            const zipPath = path.resolve(dir, `${path.basename(opts.appPath, '.app')}.zip`);
+            const zipPath = path.resolve(dir, `${path.parse(opts.appPath).name}.zip`);
             d('zipping application to:', zipPath);
@@ -58,0 +62,0 @@ const zipResult = yield spawn_1.spawn('ditto', ['-c', '-k', '--sequesterRsrc', '--keepParent', path.basename(opts.appPath), zipPath], {

lib/types.d.ts

@@ -21,3 +21,3 @@ export interface LegacyNotarizePasswordCredentials {
     keychainProfile: string;
-    keychain: string;
+    keychain?: string;
 }
@@ -24,0 +24,0 @@ export declare type LegacyNotarizeCredentials = LegacyNotarizePasswordCredentials | LegacyNotarizeApiKeyCredentials;

lib/validate-args.js

@@ -93,6 +93,3 @@ Object.defineProperty(exports, "__esModule", { value: true });
         const keychainCreds = opts;
-        if (!keychainCreds.keychain) {
-            throw new Error('The keychain property is required when using notarization with keychain credentials');
-        }
-        else if (!keychainCreds.keychainProfile) {
+        if (!keychainCreds.keychainProfile) {
             throw new Error('The keychainProfile property is required when using notarization with keychain credentials');
@@ -99,0 +96,0 @@ }

package.json

 {
   "name": "electron-notarize",
-  "version": "1.1.1",
+  "version": "1.2.1",
   "description": "Notarize your Electron app",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

49323

increased by0.09%

Lines of code

586

increased by0.17%

No dependency changes