ember-cli-blueprint-test-helpers - npm Package Compare versions

Comparing version 0.17.1 to 0.17.2

chai.js

@@ -10,1 +10,2 @@ var chai = require('chai');
 module.exports.file = chaiFiles.file;
+module.exports.dir = chaiFiles.dir;

CHANGELOG.md

 # Change Log
 
+## [v0.17.2](https://github.com/ember-cli/ember-cli-blueprint-test-helpers/tree/v0.17.2) (2017-04-06)
+[Full Changelog](https://github.com/ember-cli/ember-cli-blueprint-test-helpers/compare/v0.17.1...v0.17.2)
+
+**Merged pull requests:**
+
+- Cleanup symlinked addon after tests [\#98](https://github.com/ember-cli/ember-cli-blueprint-test-helpers/pull/98) ([simonihmig](https://github.com/simonihmig))
+
 ## [v0.17.1](https://github.com/ember-cli/ember-cli-blueprint-test-helpers/tree/v0.17.1) (2017-03-23)
@@ -4,0 +11,0 @@ [Full Changelog](https://github.com/ember-cli/ember-cli-blueprint-test-helpers/compare/v0.17.0...v0.17.1)

lib/helpers/setup.js

 'use strict';
 
+var path             = require('path');
 var RSVP             = require('rsvp');
@@ -9,3 +10,3 @@ var MockBlueprintTaskFor = require('ember-cli-internal-test-helpers/lib/helpers/mock-blueprint-task-for');
 var debug            = require('debug')('ember-cli:testing');
-var requireFromCLI = require('./require-from-cli');
+var requireFromCLI   = require('./require-from-cli');
 
@@ -55,4 +56,9 @@ /**
     process.chdir(tmp.root);
-    return remove(tmp.tmproot);
+    return remove(tmp.tmproot)
+      .then(function() {
+        // remove symlinked addon added by emberNew
+        var projectName = require(path.resolve(process.cwd(), 'package.json')).name;
+        return remove(path.join('node_modules', projectName));
+      })
   });
 };

package.json

 {
   "name": "ember-cli-blueprint-test-helpers",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "description": "Blueprint test helpers for ember-cli. Mocks ember-cli for generate and destroy commands.",
@@ -5,0 +5,0 @@ "main": "index.js",

tests/acceptance/helpers-test.js

@@ -6,5 +6,7 @@ var setupTestHooks = require('../../lib/helpers/setup');
 var emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
+var path = require('path');
 
 var chai = require('../../chai');
 var expect = chai.expect;
+var dir = chai.dir;
 
@@ -23,2 +25,17 @@ describe('Acceptance: helpers', function() {
   });
+
+  describe('setupTestHooks', function() {
+    var symlink = path.resolve(__dirname, '..', '..', 'node_modules', 'ember-cli-blueprint-test-helpers');
+
+    after(function() {
+      expect(dir(symlink)).to.not.exist;
+    });
+
+    it('cleans up symlinked addon', function() {
+      return emberNew()
+        .then(() => {
+          expect(dir(symlink)).to.exist;
+        });
+    });
+  });
 });

New alerts

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

46857

increased by2.5%

Lines of code

504

increased by4.35%

Worsened metrics

Number of low supply chain risk alerts

8

increased by14.29%

No dependency changes