ember-modal-dialog - npm Package Compare versions

Comparing version 2.4.3 to 2.4.4

addon/components/basic-dialog.js

@@ -73,3 +73,4 @@ import Component from '@ember/component';
       // if the click is within the dialog, do nothing
-      if (document.querySelector(modalSelector).contains(target)) {
+      let modalEl = document.querySelector(modalSelector);
+      if (modalEl && modalEl.contains(target)) {
         return;
@@ -76,0 +77,0 @@ }

CHANGELOG.md

 # Change Log
 
+## [2.4.4](https://github.com/yapplabs/ember-modal-dialog/tree/v2.4.4) (2018-05-13)
+[Full Changelog](https://github.com/yapplabs/ember-modal-dialog/compare/2.4.3...v2.4.4)
+
+Backported https://github.com/yapplabs/ember-modal-dialog/pull/246/commits/984a1554f1be325a194fafd0ab088987bad8e343
+
 ## [2.4.3](https://github.com/yapplabs/ember-modal-dialog/tree/2.4.3) (2018-03-03)
@@ -329,2 +334,2 @@ [Full Changelog](https://github.com/yapplabs/ember-modal-dialog/compare/v2.4.2...2.4.3)
 
-\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
+\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

package.json

 {
   "name": "ember-modal-dialog",
-  "version": "2.4.3",
+  "version": "2.4.4",
   "description": "An ember-cli addon for implementing modal dialogs",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

348988

increased by0.09%

Lines of code

742

increased by0.13%

No dependency changes