ember-redux - npm Package Compare versions

Comparing version 1.5.3 to 1.6.0

addon/components/connect.js

 import Ember from 'ember';
+import shallowEqual from '../-private/equal';
 
@@ -41,10 +42,27 @@ const { computed, defineProperty } = Ember;
                 if (shouldSubscribe && !this.unsubscribe) {
-                    this.unsubscribe = redux.subscribe(() => {
-                        props.forEach(function(name) {
-                            component.notifyPropertyChange(name);
-                        });
-                    });
+                    this.unsubscribe = redux.subscribe(this.handleChange.bind(this));
                 }
                 this._super(...arguments);
             },
+            handleChange() {
+                var redux = this.get('redux');
+                var props = mapState(redux.getState());
+                var componentState = this.getComponentState(props);
+                var reduxState = finalMapStateToComputed(redux.getState());
+                if (!shallowEqual(componentState, reduxState)) {
+                    this.updateProps(props);
+                }
+            },
+            getComponentState(props) {
+                var componentState = {};
+                props.forEach((name) => {
+                    componentState[name] = this.get(name);
+                });
+                return componentState;
+            },
+            updateProps(props) {
+                props.forEach((name) => {
+                    this.notifyPropertyChange(name);
+                });
+            },
             willDestroy() {
@@ -51,0 +69,0 @@ if (this.unsubscribe) {

CHANGELOG.md

 ember-redux Changelog
 ==============================
 
+1.6.0
+-----
+
+* [PERFORMANCE]: only notifyPropertyChange when a value is diff between redux and component
+  ([#23](https://github.com/toranb/ember-redux/pull/23))
+
+
 1.5.3
@@ -5,0 +12,0 @@ -----

package.json

 {
   "name": "ember-redux",
-  "version": "1.5.3",
+  "version": "1.6.0",
   "description": "ember-cli addon that provides simple redux bindings for ember.js",
@@ -5,0 +5,0 @@ "directories": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

140907

increased by1.09%

Number of package files

19

increased by5.56%

Lines of code

183

increased by26.21%

No dependency changes