engine.io-client - npm Package Compare versions

Comparing version 0.8.2 to 0.9.0

component.json

@@ -11,3 +11,4 @@ {
     "LearnBoost/engine.io-protocol": "0.3.0",
-    "visionmedia/debug": "*"
+    "visionmedia/debug": "*",
+    "component/xmlhttprequest": "0.0.1"
   },
@@ -14,0 +15,0 @@ "main": "lib/index.js",

engine.io.js

@@ -368,3 +368,3 @@ !function(e){"object"==typeof exports?module.exports=e():"function"==typeof define&&define.amd?define(e):"undefined"!=typeof window?window.eio=e():"undefined"!=typeof global?global.eio=e():"undefined"!=typeof self&&(self.eio=e())}(function(){var define,module,exports;
   // we check for `readyState` in case an `open`
-  // listener alreay closed the socket
+  // listener already closed the socket
   if ('open' == this.readyState && this.upgrade && this.transport.pause) {
@@ -621,3 +621,2 @@ debug('starting upgrade probes');
     // set ready state
-    var prev = this.readyState;
     this.readyState = 'closed';
@@ -628,7 +627,5 @@
 
-    // emit events
-    if (prev == 'open') {
-      this.emit('close', reason, desc);
-      this.onclose && this.onclose.call(this);
-    }
+    // emit close event
+    this.emit('close', reason, desc);
+    this.onclose && this.onclose.call(this);
   }
@@ -1369,3 +1366,3 @@ };
 
-var xobject = global[['Active'].concat('Object').join('X')];
+var hasAttachEvent = global.document && global.document.attachEvent;
 
@@ -1543,3 +1540,3 @@ /**
 
-  if (xobject) {
+  if (hasAttachEvent) {
     this.index = Request.requestsCount++;
@@ -1600,3 +1597,3 @@ Request.requests[this.index] = this;
 
-  if (xobject) {
+  if (hasAttachEvent) {
     delete Request.requests[this.index];
@@ -1618,3 +1615,8 @@ }
 
-if (xobject) {
+/**
+ * Cleanup is needed for old versions of IE
+ * that leak memory unless we abort request before unload.
+ */
+
+if (hasAttachEvent) {
   Request.requestsCount = 0;
@@ -1872,3 +1874,2 @@ Request.requests = {};
 var Transport = require('../transport');
-var WebSocket = require('ws');
 var parser = require('engine.io-parser');
@@ -1879,2 +1880,10 @@ var util = require('../util');
 /**
+ * `ws` exposes a WebSocket-compatible interface in
+ * Node, or the `WebSocket` or `MozWebSocket` globals
+ * in the browser.
+ */
+
+var WebSocket = require('ws');
+
+/**
  * Module exports.
@@ -2232,3 +2241,3 @@ */
 
-var re = /^(?:(?![^:@]+:[^:@\/]*@)([^:\/?#.]+):)?(?:\/\/)?((?:(([^:@]*)(?::([^:@]*))?)?@)?([^:\/?#]*)(?::(\d*))?)(((\/(?:[^?#](?![^?#\/]*\.[^?#\/.]+(?:[?#]|$)))*\/?)?([^?#\/]*))(?:\?([^#]*))?(?:#(.*))?)/;
+var re = /^(?:(?![^:@]+:[^:@\/]*@)(http|https|ws|wss):\/\/)?((?:(([^:@]*)(?::([^:@]*))?)?@)?((?:[a-f0-9]{0,4}:){2,7}[a-f0-9]{0,4}|[^:\/?#]*)(?::(\d*))?)(((\/(?:[^?#](?![^?#\/]*\.[^?#\/.]+(?:[?#]|$)))*\/?)?([^?#\/]*))(?:\?([^#]*))?(?:#(.*))?)/;
 
@@ -2833,4 +2842,10 @@ var parts = [
 
-module.exports = 'XMLHttpRequest' in global &&
-  'withCredentials' in new global.XMLHttpRequest();
+try {
+  module.exports = 'XMLHttpRequest' in global &&
+    'withCredentials' in new global.XMLHttpRequest();
+} catch (err) {
+  // if XMLHttp support is disabled in IE then it will throw
+  // when trying to create
+  module.exports = false;
+}
 
@@ -2837,0 +2852,0 @@ },{"global":19}],21:[function(require,module,exports){

History.md

 
+0.9.0 / 2014-02-09
+==================
+
+ * Fix simple `host:port` URLs and IPV6 [bmalehorn]
+ * Fix XHR cleanup method [poohlty]
+ * Match semantics of `close` event with `WebSocket`. If an error occurs
+   and `open` hadn't fired before, we still emit `close` as per
+   WebSocket spec [mokesmokes].
+ * Removed SPEC (now in `engine.io-protocol` repository)
+ * Remove `Socket#open` docs (private API) [mokesmokes]
+
 0.8.2 / 2014-01-18
@@ -3,0 +14,0 @@ ==================

lib/socket.js

@@ -312,3 +312,3 @@ /**
   // we check for `readyState` in case an `open`
-  // listener alreay closed the socket
+  // listener already closed the socket
   if ('open' == this.readyState && this.upgrade && this.transport.pause) {
@@ -565,3 +565,2 @@ debug('starting upgrade probes');
     // set ready state
-    var prev = this.readyState;
     this.readyState = 'closed';
@@ -572,7 +571,5 @@
 
-    // emit events
-    if (prev == 'open') {
-      this.emit('close', reason, desc);
-      this.onclose && this.onclose.call(this);
-    }
+    // emit close event
+    this.emit('close', reason, desc);
+    this.onclose && this.onclose.call(this);
   }
@@ -579,0 +576,0 @@ };

lib/transports/polling-xhr.js

@@ -28,3 +28,3 @@ /**
 
-var xobject = global[['Active'].concat('Object').join('X')];
+var hasAttachEvent = global.document && global.document.attachEvent;
 
@@ -202,3 +202,3 @@ /**
 
-  if (xobject) {
+  if (hasAttachEvent) {
     this.index = Request.requestsCount++;
@@ -259,3 +259,3 @@ Request.requests[this.index] = this;
 
-  if (xobject) {
+  if (hasAttachEvent) {
     delete Request.requests[this.index];
@@ -277,3 +277,8 @@ }
 
-if (xobject) {
+/**
+ * Cleanup is needed for old versions of IE
+ * that leak memory unless we abort request before unload.
+ */
+
+if (hasAttachEvent) {
   Request.requestsCount = 0;
@@ -280,0 +285,0 @@ Request.requests = {};

lib/transports/websocket.js

@@ -6,3 +6,2 @@ /**
 var Transport = require('../transport');
-var WebSocket = require('ws');
 var parser = require('engine.io-parser');
@@ -13,2 +12,10 @@ var util = require('../util');
 /**
+ * `ws` exposes a WebSocket-compatible interface in
+ * Node, or the `WebSocket` or `MozWebSocket` globals
+ * in the browser.
+ */
+
+var WebSocket = require('ws');
+
+/**
  * Module exports.
@@ -15,0 +22,0 @@ */

lib/util.js

@@ -166,3 +166,3 @@
 
-var re = /^(?:(?![^:@]+:[^:@\/]*@)([^:\/?#.]+):)?(?:\/\/)?((?:(([^:@]*)(?::([^:@]*))?)?@)?([^:\/?#]*)(?::(\d*))?)(((\/(?:[^?#](?![^?#\/]*\.[^?#\/.]+(?:[?#]|$)))*\/?)?([^?#\/]*))(?:\?([^#]*))?(?:#(.*))?)/;
+var re = /^(?:(?![^:@]+:[^:@\/]*@)(http|https|ws|wss):\/\/)?((?:(([^:@]*)(?::([^:@]*))?)?@)?((?:[a-f0-9]{0,4}:){2,7}[a-f0-9]{0,4}|[^:\/?#]*)(?::(\d*))?)(((\/(?:[^?#](?![^?#\/]*\.[^?#\/.]+(?:[?#]|$)))*\/?)?([^?#\/]*))(?:\?([^#]*))?(?:#(.*))?)/;
 
@@ -169,0 +169,0 @@ var parts = [

package.json

 {
   "name": "engine.io-client",
   "description": "Client for the realtime Engine",
-  "version": "0.8.2",
+  "version": "0.9.0",
   "homepage": "http://socket.io",
@@ -26,3 +26,3 @@ "contributors": [
     "global": "https://github.com/component/global/archive/v2.0.1.tar.gz",
-    "has-cors": "https://github.com/component/has-cors/archive/v1.0.2.tar.gz",
+    "has-cors": "1.0.3",
     "ws": "0.4.31",
@@ -36,3 +36,3 @@ "xmlhttprequest": "https://github.com/LearnBoost/node-XMLHttpRequest/archive/0f36d0b5ebc03d85f860d42a64ae9791e1daa433.tar.gz",
   "devDependencies": {
-    "zuul": "1.3.0",
+    "zuul": "1.5.2",
     "mocha": "1.16.2",
@@ -39,0 +39,0 @@ "expect.js": "0.2.0",

README.md

@@ -0,1 +1,2 @@
+
 # Engine.IO client
@@ -107,3 +108,4 @@
 - `close`
-  - Fired upon disconnection.
+  - Fired upon disconnection. In compliance with the WebSocket API spec, this event may be 
+    fired even if the `open` event does not occur (i.e. due to connection error or `close()`).
 - `error`
@@ -159,7 +161,2 @@ - Fired when an error occurs.
 
-## Reconnecting
-
-A `Socket` instance can be reused. After closing (either by calling
-`Socket#close()` or network close), you can summon `open` again.
-
 ## Flash transport
@@ -166,0 +163,0 @@

Fixed alerts

HTTP dependency

Supply chain risk

Contains a dependency which resolves to a remote HTTP URL which could be used to inject untrusted code and reduce overall package reliability.

Found 1 instance in 1 package

Improved metrics

Lines of code

4228

increased by0.45%

Number of high supply chain risk alerts

3

decreased by-25%

Worsened metrics

Total package byte prevSize

122699

decreased by-4.25%

Number of package files

22

decreased by-4.35%

Number of lines in readme file

235

decreased by-1.26%

Dependency changes

• + Addedhas-cors@1.0.3(transitive)

• Updatedhas-cors@1.0.3