ep_ldapauth - npm Package Compare versions

Comparing version 0.0.4 to 0.0.5

ep_ldapauth.js

@@ -13,5 +13,2 @@ // Copyright 2013 Andrew Grimberg <[e-mail]>
 
-// ldapauthUsername is set by authenticate and used in messageHandler, keyed on express_sid
-var ldapauthUsername = {};
-
 function ldapauthSetUsername(token, username) {
@@ -56,7 +53,5 @@ console.debug('ep_ldapauth.ldapauthSetUsername: getting authorid for token %s', token);
       // User authenticated, save off some information needed for authorization
-      context.req.session.user = { username: username };
+      context.req.session.user = { username: username, displayName: user.cn };
       settings.globalUserName = username;
       console.debug('ep_ldapauth.authenticate: deferring setting of username [%s] to CLIENT_READY for express_sid = %s', username, express_sid);
-      // We use the CN / display name for our global username
-      ldapauthUsername[express_sid] = user.cn;
       return cb([true]);
@@ -128,5 +123,5 @@ });
       var client_id = context.client.id;
-      var express_sid = context.client.manager.handshaken[client_id].sessionID;
-      console.debug('ep_ldapauth.handleMessage: intercepted CLIENT_READY message for client_id = %s express_sid = %s, setting username for token %s to %s', client_id, express_sid, context.message.token, ldapauthUsername[express_sid]);
-      ldapauthSetUsername(context.message.token, ldapauthUsername[express_sid]);
+      var displayName = context.client.manager.handshaken[client_id].session.user.displayName;
+      console.debug('ep_ldapauth.handleMessage: intercepted CLIENT_READY message for client_id = %s, setting username for token %s to %s', client_id, context.message.token, displayName);
+      ldapauthSetUsername(context.message.token, displayName);
     }
@@ -133,0 +128,0 @@ } else if ( context.message.type == "COLLABROOM" && context.message.data.type == "USERINFO_UPDATE" ) {

package.json

@@ -5,3 +5,3 @@ {
   "author": "Andrew Grimberg <[e-mail]>",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "license": "GPLv2",
@@ -8,0 +8,0 @@ "repository": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

28141

decreased by-0.91%

Lines of code

225

decreased by-1.75%

No dependency changes