er_memcached_data_server - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

index.js

@@ -0,0 +0,0 @@ 'use strict';

package.json

 {
   "name": "er_memcached_data_server",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "Plugin for event_request that implements a memcached data server",
@@ -8,3 +8,3 @@ "main": "index.js",
     "test": "node ./tests/memcached_data_server_test",
-	"deploy": "npm run test && npm publish"
+    "deploy": "npm run test && npm publish"
   },
@@ -17,5 +17,5 @@ "repository": {
     "memcached",
-	"event-request",
-	"data-store",
-	"data-server"
+    "event-request",
+    "data-store",
+    "data-server"
   ],
@@ -29,5 +29,5 @@ "author": "Stefan Genov",
   "dependencies": {
-    "event_request": "^17.0.0",
+    "event_request": "^26.0.9",
     "memcached": "^2.2.2"
   }
 }

README.md

@@ -11,9 +11,9 @@ # er_memcached_data_server
 // Get the data server only
-const MemcachedDataServer   = require( 'er_memcached_data_server' );
+const MemcachedDataServer = require( 'er_memcached_data_server' );
 
 // Get the plugin that you can attach instead of the default one
-const { Server }            = require( 'event_request' );
-const app                   = Server();
+const { App } = require( 'event_request' );
+const app = App();
 
 app.apply( MemcachedDataServer.getPlugin() );
-~~~
+~~~

src/memcached_data_server.js

@@ -49,3 +49,3 @@ 'use strict';
 		return new Promise(( resolve, reject )=>{
-			this.server.get( key, function( err, response ){
+			this.server.get( key, ( err, response ) => {
 				if ( err )
@@ -52,0 +52,0 @@ reject( err );

tests/memcached_data_server_test.js

@@ -13,3 +13,3 @@ 'use strict';
 
-const app							= new Server.class();
+const app							= new Server();
 const dataServer					= new MemcachedDataServer();
@@ -98,14 +98,9 @@
 			const dataServer	= new MemcachedDataServer();
-			const key			= `key${Math.random()}`
+			const key			= `key${Math.random()}`;
 			const value			= 'value';
 			const ttl			= 100;
 			const persist		= true;
-			let called			= 0;
 
-			dataServer.on( 'set', ()=>{
-				called ++;
-			});
+			await dataServer.set( key, value, ttl, { persist } )
 
-			await dataServer.set( key, value, ttl, { persist } );
-
 			const dataSet	= await dataServer.get( key );
@@ -116,3 +111,2 @@
 			assert.equal( dataSet, value );
-			assert.equal( called, 1 );
 
@@ -204,13 +198,6 @@ removeCache( dataServer );
 			const dataServer	= new MemcachedDataServer( { persist: false } );
-			const key			= `key${Math.random()}`
+			const key			= `key${Math.random()}`;
 			const value			= 'value';
 			const ttl			= 100;
-			const persist		= true;
-			const expected		= { key: { key, value, ttl, persist } };
-			let called			= 0;
 
-			dataServer.on( 'get', ()=>{
-				called ++;
-			});
-
 			await dataServer.set( key, value, ttl );
@@ -220,3 +207,2 @@ const dataSet	= await dataServer.get( key );
 			assert.equal( dataSet, value );
-			assert.equal( called, 1 );
 
@@ -260,3 +246,3 @@ removeCache( dataServer );
 			const dataServer	= new MemcachedDataServer( { persist: false } );
-			const key			= `key${Math.random()}`
+			const key			= `key${Math.random()}`;
 			const value			= 'value';
@@ -279,5 +265,4 @@ const ttl			= 1;
 test({
-	message	: 'MemcachedDataServer.touch updates expirationDate',
+	message	: 'MemcachedDataServer.touch.updates.expirationDate',
 	test	: ( done )=>{
-		// Wait in case the file has not been deleted from the FS
 		setTimeout( async ()=>{
@@ -289,9 +274,3 @@ const dataServer	= new MemcachedDataServer( { persist: false } );
 			const persist		= true;
-			let called			= 0;
 
-			dataServer.on( 'touch', ()=>{
-				called ++;
-			});
-
-
 			await dataServer.set( key, value, ttl, { persist } );
@@ -304,3 +283,2 @@ await dataServer.touch( key, 5 );
 				assert.equal( dataSet, value );
-				assert.equal( called, 1 );
 
@@ -316,2 +294,3 @@ removeCache( dataServer );
 	message			: 'MemcachedDataServer.touch with invalid data',
+
 	dataProvider	: [
@@ -354,10 +333,5 @@ ['key', '123', {}],
 			const dataServer	= new MemcachedDataServer({ persist: false });
-			const key			= `key${Math.random()}`
+			const key			= `key${Math.random()}`;
 			const value			= { test: 'value' };
-			let called			= 0;
 
-			dataServer.on( 'delete', ()=>{
-				called ++;
-			});
-
 			await dataServer.set( key, value );
@@ -368,4 +342,2 @@
 			assert.equal( await dataServer.delete( key ), true );
-			// 2 because one is with invalid arguments
-			assert.equal( called, 2 );
 
@@ -397,8 +369,3 @@ removeCache( dataServer );
 		const key			= `key${Math.random()}`;
-		let called			= 0;
 
-		dataServer.on( 'increment', ()=>{
-			called ++;
-		});
-
 		await dataServer.set( key, value ).catch( done );
@@ -420,3 +387,2 @@
 		assert.equal( result, expectedValue );
-		assert.equal( called, 1 );
 
@@ -448,9 +414,4 @@ removeCache( dataServer );
 		const dataServer	= new MemcachedDataServer({ persist: false });
-		const key			= `key${Math.random()}`
-		let called			= 0;
+		const key			= `key${Math.random()}`;
 
-		dataServer.on( 'decrement', ()=>{
-			called ++;
-		});
-
 		await dataServer.set( key, value ).catch( done );
@@ -472,3 +433,2 @@
 		assert.equal( result, expectedValue );
-		assert.equal( called, 1 );
 
@@ -514,8 +474,3 @@ removeCache( dataServer );
 			const dataServer	= new MemcachedDataServer( { persist: false } );
-			let called			= 0;
 
-			dataServer.on( 'lock', ()=>{
-				called ++;
-			});
-
 			await dataServer.unlock( 'key' );
@@ -529,4 +484,2 @@
 
-			assert.equal( called, 4 );
-
 			removeCache( dataServer );
@@ -567,8 +520,3 @@ done();
 			const dataServer	= new MemcachedDataServer( { persist: false } );
-			let called			= 0;
 
-			dataServer.on( 'unlock', ()=>{
-				called ++;
-			});
-
 			assert.equal( await dataServer.unlock( 'key' ), true );
@@ -578,3 +526,2 @@ assert.equal( await dataServer.unlock( 'key' ), true );
 			assert.equal( await dataServer.unlock( 'key' ), true );
-			assert.equal( called, 3 );
 
@@ -581,0 +528,0 @@ await dataServer.unlock( 'key' );

UPDATELOG.md

@@ -0,1 +1,4 @@
+1.1.2
+- Fixed to work with newest version of event request
+
 1.1.1
@@ -2,0 +5,0 @@ - Fixed the MAX_TTL

No alert changes

Improved metrics

Total package byte prevSize

79419

increased by0.53%

Number of lines in readme file

19

increased by5.56%

Worsened metrics

Lines of code

1365

decreased by-3.12%

Dependency changes

• + Addedevent_request@26.3.0(transitive)

• - Removedevent_request@17.2.1(transitive)

• Updatedevent_request@^26.0.9