es6-symbol - npm Package Compare versions

Comparing version 0.0.0 to 0.1.0

is-implemented.js

@@ -6,4 +6,6 @@ 'use strict';
 	if (typeof Symbol !== 'function') return false;
-	symbol = new Symbol('test symbol');
-	if (String(symbol) !== 'Symbol (test symbol)') return false;
+	symbol = Symbol('test symbol');
+	try {
+		if (String(symbol) !== 'Symbol (test symbol)') return false;
+	} catch (e) { return false; }
 	if (typeof Symbol.iterator === 'symbol') return true;
@@ -10,0 +12,0 @@

package.json

 {
   "name": "es6-symbol",
-  "version": "0.0.0",
+  "version": "0.1.0",
   "description": "ECMAScript6 Symbol polyfill",
@@ -18,13 +18,13 @@ "author": "Mariusz Nowak <[e-mail]> (http://www.medikoo.com/)",
   },
-  "scripts": {
-    "test": "node ./node_modules/tad/bin/tad"
-  },
   "dependencies": {
-    "d": "git://github.com/medikoo/d.git",
-    "es5-ext": "git://github.com/medikoo/es5-ext.git"
+    "d": "~0.1.1",
+    "es5-ext": "~0.10.2"
   },
   "devDependencies": {
-    "tad": "~0.1.20"
+    "tad": "0.2.x"
   },
+  "scripts": {
+    "test": "node ./node_modules/tad/bin/tad"
+  },
   "license": "MIT"
 }

polyfill.js

 'use strict';
 
-var d = require('d/d')
+var d = require('d')
 
-  , defineProperties = Object.defineProperties
+  , create = Object.create, defineProperties = Object.defineProperties
   , generateName, Symbol;
 
 generateName = (function () {
-	var created = Object.create(null);
+	var created = create(null);
 	return function (desc) {
@@ -20,5 +20,9 @@ var postfix = 0;
 module.exports = Symbol = function (description) {
-	if (!(this instanceof Symbol)) return new Symbol(description);
+	var symbol;
+	if (this instanceof Symbol) {
+		throw new TypeError('TypeError: Symbol is not a constructor');
+	}
+	symbol = create(Symbol.prototype);
 	description = (description === undefined ? '' : String(description));
-	return defineProperties(this, {
+	return defineProperties(symbol, {
 		__description__: d('', description),
@@ -30,10 +34,10 @@ __name__: d('', generateName(description))
 Object.defineProperties(Symbol, {
-	create: d('', new Symbol('create')),
-	hasInstance: d('', new Symbol('hasInstance')),
-	isConcatSpreadable: d('', new Symbol('isConcatSpreadable')),
-	isRegExp: d('', new Symbol('isRegExp')),
-	iterator: d('', new Symbol('iterator')),
-	toPrimitive: d('', new Symbol('toPrimitive')),
-	toStringTag: d('', new Symbol('toStringTag')),
-	unscopables: d('', new Symbol('unscopables'))
+	create: d('', Symbol('create')),
+	hasInstance: d('', Symbol('hasInstance')),
+	isConcatSpreadable: d('', Symbol('isConcatSpreadable')),
+	isRegExp: d('', Symbol('isRegExp')),
+	iterator: d('', Symbol('iterator')),
+	toPrimitive: d('', Symbol('toPrimitive')),
+	toStringTag: d('', Symbol('toStringTag')),
+	unscopables: d('', Symbol('unscopables'))
 });
@@ -47,5 +51,2 @@
 });
-Object.defineProperty(Symbol.prototype, 'originalToString', d(function () {
-	return 'Symbol (' + this.__description__ + ')';
-}));
 Object.defineProperty(Symbol.prototype, Symbol.toPrimitive, d('',
@@ -52,0 +53,0 @@ function (hint) {

README.md

@@ -7,3 +7,3 @@ # es6-symbol
 - Underneath it uses real string property names which can easily be retrieved (however accidental collision with other property names is unlikely)
-- As it needs custom `toString` behavior to work properly. Original `Symbol.prototoype.toString` couldn't be implemented as specified, still it's accessible as `Symbol.prototoype.origigalToString`
+- As it needs custom `toString` behavior to work properly. Original `Symbol.prototoype.toString` couldn't be implemented as specified, still it's accessible as `Symbol.prototoype.properToString`
 
@@ -24,3 +24,3 @@ ### Usage
 
-If you strictly want to use polyfill even if native `Symbol` exists (hard to find good reason for that), do:
+If you strictly want to use polyfill even if native `Symbol` exists (hard to find a good reason for that), do:
 
@@ -38,3 +38,3 @@ ```javascript
 
-var symbol = new Symbol('My custom symbol');
+var symbol = Symbol('My custom symbol');
 var x = {};
@@ -53,3 +53,3 @@
     result = iterator.next();
-	}
+  }
 }
@@ -56,0 +56,0 @@ ```

test/index.js

 'use strict';
 
-var d = require('d/d')
+var d = require('d')
 
@@ -8,3 +8,3 @@ , defineProperty = Object.defineProperty;
 module.exports = function (T, a) {
-	var symbol = new T('test'), x = {};
+	var symbol = T('test'), x = {};
 	defineProperty(x, symbol, d('foo'));
@@ -11,0 +11,0 @@ a(x.test, undefined, "Name");

test/is-symbol.js

@@ -13,5 +13,5 @@ 'use strict';
 	if (typeof Symbol !== 'undefined') {
-		a(t(new Symbol()), true, "Native");
+		a(t(Symbol()), true, "Native");
 	}
-	a(t(new SymbolPoly()), true, "Polyfill");
+	a(t(SymbolPoly()), true, "Polyfill");
 };

test/polyfill.js

 'use strict';
 
-var d        = require('d/d')
+var d        = require('d')
   , isSymbol = require('../is-symbol')
@@ -9,3 +9,3 @@
 module.exports = function (T, a) {
-	var symbol = new T('test'), x = {};
+	var symbol = T('test'), x = {};
 	defineProperty(x, symbol, d('foo'));
@@ -12,0 +12,0 @@ a(x.test, undefined, "Name");

test/valid-symbol.js

@@ -14,7 +14,7 @@ 'use strict';
 	if (typeof Symbol !== 'undefined') {
-		symbol = new Symbol();
+		symbol = Symbol();
 		a(t(symbol), symbol, "Native");
 	}
-	symbol = new SymbolPoly();
+	symbol = SymbolPoly();
 	a(t(symbol), symbol, "Polyfill");
 };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Git dependency

Supply chain risk

Contains a dependency which resolves to a remote git URL. Dependencies fetched from git URLs are not immutable can be used to inject untrusted code or reduce the likelihood of a reproducible install.

Found 2 instances in 1 package

Improved metrics

Total package byte prevSize

9681

increased by1.76%

Number of package files

22

increased by4.76%

Lines of code

165

increased by1.85%

Number of high supply chain risk alerts

0

decreased by-100%

Dependency changes

• + Addedd@0.1.11.0.2(transitive)

• + Addedes5-ext@0.10.64(transitive)

• + Addedes6-iterator@2.0.3(transitive)

• + Addedes6-symbol@3.1.4(transitive)

• + Addedesniff@2.0.1(transitive)

• + Addedevent-emitter@0.3.5(transitive)

• + Addedext@1.7.0(transitive)

• + Addednext-tick@1.1.0(transitive)

• + Addedtype@2.7.3(transitive)

• Updatedd@~0.1.1

• Updatedes5-ext@~0.10.2