eslint-config-oceanprotocol

eslint-config-oceanprotocol

💅 🦋 Shareable ESLint config for keeping JavaScript consistent across all of Ocean Protocol's projects, built upon JavaScript Standard Style.

This cat clearly forgot to lint her JavaScript before deployment:

_{Exhibit A: cat not linting correctly}

Don't be like that cat.

Table of Contents

• Usage
  • React
  • Editor Plugins
• Rules
• Development
• npm releases
• License

---

Usage

For every project containing JavaScript, ESLint should be set up with this config.

npm install --save-dev eslint eslint-config-oceanprotocol

Then, create a new file .eslintrc in the root of your project and fill with:

{
  "extends": "oceanprotocol"
}

React

When using within a React project use this to get set up:

npm install --save-dev eslint eslint-config-oceanprotocol

And in your .eslintrc:

{
  "extends": ["oceanprotocol", "oceanprotocol/react"]
}

Editor Plugins

For maximum fun during coding, install an ESLint plugin in your favorite editor to get suggestions and autofixes as you type.

• VS Code: ESLint
• Atom: linter-eslint
• PyCharm: Installing, enabling, and configuring ESLint in PyCharm
• Sublime Text: SublimeLinter-eslint
• IntelliJ IDEA, RubyMine, WebStorm, PhpStorm, PyCharm, AppCode, Android Studio: ESLint
• Vim, NeoVim: ALE

Rules

We keep it simple and follow almost everything defined in the JavaScript Standard Style. Only deviations are:

• indentation: 4
• no space before function parenthesis
• double quotes for jsx attributes
• prefer destructuring from objects & arrays
• enforce spacing inside curly braces

Development

Again, keeping it simple with 2 files for now:

• index.js: holds all the custom JavaScript linting rules
• react.js: holds all the custom React linting rules

For local development, clone this repo and install all dependencies:

git clone [e-mail]:oceanprotocol/eslint-config-oceanprotocol.git
cd eslint-config-oceanprotocol/

npm i

Linting is setup against the actual rules within this repo so for testing new rules against every js file in this repo, you can run:

npm test

npm releases

For a new patch release, execute on the machine where you're logged into your npm account:

npm run release

In case you have 2FA setup on npm.js, pass a code as One Time Password:

npm run release --otp <yourcode>

Command is powered by release-it package, defined in the package.json.

That's what the command does without any user interaction:

• create release commit by updating version in package.json
• create tag for that release commit
• push commit & tag
• create a new release on GitHub, with change log auto-generated from commit messages
• publish to npm as a new release

If you want to create a minor or major release, use these commands:

npm run release-minor

npm run release-major

License

Copyright 2018 Ocean Protocol Ltd.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

   http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Changelog

v1.3.0

29 October 2018

• upgraded eslint-plugin-node to 8.0, removed peer deps 4859fe2