eslint-plugin-ember - npm Package Compare versions

Comparing version 5.3.0 to 5.4.0

CHANGELOG.md

 # Changelog
 
+## v5.4.0 (2018-11-09)
+
+#### :rocket: Enhancement
+* [#253](https://github.com/ember-cli/eslint-plugin-ember/pull/253) Add `avoid-using-needs` rule. ([@twokul](https://github.com/twokul))
+
+#### :bug: Bug Fix
+* [#314](https://github.com/ember-cli/eslint-plugin-ember/pull/314) Adding missing rules to index.js. ([@gmurphey](https://github.com/gmurphey))
+
+#### Committers: 2
+- Alex Navasardyan ([twokul](https://github.com/twokul))
+- Garrett Murphey ([gmurphey](https://github.com/gmurphey))
+
 ## v5.3.0 (2018-11-08)
@@ -4,0 +16,0 @@

lib/index.js

@@ -23,6 +23,9 @@ 'use strict';
     'no-jquery': require('./rules/no-jquery'),
+    'no-new-mixins': require('./rules/no-new-mixins'),
     'no-observers': require('./rules/no-observers'),
     'no-old-shims': require('./rules/no-old-shims'),
     'no-on-calls-in-components': require('./rules/no-on-calls-in-components'),
+    'no-restricted-resolver-tests': require('./rules/no-restricted-resolver-tests'),
     'no-side-effects': require('./rules/no-side-effects'),
+    'no-test-import-export': require('./rules/no-test-import-export'),
     'order-in-components': require('./rules/order-in-components'),
@@ -29,0 +32,0 @@ 'order-in-controllers': require('./rules/order-in-controllers'),

lib/recommended-rules.js

@@ -11,2 +11,3 @@ /*
   "ember/avoid-leaking-state-in-ember-objects": "error",
+  "ember/avoid-using-needs-in-controllers": "off",
   "ember/closure-actions": "error",
@@ -13,0 +14,0 @@ "ember/jquery-ember-run": "error",

lib/utils/ember.js

@@ -49,2 +49,3 @@ 'use strict';
   isReopenObject,
+  isReopenClassObject,
 };
@@ -131,2 +132,6 @@
 
+function isReopenClassObject(node) {
+  return node.callee.property && node.callee.property.name === 'reopenClass';
+}
+
 function isReopenObject(node) {
@@ -133,0 +138,0 @@ return node.callee.property && node.callee.property.name === 'reopen';

package.json

 {
   "name": "eslint-plugin-ember",
-  "version": "5.3.0",
+  "version": "5.4.0",
   "description": "Eslint plugin for Ember.js apps",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

@@ -120,2 +120,3 @@ # eslint-plugin-ember
 | :white_check_mark: | [avoid-leaking-state-in-ember-objects](./docs/rules/avoid-leaking-state-in-ember-objects.md) | Avoids state leakage |
+|  | [avoid-using-needs-in-controllers](./docs/rules/avoid-using-needs-in-controllers.md) | Avoids using needs in controllers |
 
@@ -122,0 +123,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

543122

increased by0.95%

Number of package files

123

increased by1.65%

Lines of code

9918

increased by1.35%

Number of lines in readme file

189

increased by0.53%

No dependency changes