eslint-plugin-jsx-control-statements - npm Package Compare versions

Comparing version 0.1.1 to 0.2.0

index.js

@@ -6,4 +6,6 @@ "use strict";
         "jsx-if-condition": require("./lib/rules/jsx-if-condition"),
-        "jsx-if-single-child": require("./lib/rules/jsx-if-single-child")
+        "jsx-if-single-child": require("./lib/rules/jsx-if-single-child"),
+        "jsx-use-if-tag": require("./lib/rules/jsx-use-if-tag"),
+        "jsx-for-single-child": require("./lib/rules/jsx-for-single-child")
     }
 };

lib/rules/jsx-if-condition.js

@@ -8,2 +8,4 @@ /**
 
+var utils = require("../utils");
+
 //------------------------------------------------------------------------------
@@ -15,3 +17,3 @@ // Rule Definition
     function isIfComponent(node) {
-        return node.name && node.name.type === "JSXIdentifier" && node.name.name === "If";
+        return utils.isTag("If", node);
     }
@@ -38,3 +40,3 @@
 
-            context.report(node, "If tag must have a condition attribute.");
+            context.report(node, "'If' tag must have a 'condition' attribute.");
         }
@@ -41,0 +43,0 @@ };

lib/rules/jsx-if-single-child.js

@@ -8,2 +8,4 @@ /**
 
+var utils = require("../utils");
+
 //------------------------------------------------------------------------------
@@ -15,3 +17,3 @@ // Rule Definition
     function isIfComponent(node) {
-        return node.name && node.name.type === "JSXIdentifier" && node.name.name === "If";
+        return utils.isTag("If", node);
     }
@@ -25,17 +27,2 @@
 
-    function filterChildren(children) {
-        return children.filter(function(c) {
-            if (c.type === "JSXElement") return true;
-
-            if (c.type === "Literal") return c.value.trim() !== "";
-
-            return false;
-        });
-    }
-
-    function hasSingleChild(node) {
-        var children = filterChildren(node.parent.children);
-        return children.length && children.length === 1;
-    }
-
     function hasElseCondition(node) {
@@ -50,3 +37,3 @@ var children = node.parent.children;
     function hasSingleChildrenBetween(node) {
-        var children = filterChildren(node.parent.children);
+        var children = utils.filterChildren(node.parent.children);
 
@@ -67,6 +54,6 @@ return children.length
 
-            if (!hasElseCondition(node) && !hasSingleChild(node)) {
-                context.report(node, "If tag must have single child.");
+            if (!hasElseCondition(node) && !utils.hasSingleChild(node)) {
+                context.report(node, "'If' tag must have single child.");
             } else if (hasElseCondition(node) && !hasSingleChildrenBetween(node)) {
-                context.report(node, "There must be single child between If and Else.");
+                context.report(node, "There must be single child between 'If' and 'Else'.");
             }
@@ -73,0 +60,0 @@ }

package.json

 {
   "name": "eslint-plugin-jsx-control-statements",
-  "version": "0.1.1",
+  "version": "0.2.0",
   "author": "Vivek Kumar Bansal <[e-mail]>",
@@ -5,0 +5,0 @@ "description": "jsx-control-statements specific linting rules for ESLint",

README.md

@@ -22,2 +22,3 @@ # ESLint-plugin-JSX-control-statements
 Add `plugins` section and specify ESLint-plugin-JSX-Control-Statements as a plugin.
+Also add `If` and `For` to globals.
 
@@ -28,3 +29,7 @@ ```json
     "jsx-control-statements"
-  ]
+  ],
+  "globals": {
+      "If": true,
+      "For": true
+  }
 }
@@ -49,3 +54,5 @@ ```
     "jsx-control-statements/jsx-if-condition": 1,
-    "jsx-control-statements/jsx-if-single-child": 1
+    "jsx-control-statements/jsx-if-single-child": 1,
+    "jsx-control-statements/jsx-use-if-tag": 1,
+    "jsx-control-statements/jsx-for-single-child": 1
   }
@@ -58,3 +65,5 @@ }
 * [jsx-if-condition](docs/rules/jsx-if-condition.md): Warn if `If` tag is missing `condition` attribute.
-* [jsx-if-single-child](docs/rules/jsx-if-single-child.md): Warn if `If` and `Else` tags must have single children.
+* [jsx-if-single-child](docs/rules/jsx-if-single-child.md): Warn if `If` and `Else` tags does not have single child.
+* [jsx-use-if-tag](docs/rules/jsx-use-if-tag.md): Use `If` tag instead of ternary operator.
+* [jsx-for-single-child](docs/rules/jsx-for-single-child.md): Warn if `For` tags does not have single child.
 
@@ -61,0 +70,0 @@ ## Credits

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

10409

increased by39.85%

Number of package files

9

increased by80%

Lines of code

155

increased by63.16%

Number of lines in readme file

88

increased by11.39%

No dependency changes