eslint-plugin-jsx-control-statements - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

CHANGELOG.md

@@ -12,2 +12,10 @@ # Changelog
 
+## v1.0.1
+
+### Changed
+- Internal: Refactor code.
+
+### Fixed
+- Fix build on node v0.x and iojs.
+
 ## v1.0.0
@@ -14,0 +22,0 @@

lib/rules/jsx-for-require-each.js

@@ -16,11 +16,4 @@ /**
 module.exports = function(context) {
-    function isForComponent(node) {
-        return utils.isTag("For", node);
-    }
-
     function eachAttr(decl) {
-        if (decl.type === 'JSXSpreadAttribute') {
-            return false;
-        }
-        return (decl.name.name === 'each');
+        return utils.isAttr(decl, 'each');
     }
@@ -37,8 +30,9 @@
 
-            if (!isForComponent(node)) return;
+            if (!utils.isForComponent(node)) return;
 
             if (attr) {
-                let scope = context.getScope();
-                scope.through = scope.through.filter((v) => attr.value.value !== v.identifier.name);
-                context.markVariableAsUsed(attr.value.value);
+                var scope = context.getScope();
+                scope.through = scope.through.filter(function(v) {
+                    return attr.value.value !== v.identifier.name;
+                });
                 return;
@@ -45,0 +39,0 @@ }

lib/rules/jsx-for-require-index.js

@@ -16,11 +16,4 @@ /**
 module.exports = function(context) {
-    function isForComponent(node) {
-        return utils.isTag("For", node);
-    }
-
     function indexAttr(decl) {
-        if (decl.type === 'JSXSpreadAttribute') {
-            return false;
-        }
-        return (decl.name.name === 'index');
+        return utils.isAttr(decl, 'index');
     }
@@ -37,8 +30,9 @@
 
-            if (!isForComponent(node)) return;
+            if (!utils.isForComponent(node)) return;
 
             if (attr) {
-                let scope = context.getScope();
-                scope.through = scope.through.filter((v) => attr.value.value !== v.identifier.name);
-                context.markVariableAsUsed(attr.value.value);
+                var scope = context.getScope();
+                scope.through = scope.through.filter(function(v) {
+                    return attr.value.value !== v.identifier.name;
+                });
                 return;
@@ -45,0 +39,0 @@ }

lib/rules/jsx-for-require-of.js

@@ -15,11 +15,4 @@ /**
 module.exports = function(context) {
-    function isForComponent(node) {
-        return utils.isTag("For", node);
-    }
-
     function hasOfAttr(decl) {
-        if (decl.type === 'JSXSpreadAttribute') {
-            return false;
-        }
-        return (decl.name.name === 'of');
+        return utils.isAttr(decl, 'of');
     }
@@ -35,3 +28,3 @@
 
-            if (!isForComponent(node) || attributes.some(hasOfAttr)) {
+            if (!utils.isForComponent(node) || attributes.some(hasOfAttr)) {
                 return;
@@ -38,0 +31,0 @@ }

lib/rules/jsx-for-single-child.js

@@ -15,6 +15,2 @@ /**
 module.exports = function(context) {
-    function isForComponent(node) {
-        return utils.isTag("For", node);
-    }
-
     //--------------------------------------------------------------------------
@@ -26,3 +22,3 @@ // Public
         JSXOpeningElement: function(node) {
-            if (!isForComponent(node)) return node;
+            if (!utils.isForComponent(node)) return node;
 
@@ -29,0 +25,0 @@ if (!utils.hasSingleChild(node)) {

lib/rules/jsx-if-require-condition.js

@@ -15,11 +15,4 @@ /**
 module.exports = function(context) {
-    function isIfComponent(node) {
-        return utils.isTag("If", node);
-    }
-
     function hasConditionAttr(decl) {
-        if (decl.type === 'JSXSpreadAttribute') {
-            return false;
-        }
-        return (decl.name.name === 'condition');
+        return utils.isAttr(decl, 'condition');
     }
@@ -35,3 +28,3 @@
 
-            if (!isIfComponent(node) || attributes.some(hasConditionAttr)) {
+            if (!utils.isIfComponent(node) || attributes.some(hasConditionAttr)) {
                 return;
@@ -38,0 +31,0 @@ }

lib/rules/jsx-if-single-child.js

@@ -16,7 +16,2 @@ /**
 module.exports = function(context) {
-    function isIfComponent(node) {
-        return utils.isTag("If", node);
-    }
-
-
     function isElseComponent(child) {
@@ -44,3 +39,3 @@ return child.type === 'JSXElement' && child.openingElement.name.name === 'Else';
         JSXOpeningElement: function(node) {
-            if (!isIfComponent(node)) return node;
+            if (!utils.isIfComponent(node)) return node;
 
@@ -47,0 +42,0 @@ var children = utils.filterChildren(node.parent.children),

lib/utils.js

@@ -18,2 +18,9 @@ "use strict";
 
+function isAttr(decl, name) {
+    if (decl.type === 'JSXSpreadAttribute') {
+        return false;
+    }
+    return (decl.name.name === name);
+}
+
 function isTag(tag, node) {
@@ -23,4 +30,15 @@ return node.name && node.name.type === "JSXIdentifier" && node.name.name === tag;
 
+function isForComponent(node) {
+    return isTag("For", node);
+}
+
+function isIfComponent(node) {
+    return isTag("If", node);
+}
+
 exports.hasSingleChild = hasSingleChild;
 exports.filterChildren = filterChildren;
 exports.isTag = isTag;
+exports.isAttr = isAttr;
+exports.isForComponent = isForComponent;
+exports.isIfComponent = isIfComponent;

package.json

 {
   "name": "eslint-plugin-jsx-control-statements",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "author": "Vivek Kumar Bansal <[e-mail]>",
@@ -5,0 +5,0 @@ "description": "jsx-control-statements specific linting rules for ESLint",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

15250

decreased by-2.27%

Lines of code

260

decreased by-4.76%

No dependency changes