eslint-plugin-more - npm Package Compare versions

Comparing version 1.0.3 to 1.0.4

lib/rules/prefer-includes.js

@@ -10,10 +10,17 @@
 
+            const isIndexOfCall = left.callee
+                && (left.callee.type === 'MemberExpression')
+                && (left.callee.property.name === 'indexOf');
+
+            if (!isIndexOfCall) {
+                return;
+            }
+
             const compareWithMinusOne = right.operator === '-' && right.argument && right.argument.value === 1;
             const lessThanZero = operator === '<' && right.value === 0;
             const moreOrEqualThanZero = operator === '>=' && right.value === 0;
-            const isIndexOfEqualToMinusOne = left
-                && left.callee
-                && (left.callee.property.name === 'indexOf')
-                && (compareWithMinusOne || lessThanZero || moreOrEqualThanZero);
 
+            const isIndexOfEqualToMinusOne = compareWithMinusOne
+                || lessThanZero
+                || moreOrEqualThanZero;
 
@@ -23,3 +30,3 @@ if (isIndexOfEqualToMinusOne) {
                     node,
-                    message: 'Do not use indexOf, instead use includes '
+                    message: 'Do not use indexOf, instead use includes'
                 });
@@ -26,0 +33,0 @@ }

package.json

 {
   "name": "eslint-plugin-more",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "license": "MIT",
@@ -5,0 +5,0 @@ "keywords": [

tests/lib/rules/no-filter-instead-of-find.js

@@ -0,3 +1,3 @@
+const { RuleTester } = require('eslint/lib/rule-tester')
 const rule = require('../../../lib/rules/no-filter-instead-of-find');
-const RuleTester = require('eslint/lib/testers/rule-tester');
 
@@ -4,0 +4,0 @@ const ruleTester = new RuleTester();

No alert changes

Improved metrics

Total package byte prevSize

30009

increased by4.68%

Number of package files

32

increased by3.23%

Lines of code

488

increased by8.93%

No dependency changes