eslint-plugin-rxjs-angular - npm Package Compare versions

Comparing version 1.0.4 to 1.0.5

CHANGELOG.md

@@ -0,1 +1,8 @@
+<a name="1.0.5"></a>
+## [1.0.5](https://github.com/cartant/eslint-plugin-rxjs-angular/compare/v1.0.4...v1.0.5) (2021-03-20)
+
+## Fixes
+
+* Enable TypeScript `strict` option and fix related problems. ([109d2f1](https://github.com/cartant/eslint-plugin-rxjs-angular/commit/109d2f1))
+
 <a name="1.0.4"></a>
@@ -2,0 +9,0 @@ ## [1.0.4](https://github.com/cartant/eslint-plugin-rxjs-angular/compare/v1.0.3...v1.0.4) (2021-01-11)

dist/index.js

@@ -0,1 +1,2 @@
+"use strict";
 module.exports.rules = require("requireindex")(`${__dirname}/rules`);

dist/rules/prefer-composition.js

@@ -41,2 +41,3 @@ "use strict";
         function checkEntry(record) {
+            var _a;
             const { classDeclaration, classProperties, ngOnDestroyDefinition, subscribeCallExpressions, subscriptions, unsubscribeCallExpressions, } = record;
@@ -65,3 +66,3 @@ if (subscribeCallExpressions.length === 0) {
                     messageId: "notImplemented",
-                    node: classDeclaration.id,
+                    node: (_a = classDeclaration.id) !== null && _a !== void 0 ? _a : classDeclaration,
                 });
@@ -71,2 +72,3 @@ return;
             subscriptions.forEach((subscription) => {
+                var _a;
                 const classProperty = classProperties.find((classProperty) => classProperty.key.name === subscription);
@@ -77,3 +79,3 @@ if (!classProperty) {
                         messageId: "notDeclared",
-                        node: classDeclaration.id,
+                        node: (_a = classDeclaration.id) !== null && _a !== void 0 ? _a : classDeclaration,
                     });
@@ -138,2 +140,5 @@ return;
             const parent = eslint_etc_1.getParent(callExpression);
+            if (!parent) {
+                return false;
+            }
             if (eslint_etc_1.isCallExpression(parent)) {
@@ -140,0 +145,0 @@ const addCallExpression = addCallExpressions.find((callExpression) => callExpression === parent);

dist/rules/prefer-takeuntil.js

@@ -66,2 +66,3 @@ "use strict";
         function checkNgOnDestroy(entry) {
+            var _a;
             const { classDeclaration, completeCallExpressions, nextCallExpressions, ngOnDestroyDefinition, subscribeCallExpressionsToNames, } = entry;
@@ -74,3 +75,3 @@ if (subscribeCallExpressionsToNames.size === 0) {
                     messageId: "noDestroy",
-                    node: classDeclaration.id,
+                    node: (_a = classDeclaration.id) !== null && _a !== void 0 ? _a : classDeclaration,
                 });
@@ -83,2 +84,3 @@ return;
             names.forEach((name) => {
+                var _a;
                 const check = {
@@ -93,3 +95,3 @@ descriptors: [],
                         messageId: "notDeclared",
-                        node: classDeclaration.id,
+                        node: (_a = classDeclaration.id) !== null && _a !== void 0 ? _a : classDeclaration,
                     });
@@ -96,0 +98,0 @@ }

package.json

@@ -30,3 +30,3 @@ {
     "ts-node": "^9.0.0",
-    "typescript": "~4.1.2"
+    "typescript": "~4.2.2"
   },
@@ -84,3 +84,3 @@ "engines": {
   },
-  "version": "1.0.4"
+  "version": "1.0.5"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

35776

increased by1.96%

Lines of code

545

increased by1.49%

No dependency changes