eslint-plugin-sonarjs - npm Package Compare versions

Comparing version 0.24.0 to 0.25.0

lib/index.d.ts

@@ -1,2 +0,2 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const sonarjsRuleModules: {
@@ -3,0 +3,0 @@ [key: string]: any;

lib/rules/cognitive-complexity.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, (number | 'metric' | 'sonar-runtime')[]>;
 export = rule;

lib/rules/elseif-without-else.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/max-switch-cases.d.ts

@@ -1,4 +0,4 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare type Options = [number];
 declare const rule: TSESLint.RuleModule<string, Options>;
 export = rule;

lib/rules/no-all-duplicated-branches.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-collapsible-if.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-collection-size-mischeck.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-duplicate-string.d.ts

@@ -1,2 +0,2 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare type Options = [{
@@ -3,0 +3,0 @@ threshold?: number;

lib/rules/no-duplicated-branches.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-element-overwrite.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-empty-collection.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-extra-arguments.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-gratuitous-expressions.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-identical-conditions.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-identical-expressions.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-identical-functions.d.ts

@@ -1,4 +0,4 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare type Options = (number | 'sonar-runtime')[];
 declare const rule: TSESLint.RuleModule<string, Options>;
 export = rule;

lib/rules/no-ignored-return.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-inverted-boolean-check.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-nested-switch.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-nested-template-literals.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-one-iteration-loop.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-one-iteration-loop.js

@@ -37,3 +37,3 @@ "use strict";
     },
-    // @ts-ignore The typings of @typescript-eslint/experimental-utils does not contain the 'onX' methods.
+    // @ts-ignore The typings of @typescript-eslint/utils does not contain the 'onX' methods.
     create(context) {
@@ -40,0 +40,0 @@ const loopingNodes = new Set();

lib/rules/no-redundant-boolean.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-redundant-jump.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-same-line-conditional.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-small-switch.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-unused-collection.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-unused-collection.js

@@ -156,4 +156,3 @@ "use strict";
 function isMemberExpressionReference(lhs, ref) {
-    return (lhs.type === 'MemberExpression' &&
-        (isReferenceTo(ref, lhs.object) || isMemberExpressionReference(lhs.object, ref)));
+    return lhs.type === 'MemberExpression' && isReferenceTo(ref, lhs.object);
 }
@@ -160,0 +159,0 @@ function isIdentifier(node, ...values) {

lib/rules/no-use-of-empty-return-value.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/no-use-of-empty-return-value.js

@@ -22,4 +22,10 @@ "use strict";
 // https://sonarsource.github.io/rspec/#/rspec/S3699
+const utils_1 = require("@typescript-eslint/utils");
 const nodes_1 = require("../utils/nodes");
 const docs_url_1 = require("../utils/docs-url");
+const EMPTY_RETURN_VALUE_KEYWORDS = new Set([
+    utils_1.TSESTree.AST_NODE_TYPES.TSVoidKeyword,
+    utils_1.TSESTree.AST_NODE_TYPES.TSNeverKeyword,
+    utils_1.TSESTree.AST_NODE_TYPES.TSUndefinedKeyword,
+]);
 function isReturnValueUsed(callExpr) {
@@ -30,17 +36,17 @@ const { parent } = callExpr;
     }
-    if (parent.type === 'LogicalExpression') {
+    if (parent.type === utils_1.TSESTree.AST_NODE_TYPES.LogicalExpression) {
         return parent.left === callExpr;
     }
-    if (parent.type === 'SequenceExpression') {
+    if (parent.type === utils_1.TSESTree.AST_NODE_TYPES.SequenceExpression) {
         return parent.expressions[parent.expressions.length - 1] === callExpr;
     }
-    if (parent.type === 'ConditionalExpression') {
+    if (parent.type === utils_1.TSESTree.AST_NODE_TYPES.ConditionalExpression) {
         return parent.test === callExpr;
     }
-    return (parent.type !== 'ExpressionStatement' &&
-        parent.type !== 'ArrowFunctionExpression' &&
-        parent.type !== 'UnaryExpression' &&
-        parent.type !== 'AwaitExpression' &&
-        parent.type !== 'ReturnStatement' &&
-        parent.type !== 'ThrowStatement');
+    return (parent.type !== utils_1.TSESTree.AST_NODE_TYPES.ExpressionStatement &&
+        parent.type !== utils_1.TSESTree.AST_NODE_TYPES.ArrowFunctionExpression &&
+        parent.type !== utils_1.TSESTree.AST_NODE_TYPES.UnaryExpression &&
+        parent.type !== utils_1.TSESTree.AST_NODE_TYPES.AwaitExpression &&
+        parent.type !== utils_1.TSESTree.AST_NODE_TYPES.ReturnStatement &&
+        parent.type !== utils_1.TSESTree.AST_NODE_TYPES.ThrowStatement);
 }
@@ -91,5 +97,5 @@ const rule = {
                     const ancestors = [...context.getAncestors()].reverse();
-                    const functionNode = ancestors.find(node => node.type === 'FunctionExpression' ||
-                        node.type === 'FunctionDeclaration' ||
-                        node.type === 'ArrowFunctionExpression');
+                    const functionNode = ancestors.find(node => node.type === utils_1.TSESTree.AST_NODE_TYPES.FunctionExpression ||
+                        node.type === utils_1.TSESTree.AST_NODE_TYPES.FunctionDeclaration ||
+                        node.type === utils_1.TSESTree.AST_NODE_TYPES.ArrowFunctionExpression);
                     functionsWithReturnValue.add(functionNode);
@@ -112,2 +118,9 @@ }
             },
+            TSDeclareFunction(node) {
+                const declareFunction = node;
+                if (declareFunction.returnType?.typeAnnotation.type &&
+                    !EMPTY_RETURN_VALUE_KEYWORDS.has(declareFunction.returnType?.typeAnnotation.type)) {
+                    functionsWithReturnValue.add(declareFunction);
+                }
+            },
             'Program:exit'() {
@@ -114,0 +127,0 @@ callExpressionsToCheck.forEach((functionDeclaration, callee) => {

lib/rules/no-useless-catch.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/non-existent-operator.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/prefer-immediate-return.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/prefer-object-literal.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/prefer-single-boolean-return.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/rules/prefer-while.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 declare const rule: TSESLint.RuleModule<string, string[]>;
 export = rule;

lib/utils/conditions.d.ts

@@ -1,2 +0,2 @@
-import type { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 /** Returns a list of statements corresponding to a `if - else if - else` chain */
@@ -3,0 +3,0 @@ export declare function collectIfBranches(node: TSESTree.IfStatement): {

lib/utils/equivalence.d.ts

@@ -1,2 +0,2 @@
-import type { TSESTree, TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESTree, TSESLint } from '@typescript-eslint/utils';
 /**
@@ -3,0 +3,0 @@ * Equivalence is implemented by comparing node types and their tokens.

lib/utils/jsx.d.ts

@@ -1,2 +0,2 @@
-import type { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 export declare function getJsxShortCircuitNodes(logicalExpression: TSESTree.LogicalExpression): TSESTree.LogicalExpression[] | null;

lib/utils/locations.d.ts

@@ -1,2 +0,2 @@
-import type { TSESTree, TSESLint } from '@typescript-eslint/experimental-utils';
+import type { TSESTree, TSESLint } from '@typescript-eslint/utils';
 declare type Writeable<T> = {
@@ -3,0 +3,0 @@ -readonly [P in keyof T]: T[P];

lib/utils/nodes.d.ts

@@ -1,2 +0,2 @@
-import type { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 export declare function isArrowFunctionExpression(node: TSESTree.Node | undefined): node is TSESTree.ArrowFunctionExpression;
@@ -3,0 +3,0 @@ export declare function isAssignmentExpression(node: TSESTree.Node | undefined): node is TSESTree.AssignmentExpression;

lib/utils/parser-services.d.ts

@@ -1,2 +0,2 @@
-import type { ParserServices } from '@typescript-eslint/experimental-utils';
+import type { ParserServices } from '@typescript-eslint/utils';
 export declare type RequiredParserServices = {
@@ -3,0 +3,0 @@ [k in keyof ParserServices]: Exclude<ParserServices[k], undefined>;

lib/utils/utils-ast.d.ts

@@ -1,3 +0,3 @@
-import type { TSESLint, TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
 export declare function isIdentifier(node: TSESTree.Node, ...values: string[]): node is TSESTree.Identifier;
 export declare function isReferenceTo(ref: TSESLint.Scope.Reference, node: TSESTree.Node): boolean;

lib/utils/utils-parent.d.ts

@@ -1,3 +0,3 @@
-import type { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 export declare function findFirstMatchingAncestor(node: TSESTree.Node, predicate: (node: TSESTree.Node) => boolean): TSESTree.Node | undefined;
 export declare function ancestorsChain(node: TSESTree.Node, boundaryTypes: Set<string>): TSESTree.Node[];

lib/utils/utils-type.d.ts

@@ -1,3 +0,3 @@
-import type { TSESTree } from '@typescript-eslint/experimental-utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 import { RequiredParserServices } from './parser-services';
 export declare function getTypeFromTreeNode(node: TSESTree.Node, services: RequiredParserServices): import("typescript").Type;

package.json

 {
   "name": "eslint-plugin-sonarjs",
-  "version": "0.24.0",
+  "version": "0.25.0",
   "description": "SonarJS rules for ESLint",
@@ -47,4 +47,4 @@ "main": "lib/index.js",
     "@types/node": "14.14.31",
-    "@typescript-eslint/experimental-utils": "5.30.7",
     "@typescript-eslint/parser": "5.30.7",
+    "@typescript-eslint/utils": "5.30.7",
     "eslint": "8.47.0",
@@ -51,0 +51,0 @@ "eslint-config-prettier": "8.5.0",

No alert changes

Improved metrics

Total package byte prevSize

315135

increased by0.3%

Lines of code

4549

increased by0.26%

No dependency changes