express-swagger-generator - npm Package Compare versions

Comparing version 1.1.5 to 1.1.6

lib/swagger.js

@@ -90,11 +90,11 @@ /**
         if (tags[i]['title'] == 'returns' || tags[i]['title'] == 'return') {
-            let description = tags[i]['description'].split("-")
-            rets[description[0]] = {
-                description: description[1],
-                headers: headers[description[0].trim()]
+            let description = tags[i]['description'].split("-"), key = description[0].trim()
+            rets[key] = {
+                description: description[1].trim(),
+                headers: headers[key]
             };
             const type = parseType(tags[i].type);
             if (type) {
-                // rets[description[0]].type = type;
-                rets[description[0]].schema = parseSchema(tags[i].type)
+                // rets[key].type = type;
+                rets[key].schema = parseSchema(tags[i].type)
             }
@@ -196,8 +196,8 @@ }
             }
-
-            if (!headers[code[0]]) {
-                headers[code[0]] = {}
+            let code0 = code[0].trim();
+            if (!headers[code0]) {
+                headers[code0] = {}
             }
 
-            headers[code[0].trim()][code2name[1]] = {
+            headers[code0][code2name[1]] = {
                 type: type[0],
@@ -232,18 +232,23 @@ description: description[1]
                     parameters[route.uri][route.method]['description'] = desc
-                    parameters[route.uri][route.method]['tags'] = [tag[0]]
+                    parameters[route.uri][route.method]['tags'] = [tag[0].trim()]
                     tags.push({
-                        name: tag[0],
-                        description: tag[1]
+                        name: tag[0].trim(),
+                        description: tag[1].trim()
                     })
                 }
                 if (title == 'param') {
-                    let field = parseField(comments[i][j]['name'])
-                    params.push({
-                        name: field.name,
-                        in: field.parameter_type,
-                        description: comments[i][j]['description'],
-                        required: field.required,
-                        type: parseType(comments[i][j]['type']),
-                        schema: parseSchema(comments[i][j]['type'])
-                    })
+                    let field = parseField(comments[i][j]['name']),
+                        properties = {
+                            name: field.name,
+                            in: field.parameter_type,
+                            description: comments[i][j]['description'],
+                            required: field.required
+                        },
+                        schema = parseSchema(comments[i][j]['type'])
+                    // we only want a type if there is no referenced schema
+                    if (!schema)
+                        properties.type = parseType(comments[i][j]['type'])
+                    else
+                        properties.schema = schema
+                    params.push(properties)
                 }
@@ -361,2 +366,2 @@
     }
-};
+};

package.json

 {
   "name": "express-swagger-generator",
-  "version": "1.1.5",
+  "version": "1.1.6",
   "description": "Generates swagger doc & ui based on express existing routes.",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Improved metrics

Total package byte prevSize

23412

increased by1.32%

Lines of code

563

increased by1.26%

No dependency changes