fabric - npm Package Compare versions

Comparing version 1.4.7 to 1.4.9

.jscs.json

@@ -10,4 +10,2 @@ {
     "requireCommaBeforeLineBreak": true,
-    "requireRightStickedOperators": ["!"],
-    "requireLeftStickedOperators": [","],
     "requireCamelCaseOrUpperCaseIdentifiers": true,
@@ -37,3 +35,9 @@ "requireKeywordsOnNewLine": ["else"],
 
-    "safeContextKeyword": "_this"
+    "safeContextKeyword": "_this",
+
+    "validateJSDoc": {
+      "checkParamNames": true,
+      "checkRedundantParams": true,
+      "requireParamTypes": true
+    }
 }

bower.json

 {
   "name": "fabric.js",
-  "version": "1.4.7",
+  "version": "1.4.9",
   "homepage": "http://fabricjs.com",
@@ -5,0 +5,0 @@ "authors": [

package.json

@@ -5,3 +5,3 @@ {
   "homepage": "http://fabricjs.com/",
-  "version": "1.4.7",
+  "version": "1.4.9",
   "author": "Juriy Zaytsev <[e-mail]>",
@@ -18,2 +18,7 @@ "keywords": [
   ],
+  "browser" : {
+    "canvas" : false,
+    "jsdom":   false,
+    "xmldom":  false
+  },
   "repository": {
@@ -33,3 +38,3 @@ "type": "git",
     "canvas": "1.1.x",
-    "jsdom": "0.10.x",
+    "jsdom": "0.11.x",
     "xmldom": "0.1.x"
@@ -40,6 +45,6 @@ },
     "uglify-js": "2.4.x",
-    "jscs": "1.4.x",
+    "jscs": "1.5.x",
     "jshint": "2.5.x",
-    "qunit": "0.6.x",
-    "istanbul": "0.2.6"
+    "qunit": "0.7.x",
+    "istanbul": "0.3.x"
   },
@@ -46,0 +51,0 @@ "engines": {

test/unit/canvas_static.js

@@ -135,3 +135,4 @@ (function() {
 
-  var canvas = this.canvas = fabric.isLikelyNode ? fabric.createCanvasForNode() : new fabric.StaticCanvas(el);
+  var canvas = this.canvas = fabric.isLikelyNode ? fabric.createCanvasForNode() : new fabric.StaticCanvas(el),
+      canvas2 = this.canvas2 = fabric.isLikelyNode ? fabric.createCanvasForNode() : new fabric.StaticCanvas(el);
   fabric.Canvas = Canvas;
@@ -157,3 +158,14 @@
     ok('backgroundColor' in canvas);
+    ok('overlayColor' in canvas);
+    ok('backgroundImage' in canvas);
+    ok('overlayImage' in canvas);
+    ok('clipTo' in canvas);
+
     equal(canvas.includeDefaultValues, true);
+    equal(canvas.stateful, true);
+    equal(canvas.renderOnAddRemove, true);
+    equal(canvas.controlsAboveOverlay, false);
+    equal(canvas.imageSmoothingEnabled, true);
+
+    notStrictEqual(canvas.viewportTransform, canvas2.viewportTransform);
   });
@@ -160,0 +172,0 @@

test/unit/object.js

@@ -1078,2 +1078,7 @@ (function(){
     equal(object.shadow.offsetY, 15);
+    
+    equal(object.setShadow(null), object, 'should be chainable');
+    ok(!(object.shadow instanceof fabric.Shadow));
+    equal(object.shadow, null);
+    
   });
@@ -1080,0 +1085,0 @@

test/unit/parser.js

@@ -129,6 +129,7 @@ (function(){
 
+    // TODO: looks like this still fails with % and em values
     var expectedObject = {
       'left':   10,
       'top':    22.3,
-      'width':  103.45,
+      'width':  137.93333333333334,
       'height': 20
@@ -200,3 +201,3 @@ };
     var element = fabric.document.createElement('polygon');
-    element.setAttribute('points', '10,12           20,22,  -0.52,0.001 2.3e2,2.3e-2, 10,-1     ');
+    element.setAttribute('points', '10,  12           20 ,22,  -0.52,0.001 2.3e2,2.3e-2, 10,-1     ');
 
@@ -203,0 +204,0 @@ var actualPoints = fabric.parsePointsAttribute(element.getAttribute('points'));

test/unit/text.js

@@ -9,2 +9,4 @@ (function() {
 
+  var CHAR_WIDTH = 20;
+
   var REFERENCE_TEXT_OBJECT = {
@@ -16,3 +18,3 @@ 'type':                'text',
     'top':                 0,
-    'width':               20,
+    'width':               CHAR_WIDTH,
     'height':              52,
@@ -35,2 +37,3 @@ 'fill':                'rgb(0,0,0)',
     'clipTo':              null,
+    'backgroundColor':     '',
     'text':                'x',
@@ -45,3 +48,2 @@ 'fontSize':            40,
     'path':                null,
-    'backgroundColor':     '',
     'textBackgroundColor': '',
@@ -155,3 +157,3 @@ 'useNative':           true
     // temp workaround for text objects not obtaining width under node
-    // text.width = 20;
+    // text.width = CHAR_WIDTH;
 
@@ -164,3 +166,3 @@ var expectedObject = fabric.util.object.extend(fabric.util.object.clone(REFERENCE_TEXT_OBJECT), {
       fontSize: 16,
-      originX: 'center'
+      originX: 'left'
     });
@@ -191,6 +193,7 @@
     elTextWithAttrs.setAttribute('text-decoration', 'underline');
+    elTextWithAttrs.setAttribute('text-anchor', 'middle');
 
     var textWithAttrs = fabric.Text.fromElement(elTextWithAttrs);
     // temp workaround for text objects not obtaining width under node
-    textWithAttrs.width = 20;
+    textWithAttrs.width = CHAR_WIDTH;
 
@@ -203,3 +206,3 @@ ok(textWithAttrs instanceof fabric.Text);
       top:              -59.95,
-      width:            20,
+      width:            CHAR_WIDTH,
       height:           159.9,
@@ -231,6 +234,6 @@ fill:             'rgb(255,255,255)',
     var text = new fabric.Text('x');
-    equal(text.width, 20);
+    equal(text.width, CHAR_WIDTH);
 
     text.setText('xx');
-    equal(text.width, 40);
+    equal(text.width, CHAR_WIDTH * 2);
   });
@@ -253,3 +256,3 @@
     // temp workaround for text objects not obtaining width under node
-    text.width = 20;
+    text.width = CHAR_WIDTH;
 
@@ -260,3 +263,3 @@ equal(text.toSVG(), TEXT_SVG);
     // temp workaround for text objects not obtaining width under node
-    text.width = 20;
+    text.width = CHAR_WIDTH;
 
@@ -263,0 +266,0 @@ equal(text.toSVG(), TEXT_SVG.replace('font-family="Times New Roman"', 'font-family="\'Arial Black\', Arial"'));

test/unit/util.js

@@ -485,3 +485,3 @@ (function() {
     setTimeout(function() {
-      ok(group1 instanceof fabric.Polygon);
+      ok(group1 instanceof fabric.PathGroup);
       start();
@@ -488,0 +488,0 @@ }, 2000);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

10298736

increased by0.96%

Lines of code

52575

increased by1.54%

Dependency changes

• + Addedjsdom@0.11.1(transitive)

• - Removedjsdom@0.10.6(transitive)

• Updatedjsdom@0.11.x