firescript-linter - npm Package Compare versions

Comparing version 0.7.0 to 0.8.0

package.json

 {
   "name": "firescript-linter",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "description": "Linter for Firescript",
@@ -5,0 +5,0 @@ "main": "app.js",

src/nodes/MemberExpression.js

 const LinterNode = require('../LinterNode').LinterNode
+const { VariableNotDeclared } = require('../exceptions/VariableNotDeclared')
 
 class MemberExpression extends LinterNode {
   lint (ast) {
-    this.lintNode(ast.object)
+    const obj = this.getObjectNode(ast.object)
+    if (obj.type === 'Identifier') {
+      if (!this.isScopeVar(obj.name)) {
+        this.lintException(new VariableNotDeclared(obj, obj.name))
+      }
+    } else {
+      this.debug('TODO: lint MemberExpression.object of type', obj.type)
+    }
+
     this.lintNode(ast.property)
-    this.debug('TODO: check whether MemberExpression root is defined')
   }
+
+  getObjectNode (ast) {
+    return ast.type === 'MemberExpression' ? this.getObjectNode(ast.object) : ast
+  }
 }
 
 module.exports.MemberExpression = MemberExpression

src/nodes/Property.js

@@ -8,3 +8,2 @@ const { LinterNode } = require('../LinterNode')
     if (ast.value.type === 'Identifier') {
-      // Right is a variable
       if (!this.isScopeVar(ast.value.name)) {
@@ -11,0 +10,0 @@ this.lintException(new VariableNotDeclared(ast.value, ast.value.name))

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

62515

increased by1.74%

Number of package files

157

increased by1.29%

Lines of code

1854

increased by1.59%

No dependency changes