flurry-api - npm Package Compare versions

Comparing version 0.0.3 to 0.0.4

lib/flurry.js

 var request = require('request'),
+  Promise = require('bluebird'),
   util = require('./util'),
@@ -26,18 +27,22 @@ Metric = require('./metric');
   Flurry.prototype[i] = function(callback){
-    request.get('http://api.flurry.com/appInfo/' + i, {
-      headers: {
-        'Content-Type': 'application/json'
-      },
-      qs: {
-        apiAccessCode: this.options.apiAccess,
-        apiKey: this.options.apiKey
-      }
-    }, function(err, res, body){
-      if (err) return callback(err);
+    if (typeof callback !== 'function') callback = function(){};
 
-      var data = JSON.parse(body);
-      if (res.statusCode !== 200) return callback(util.formatError(data));
+    return new Promise(function(resolve, reject){
+      request.get('http://api.flurry.com/appInfo/' + i, {
+        headers: {
+          'Content-Type': 'application/json'
+        },
+        qs: {
+          apiAccessCode: this.options.apiAccess,
+          apiKey: this.options.apiKey
+        }
+      }, function(err, res, body){
+        if (err) return reject(err);
 
-      callback(null, data);
-    });
+        var data = JSON.parse(body);
+        if (res.statusCode !== 200) return reject(util.formatError(data));
+
+        resolve(data);
+      });
+    }).nodeify(callback);
   };
@@ -44,0 +49,0 @@ });

lib/metric.js

 var request = require('request'),
+  Promise = require('bluebird'),
   util = require('./util');
@@ -42,15 +43,19 @@
 Metric.prototype.exec = function(callback){
-  request.get(this.base, {
-    headers: {
-      'Content-Type': 'application/json'
-    },
-    qs: this.params
-  }, function(err, res, body){
-    if (err) return callback(err);
+  if (typeof callback !== 'function') callback = function(){};
 
-    var data = JSON.parse(body);
-    if (res.statusCode !== 200) return callback(util.formatError(data));
+  return new Promise(function(resolve, reject){
+    request.get(this.base, {
+      headers: {
+        'Content-Type': 'application/json'
+      },
+      qs: this.params
+    }, function(err, res, body){
+      if (err) return reject(err);
 
-    callback(null, data);
-  });
+      var data = JSON.parse(body);
+      if (res.statusCode !== 200) return reject(util.formatError(data));
+
+      resolve(data);
+    });
+  }).nodeify(callback);
 };

package.json

 {
   "name": "flurry-api",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "Flurry API for Node.js",
@@ -29,4 +29,5 @@ "main": "lib/flurry",
   "dependencies": {
+    "bluebird": "^2.2.2",
     "request": "^2.37.0"
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8314

increased by5.03%

Lines of code

114

increased by7.55%

Worsened metrics

Dependency count

2

increased by100%

Dependency changes

• + Addedbluebird@^2.2.2

• + Addedbluebird@2.11.0(transitive)