fnflow - npm Package Compare versions

Comparing version 0.1.11 to 0.1.12

lib/fnFlow.js

 var async = require('async');
 var us = require('underscore');
 var FlowTaskError = require('./flowTaskError');
-var FlowTaskArgumentNullError = require('./flowTaskArgumentNullError');
+var FlowTaskArgumentNullError = require('./FlowTaskArgumentNullError');
 
@@ -140,5 +140,6 @@ module.exports = {
           var result = results;
-          arg.forEach(function(arg){
-            result = result[arg];
-          });
+          for(var j in arg) {
+            if(result === undefined) return cb(new FlowTaskArgumentNullError(taskName, arg[j-1], arg[j]));
+            result = result[arg[j]];
+          }
           fnArgs[i] = result;
@@ -145,0 +146,0 @@ } else fnArgs[i] = results[arg];

package.json

@@ -6,3 +6,3 @@ {
   "author": "David Fenster <[e-mail]>",
-  "version": "0.1.11",
+  "version": "0.1.12",
   "repository": {
@@ -9,0 +9,0 @@ "type": "git",

tests/001-flow.js

@@ -349,3 +349,18 @@ var util = require('util');
 
+module.exports["instance task execution with undefined dot notation function"] = function(test){
+  flow({
+    authorName: 'Dan Brown',
+    genreName: 'Superfiction'
+  }, {
+    getAuthor: [Author.getByName, 'authorName'],
+    getGenre: [Genre.getByName, 'genreName'],
+    getBooks: ['getGenre.findBooksByAuthor', 'getAuthor']
+  }, function(err, results){
+    test.ok(err);
+    test.equals(err.message, 'Flow error in \'getBooks\': Cannot call function \'findBooksByAuthor\' on null/undefined \'getGenre\'')
+    test.done();
+  });  
+}
 
+
 module.exports["multiple asyncronus tasks with prerequisite task execution"] = function(test){
@@ -352,0 +367,0 @@ flow( [

No alert changes

Improved metrics

Total package byte prevSize

57829

increased by1.11%

Lines of code

1385

increased by1.09%

No dependency changes