foreman - npm Package Compare versions

Comparing version 2.0.0 to 3.0.0

CHANGES.md

@@ -0,1 +1,11 @@
[phone], Version 3.0.0
+=========================
+
+ * Update outdated dependencies to latest (Miroslav Bajtoš)
+
+ * Fix error "Unknown signal: null" (Kaspar Schiess)
+
+ * Update supported Node.js versions (Miroslav Bajtoš)
+
+
 2016-08-25, Version 2.0.0
@@ -2,0 +12,0 @@ =========================

lib/proc.js

@@ -32,2 +32,3 @@ // Copyright IBM Corp. 2012,2016. All Rights Reserved.
   var child = prog.spawn(file, args, { env: proc.env });
+  var killallReceived = false;
 
@@ -42,7 +43,7 @@ child.stdout.on('data', function(data) {
 
-  child.on('close', function(code) {
+  child.on('close', function(code, signal) {
     if(code === 0) {
       cons.info(key, proc, "Exited Successfully");
     } else {
-      cons.error(key, proc, "Exited with exit code " + code);
+      cons.error(key, proc, "Exited with exit code " + signal || code);
     }
@@ -52,7 +53,22 @@ });
   child.on('exit', function(code, signal) {
-    emitter.emit('killall', signal);
+    if (!killallReceived) {
+      emitter.emit('killall', signal || 'SIGINT');
+    }
   });
 
   emitter.on('killall', function(signal) {
-    child.kill(signal);
+    // Once this process has received a killall event, don't send another
+    // such event to everyone. Let's assume that once is enough.
+    killallReceived = true;
+
+    try {
+      child.kill(signal);
+    }
+    catch (err) {
+      if (err.code === 'EPERM') {
+        // Means that the child runs with higher privileges than we are; we're
+        // not going to be able to kill it in that state. Log and do nothing.
+        cons.error(key, proc, "Process has become unkillable; returns EPERM.");
+      }
+    }
   });
@@ -59,0 +75,0 @@

package.json

 {
   "name": "foreman",
-  "version": "2.0.0",
+  "version": "3.0.0",
   "homepage": "http://strongloop.github.io/node-foreman/",
@@ -29,6 +29,6 @@ "description": "Node Implementation of Foreman",
   "dependencies": {
-    "commander": "~2.9.0",
-    "http-proxy": "~1.11.1",
+    "commander": "^2.15.1",
+    "http-proxy": "^1.17.0",
     "mustache": "^2.2.1",
-    "shell-quote": "~1.4.2"
+    "shell-quote": "^1.6.1"
   },
@@ -44,3 +44,3 @@ "repository": {
   "engines": {
-    "node": ">=0.6.9"
+    "node": ">=6"
   },
@@ -47,0 +47,0 @@ "preferGlobal": true,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

61795

increased by1.33%

Lines of code

1073

increased by1.42%

Worsened metrics

Number of medium supply chain risk alerts

9

increased by12.5%

Dependency changes

• + Addedcommander@2.20.3(transitive)

• + Addedeventemitter3@4.0.7(transitive)

• + Addedfollow-redirects@1.15.9(transitive)

• + Addedhttp-proxy@1.18.1(transitive)

• + Addedrequires-port@1.0.0(transitive)

• + Addedshell-quote@1.8.2(transitive)

• - Removedarray-filter@0.0.1(transitive)

• - Removedarray-map@0.0.1(transitive)

• - Removedarray-reduce@0.0.0(transitive)

• - Removedcommander@2.9.0(transitive)

• - Removedeventemitter3@1.2.0(transitive)

• - Removedgraceful-readlink@1.0.1(transitive)

• - Removedhttp-proxy@1.11.3(transitive)

• - Removedjsonify@0.0.1(transitive)

• - Removedrequires-port@0.0.1(transitive)

• - Removedshell-quote@1.4.3(transitive)

• Updatedcommander@^2.15.1

• Updatedhttp-proxy@^1.17.0

• Updatedshell-quote@^1.6.1