fuelux - npm Package Compare versions

Comparing version 3.15.12 to 3.15.13

bower.json

@@ -28,3 +28,3 @@ {
     "jquery-1.9.1": "jquery#1.9.1",
-    "qunit": "2.x",
+    "qunit": "2.3.0",
     "requirejs-text": "2.x",
@@ -31,0 +31,0 @@ "underscore": "1.x",

grunt/config/shell.js

@@ -95,3 +95,3 @@ module.exports = function (grunt) {
 					return ['mv dist ' + version,
-						'scp -i -oHostKeyAlgorithms=+ssh-dss ~/.ssh/fuelcdn -r "' + version + '"/ ' +
+						'scp -i ~/.ssh/fuelcdn -oHostKeyAlgorithms=+ssh-dss -r "' + version + '"/ ' +
 							'<%= cdnLoginFile.user %>' + '@' + '<%= cdnLoginFile.server %>' + ':' + '<%= cdnLoginFile.folder %>',
@@ -98,0 +98,0 @@ 'mv "' + version + '" dist',

js/spinbox.js

@@ -170,7 +170,7 @@ /*
 		render: function render() {
-			this.setValue(this.getDisplayValue());
+			this._setValue(this.getDisplayValue());
 		},
 
 		change: function change() {
-			this.setValue(this.getDisplayValue());
+			this._setValue(this.getDisplayValue());
 
@@ -226,3 +226,3 @@ this.triggerChangedEvent();
 			//refresh value from display before trying to increment in case they have just been typing before clicking the nubbins
-			this.setValue(this.getDisplayValue());
+			this._setValue(this.getDisplayValue());
 			var newVal;
@@ -238,3 +238,3 @@
 
-			this.setValue(newVal + this.unit);
+			this._setValue(newVal + this.unit);
 		},
@@ -261,2 +261,6 @@
 		setValue: function setValue(val) {
+			return this._setValue(val, true);
+		},
+
+		_setValue: function _setValue(val, shouldSetLastValue) {
 			//remove any i18n on the number
@@ -278,3 +282,3 @@ if (this.options.decimalMark !== '.') {
 			if (isNaN(intVal) && !isFinite(intVal)) {
-				return this.setValue(this.options.value);
+				return this._setValue(this.options.value, shouldSetLastValue);
 			}
@@ -298,2 +302,6 @@
 
+			if (shouldSetLastValue) {
+				this.lastValue = val;
+			}
+
 			return this;
@@ -300,0 +308,0 @@ },

package.json

@@ -90,3 +90,3 @@ {
   "title": "Fuel UX",
-  "version": "3.15.12",
+  "version": "3.15.13",
   "volo": {
@@ -93,0 +93,0 @@ "baseDir": "lib",

test/repeater-test.js

@@ -383,10 +383,8 @@ /* global QUnit:false, module:false, test:false, asyncTest:false, expect:false */
 		var $repeater = $( this.$markup );
-		var count = 0;
 		$repeater.on( 'rendered.fu.repeater', function rendered ( e, state ) {
-			count++;
+			// rendered is triggered on `this.$search` and `this.$element` in repeater.js
+			if ( e.target.id === $repeater.attr('id') ) {
+				assert.ok( state.data, 'data object exists' );
+				assert.equal( state.data.myVar, 'passalong', 'data returned from datasource was passed along' );
 
-			assert.ok( state.data, 'data object exists' );
-			assert.equal( state.data.myVar, 'passalong', 'data returned from datasource was passed along' );
-
-			if ( count === 2 ) {
 				ready();
@@ -393,0 +391,0 @@ }

test/spinbox-test.js

@@ -288,2 +288,19 @@ /*global QUnit:false, module:false, test:false, asyncTest:false, expect:false*/
 
+	QUnit.test('spinbox should trigger change after using setValue', function (assert) {
+		var ready = assert.async();
+		var $spinbox = $(html).find('#MySpinboxDecimal').spinbox({
+			value: '1'
+		});
+
+		$spinbox.spinbox('setValue', '2');
+
+		$spinbox.on('changed.fu.spinbox', function () {
+			assert.ok(true, 'spinbox triggers changed after input' );
+			ready();
+		});
+
+		$spinbox.find('.spinbox-input').val(1);
+		$spinbox.find('.spinbox-input').focusout();
+	});
+
 	QUnit.test( "should destroy control", function( assert ) {
@@ -290,0 +307,0 @@ var $el = $( html ).find( "#MySpinbox" );

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

18040390

increased by0.01%

Lines of code

27391

increased by0.09%

No dependency changes