gh-lint - npm Package Compare versions

Comparing version 0.6.1 to 0.6.2

lib/cli/commands/check.js

@@ -67,4 +67,4 @@ 'use strict';
         const ruleResults = results[repoName][ruleName];
+        count++;
         if (opts.tap) {
-          count++;
           if (ruleResults.length) {
@@ -76,4 +76,3 @@ let idx = 0;
   ---
-  message: ${JSON.stringify(result.message)}
-  messages: ${JSON.stringify(result.messages)}
+  message: ${JSON.stringify(result.message)}${extraMessages(result)}
   severity: ${result.mode == 2 ? 'error' : 'warning'}
@@ -91,12 +90,16 @@ ${tapTestMeta(repoName, ruleName)}`);
         } else {
-          for (const result of ruleResults) {
-            let logMethod, resType;
-            if (result.mode == 2) {
-              logMethod = resType = 'error';
-              hasErrors = true;
-            } else {
-              logMethod = 'warn';
-              resType = 'warning';
+          if (ruleResults.length) {
+            for (const result of ruleResults) {
+              let logMethod, resType;
+              if (result.mode == 2) {
+                logMethod = resType = 'error';
+                hasErrors = true;
+              } else {
+                logMethod = 'warn';
+                resType = 'warning';
+              }
+              console[logMethod](`${resType} ${repoName}: ${ruleName} - ${result.message}`);
             }
-            console[logMethod](`${resType} ${repoName}: ${ruleName} - ${result.message}`);
+          } else {
+            passed++;
           }
@@ -114,2 +117,4 @@ }
 # ${count > passed ? 'not ok' : 'ok'}`);
+    } else {
+      console.log(`passed ${passed} out of ${count}`);
     }
@@ -130,1 +135,8 @@
 }
+
+
+function extraMessages(result) {
+  return result.messages && result.messages.length
+          ? '\n  messages: ' + JSON.stringify(result.messages)
+          : '';
+}

lib/rules/repo-team.js

@@ -31,3 +31,4 @@ 'use strict';
       valid: false,
-      message: 'Repo not assigned to one of specified teams'
+      message: 'Repo not assigned to one of specified teams',
+      messages: [`Specified teams: ${cfg.teams.join(', ')}`]
     };
@@ -34,0 +35,0 @@ },

package.json

 {
   "name": "gh-lint",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "Rule-based command-line tool for auditing GitHub repositories",
@@ -5,0 +5,0 @@ "main": "lib/execute/index.js",

spec/cli/run.spec.js

@@ -32,3 +32,5 @@ 'use strict';
       .then(() => {
-        assert.equal(log, 'warning MailOnline/videojs-vast-vpaid: repo-homepage - not satisfied');
+        assert.equal(log,
+`warning MailOnline/videojs-vast-vpaid: repo-homepage - not satisfied
+passed 3 out of 4`);
         assert(nock.isDone());
@@ -44,3 +46,5 @@ });
       .then(() => {
-        assert.equal(log, 'warning MailOnline/videojs-vast-vpaid: repo-homepage - not satisfied');
+        assert.equal(log,
+`warning MailOnline/videojs-vast-vpaid: repo-homepage - not satisfied
+passed 3 out of 4`);
         assert(nock.isDone());
@@ -47,0 +51,0 @@ });

spec/fixtures/config-orgs_expected_cli_output.txt

@@ -49,2 +49,3 @@ warning MailOnline/hornetq-connector: repo-homepage - not satisfied
 warning milojs/ml-check: repo-homepage - not satisfied
-warning milojs/ml-mixin: repo-homepage - not satisfied
+warning milojs/ml-mixin: repo-homepage - not satisfied
+passed 51 out of 100

spec/fixtures/repo-team_expected_results.json

@@ -7,2 +7,5 @@ {
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -17,2 +20,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -30,2 +36,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -40,2 +49,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -59,2 +71,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -69,2 +84,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -82,2 +100,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -92,2 +113,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -102,2 +126,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -112,2 +139,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -122,2 +152,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -132,2 +165,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -142,2 +178,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -152,2 +191,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -171,2 +213,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -184,2 +229,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -197,2 +245,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -207,2 +258,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -217,2 +271,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -227,2 +284,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -237,2 +297,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -247,2 +310,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -263,2 +329,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -276,2 +345,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -289,2 +361,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -308,2 +383,5 @@ }
         "message": "Repo not assigned to one of specified teams",
+        "messages": [
+          "Specified teams: #ads, #cc, #clj, #ios-ny, #ml-nlp, #mol-fe, #rc, #rta, #support, #systems, Metro, IOS"
+        ],
         "mode": 2
@@ -310,0 +388,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

783737

increased by0.55%

Lines of code

15064

increased by0.62%

No dependency changes