gofer - npm Package Compare versions

Comparing version 2.7.0 to 2.7.1

CHANGELOG.md

@@ -0,1 +1,7 @@
+### 2.7.1
+
+* properly clear completion timeouts - **[@dbushong](https://github.com/dbushong)** [#85](https://github.com/groupon/gofer/pull/85)
+  - [`780c998`](https://github.com/groupon/gofer/commit/780c998658c943807fdf2bcc558c607bd4931f00) **fix:** properly clear completion timeouts
+
+
 ### 2.7.0
@@ -2,0 +8,0 @@

lib/hub.js

@@ -149,2 +149,6 @@
       var apiError, logLine, maxStatusCode, minStatusCode, parseError, parseJSON, ref5, ref6, ref7, successfulRequest, uri;
+      if (responseData.completionSuccessful) {
+        responseData.completionSuccessful();
+        delete responseData.completionSuccessful;
+      }
       parseJSON = (ref5 = options.parseJSON) != null ? ref5 : isJsonResponse(response, body);
@@ -295,3 +299,3 @@ if (parseJSON) {
   setupCompletionTimeout = function(completionTimeoutInterval, req, responseData, getSeconds) {
-    var completionSuccessful, completionTimedOut, completionTimeout;
+    var completionTimedOut, completionTimeout;
     if (!completionTimeoutInterval) {
@@ -312,3 +316,3 @@ return;
     };
-    completionSuccessful = function() {
+    responseData.completionSuccessful = function() {
       responseData.completionDuration = getSeconds() - responseData.connectDuration;
@@ -318,3 +322,2 @@ clearTimeout(completionTimeout);
     };
-    req.on('complete', completionSuccessful);
     return completionTimeout = setTimeout(completionTimedOut, completionTimeoutInterval);
@@ -321,0 +324,0 @@ };

package.json

 {
   "name": "gofer",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "description": "A general purpose service client library for node.js",
@@ -5,0 +5,0 @@ "license": "BSD-3-Clause",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

55212

increased by0.7%

Lines of code

997

increased by0.3%

No dependency changes