gofer - npm Package Compare versions

Comparing version 3.5.7 to 3.5.8

CHANGELOG.md

@@ -0,1 +1,7 @@
+### 3.5.8
+
+* don't set connect timeout for keepalive - **[@dbushong](https://github.com/dbushong)** [#86](https://github.com/groupon/gofer/pull/86)
+  - [`cd57ced`](https://github.com/groupon/gofer/commit/cd57ced861752d43dba670391e4181f443442331) **fix:** don't set connect timeout for keepalive
+
+
 ### 3.5.7
@@ -2,0 +8,0 @@

lib/request.js

@@ -285,5 +285,8 @@ /*
     timing.socket = Date.now() - startTime;
-    connectTimer = setIOTimeout(onConnectTimedOut, options.connectTimeout);
-    socket.once('connect', onConnect);
 
+    if (socket._connecting || socket.connecting) {
+      connectTimer = setIOTimeout(onConnectTimedOut, options.connectTimeout);
+      socket.once('connect', onConnect);
+    }
+
     responseTimer = setIOTimeout(onResponseTimedOut, options.timeout);
@@ -290,0 +293,0 @@ }

package.json

 {
   "name": "gofer",
-  "version": "3.5.7",
+  "version": "3.5.8",
   "description": "A general purpose service client library",
@@ -5,0 +5,0 @@ "license": "BSD-3-Clause",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

64301

increased by0.56%

Lines of code

1293

increased by0.15%

No dependency changes