gooddata - npm Package Compare versions

Comparing version 4.5.0-pbenes-visualization-object-2018-01-10T13-06-24-501Z to 4.5.0-pbenes-visualization-object-2018-01-11T09-01-34-985Z

lib/catalogue.js

@@ -99,3 +99,4 @@ 'use strict';
 
-    if (mdObj) {
+    var hasBuckets = (0, _lodash.get)(mdObj, 'buckets') !== undefined;
+    if (mdObj && hasBuckets) {
         return bucketItemsToExecConfig(projectId, mdObj, { attributesMap: attributesMap }).then(function (bucketItems) {
@@ -102,0 +103,0 @@ return loadCatalog(projectId, _extends({}, request, {

lib/execution/experimental-executions.js

@@ -295,3 +295,3 @@ 'use strict';
 function getDateFilterExpression() {
-    // TODO
+    // measure date filter was never supported
     return '';
@@ -408,7 +408,7 @@ }
 
-    return getAttrTypeFromMap((0, _lodash.get)(category, 'displayForm'), attributesMap) !== undefined;
+    return getAttrTypeFromMap((0, _lodash.get)(category, ['displayForm', 'uri']), attributesMap) !== undefined;
 }
 
 function getMeasureSorting(measure, mdObj) {
-    var sorting = (0, _lodash.get)(mdObj, ['properties', 'sorts'], []); // TODO check this
+    var sorting = (0, _lodash.get)(mdObj, ['properties', 'sorts'], []);
     var matchedSorting = sorting.find(function (sortItem) {
@@ -415,0 +415,0 @@ var measureSortItem = (0, _lodash.get)(sortItem, ['measureSortItem']);

package.json

 {
   "name": "gooddata",
-  "version": "4.5.0-pbenes-visualization-object-2018-01-10T13-06-24-501Z",
+  "version": "4.5.0-pbenes-visualization-object-2018-01-11T09-01-34-985Z",
   "author": "GoodData",
@@ -64,3 +64,3 @@ "description": "GoodData JavaScript SDK",
   "dependencies": {
-    "@gooddata/typings": "0.0.5-pbenes-visualization-object-2018-01-10T13-05-43-626Z",
+    "@gooddata/typings": "0.0.5-pbenes-visualization-object-2018-01-11T09-00-54-250Z",
     "es6-promise": "3.0.2",
@@ -67,0 +67,0 @@ "fetch-cookie": "0.4.0",

src/catalogue.js

@@ -88,3 +88,4 @@ import { get, find, omit, cloneDeep } from 'lodash';
     const { attributesMap } = options;
-    if (mdObj) {
+    const hasBuckets = get(mdObj, 'buckets') !== undefined;
+    if (mdObj && hasBuckets) {
         return bucketItemsToExecConfig(projectId, mdObj, { attributesMap }).then(bucketItems =>
@@ -91,0 +92,0 @@ loadCatalog(projectId,

src/execution/experimental-executions.js

@@ -293,3 +293,3 @@ // Copyright (C) 2007-2014, GoodData(R) Corporation. All rights reserved.
 function getDateFilterExpression() {
-    // TODO
+    // measure date filter was never supported
     return '';
@@ -394,7 +394,7 @@ }
 function isDateCategory(category, attributesMap = {}) {
-    return getAttrTypeFromMap(get(category, 'displayForm'), attributesMap) !== undefined;
+    return getAttrTypeFromMap(get(category, ['displayForm', 'uri']), attributesMap) !== undefined;
 }
 
 function getMeasureSorting(measure, mdObj) {
-    const sorting = get(mdObj, ['properties', 'sorts'], []); // TODO check this
+    const sorting = get(mdObj, ['properties', 'sorts'], []);
     const matchedSorting = sorting.find((sortItem) => {
@@ -401,0 +401,0 @@ const measureSortItem = get(sortItem, ['measureSortItem']);

No alert changes

Improved metrics

Total package byte prevSize

1152059

increased by0.03%

Lines of code

27004

increased by0.47%

Dependency changes

• + Added@gooddata/typings@0.0.5-pbenes-visualization-object-2018-01-11T09-00-54-250Z(transitive)

• - Removed@gooddata/typings@0.0.5-pbenes-visualization-object-2018-01-10T13-05-43-626Z(transitive)

• Updated@gooddata/typings@0.0.5-pbenes-visualization-object-2018-01-11T09-00-54-250Z