google-cloud-bucket - npm Package Compare versions

Comparing version 0.3.1 to 0.3.2

CHANGELOG.md

@@ -5,2 +5,12 @@ # Change Log
 
+<a name="0.3.2"></a>
+## [0.3.2](https://github.com/nicolasdao/google-cloud-bucket/compare/v0.3.1...v0.3.2) (2018-12-05)
+
+
+### Bug Fixes
+
+* isPublic API fails ([29f7db5](https://github.com/nicolasdao/google-cloud-bucket/commit/29f7db5))
+
+
+
 <a name="0.3.1"></a>
@@ -7,0 +17,0 @@ ## [0.3.1](https://github.com/nicolasdao/google-cloud-bucket/compare/v0.3.0...v0.3.1) (2018-12-05)

index.js

@@ -55,3 +55,3 @@ /**
 	const getBucket = (bucket) => getToken(auth).then(token => gcp.config.get(bucket, token)).then(({ data }) => data)
-	const isBucketPublic = (bucket) => getToken(auth).then(token => gcp.config.isBucketPublic(bucket, token)).then(({ data }) => data)
+	const isBucketPublic = (bucket) => getToken(auth).then(token => gcp.config.isBucketPublic(bucket, token))
 	const updateConfig = (bucket, config={}) => getToken(auth).then(token => gcp.config.update(bucket, config, token)).then(({ data }) => data)
@@ -58,0 +58,0 @@ const addPublicAccess = filePath => getToken(auth).then(token => {

package.json

 {
   "name": "google-cloud-bucket",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "Nodejs package to add objects to a Google Cloud Bucket.",
@@ -5,0 +5,0 @@ "main": "index.js",

src/gcp.js

@@ -90,3 +90,3 @@ /**
 		const objectViewerBinding = bindings.find(b => b && b.role == 'roles/storage.objectViewer')
-		return objectViewerBinding && (objectViewerBinding.members || []).some(m => m == 'allUsers')
+		return objectViewerBinding && (objectViewerBinding.members || []).some(m => m == 'allUsers') ? true : false
 	})
@@ -93,0 +93,0 @@ })

No alert changes

Improved metrics

Total package byte prevSize

47758

increased by0.48%

No dependency changes