googleplaces - npm Package Compare versions

Comparing version 0.2.0 to 0.3.0

lib/AddEvent.js

@@ -22,6 +22,6 @@ (function () {
 
-            if (!parameters.duration) throw new Error("Event duration is required");
-            if (parseInt(parameters.duration) !== parameters.duration) throw new Error("Event duration must be an integer");
-            if (!parameters.summary) throw new Error("Event summary is required");
-            if (!parameters.reference) throw new Error("Place reference is required");
+            if (!parameters.duration) callback(new Error("Event duration is required"));
+            if (parseInt(parameters.duration) !== parameters.duration) callback(new Error("Event duration must be an integer"));
+            if (!parameters.summary) callback(new Error("Event summary is required"));
+            if (!parameters.reference) callback(new Error("Place reference is required"));
             var options = {
@@ -35,3 +35,3 @@ method: "POST",
             request.on("error", function (error) {
-                throw new Error(error);
+                callback(new Error(error));
             });
@@ -38,0 +38,0 @@

lib/DeleteEvent.js

@@ -22,4 +22,4 @@ (function () {
 
-            if (!parameters.event_id) throw new Error("event_id is required");
-            if (!parameters.reference) throw new Error("Place reference is required");
+            if (!parameters.event_id) callback(new Error("event_id is required"));
+            if (!parameters.reference) callback(new Error("Place reference is required"));
             var options = {
@@ -33,3 +33,3 @@ method: "POST",
             request.on("error", function (error) {
-                throw new Error(error);
+                callback(new Error(error));
             });
@@ -36,0 +36,0 @@

lib/EventDetails.js

@@ -16,4 +16,4 @@ (function () {
             parameters.sensor = parameters.sensor || false;
-            if (!parameters.event_id) throw new Error("event_id is required");
-            if (!parameters.reference) throw new Error("Place reference is required");
+            if (!parameters.event_id) callback(new Error("event_id is required"));
+            if (!parameters.reference) callback(new Error("Place reference is required"));
             var options = {
@@ -26,3 +26,3 @@ hostname: "maps.googleapis.com",
             request.on("error", function (error) {
-                throw new Error(error);
+                callback(new Error(error));
             });
@@ -29,0 +29,0 @@

lib/PlaceDetailsRequest.js

@@ -16,3 +16,3 @@ (function () {
             parameters.sensor = parameters.sensor || false;
-            if (!parameters.reference && !parameters.placeid) throw new Error("Place reference or placeid is required");
+            if (!parameters.reference && !parameters.placeid) callback(new Error("Place reference or placeid is required"));
             var options = {
@@ -24,3 +24,3 @@ hostname: "maps.googleapis.com",
             request.on("error", function (error) {
-                throw new Error(error);
+                callback(new Error(error));
             });
@@ -27,0 +27,0 @@ request.end();

lib/PlaceSearch.js

@@ -25,3 +25,3 @@ (function () {
             request.on("error", function (error) {
-                throw new Error(error);
+                callback(new Error(error));
             });
@@ -28,0 +28,0 @@ request.end();

lib/TextSearch.js

@@ -24,3 +24,3 @@ (function () {
             request.on("error", function (error) {
-                throw new Error(error);
+                callback(new Error(error));
             });
@@ -27,0 +27,0 @@ request.end();

lib/validate.js

@@ -5,3 +5,3 @@ (function () {
     exports.apiKey = function (apiKey) {
-        if (!apiKey) throw new Error("apiKey must not be null");
+        if (!apiKey) callback(new Error("apiKey must not be null"));
     };
@@ -11,5 +11,5 @@
         var validFormats = ["json", "xml"];
-        if (validFormats.indexOf(outputFormat) === -1)  throw new Error("outputFormat must be 'json' or 'xml'");
+        if (validFormats.indexOf(outputFormat) === -1)  callback(new Error("outputFormat must be 'json' or 'xml'"));
     };
 
 })();

package.json

 {
   "name":"googleplaces",
-  "version":"0.2.0",
+  "version":"0.3.0",
   "description":"Node.js library for the Google Places API",
@@ -5,0 +5,0 @@ "keywords":["google", "places", "api", "google places", "google places api"],

test/config.js

 (function () {
     "use strict";
 
-    exports.apiKey = process.env.GOOGLE_API_KEY || "your google api key (server) comes here";
-    exports.outputFormat = "json";
+    exports.apiKey = process.env.GOOGLE_PLACES_API_KEY || "your google api key (server) comes here";
+    exports.outputFormat = process.env.GOOGLE_PLACES_OUTPUT_FORMAT || "json";
 
 })();

test/EventsTest.js

@@ -20,2 +20,3 @@ (function () {
     googlePlaces.placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         parameters = {
@@ -27,2 +28,3 @@ duration: 60,
         googlePlaces.addEvent(parameters, function (error, response) {
+            if (error) throw error;
             assert.equal(response.status, "OK", "Add Event request response status is OK");
@@ -40,2 +42,3 @@ });
     googlePlaces.placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         parameters = {
@@ -47,2 +50,3 @@ duration: 60,
         googlePlaces.addEvent(parameters, function (error, response) {
+            if (error) throw error;
             assert.equal(response.status, "OK", "Add Event request response status is OK");
@@ -55,2 +59,3 @@ parameters = {
             googlePlaces.deleteEvent(parameters, function (error, response) {
+                if (error) throw error;
                 assert.equal(response.status, "OK", "Delete Event request response status is OK");
@@ -69,2 +74,3 @@ });
     googlePlaces.placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         parameters = {
@@ -76,2 +82,3 @@ duration: 60,
         googlePlaces.addEvent(parameters, function (error, response) {
+            if (error) throw error;
             assert.equal(response.status, "OK", "Add Event request response status is OK");
@@ -84,2 +91,3 @@ var parameters2 = {
             googlePlaces.eventDetails(parameters2, function (error, response) {
+                if (error) throw error;
                 assert.equal(response.status, "OK", "Delete Event request response status is OK");
@@ -86,0 +94,0 @@ });

test/GooglePlacesTest.js

@@ -20,2 +20,3 @@ (function () {
     googlePlaces.placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         assert.notEqual(response.results.length, 0, "Place search must not return 0 results");
@@ -31,2 +32,3 @@ });
     googlePlaces.textSearch(parameters, function (error, response) {
+        if (error) throw error;
         assert.notEqual(response.results.length, 0, "Text search must not return 0 results");
@@ -43,3 +45,5 @@ });
     googlePlaces.placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         googlePlaces.placeDetailsRequest({reference: response.results[0].reference}, function (error, response) {
+            if (error) throw error;
             assert.equal(response.status, "OK", "Place details request response status is OK");
@@ -46,0 +50,0 @@ });

test/PlaceDetailsRequestTest.js

@@ -19,3 +19,5 @@ (function () {
     placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         placeDetailsRequest({reference: response.results[0].reference}, function (error, response) {
+            if (error) throw error;
             assert.equal(response.status, "OK", "Place details request response status is OK");
@@ -22,0 +24,0 @@ });

test/PlaceSearchTest.js

@@ -17,2 +17,3 @@ (function () {
     placeSearch(parameters, function (error, response) {
+        if (error) throw error;
         assert.notEqual(response.results.length, 0, "Place search must not return 0 results");
@@ -19,0 +20,0 @@ });

test/TextSearchTest.js

@@ -16,2 +16,3 @@ (function () {
     textSearch(parameters, function (error, response) {
+        if (error) throw error;
         assert.notEqual(response.results.length, 0, "Text search must not return 0 results");
@@ -18,0 +19,0 @@ });

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

21352

increased by5.5%

Lines of code

398

increased by4.19%

Number of medium supply chain risk alerts

6

decreased by-25%

Worsened metrics

Number of lines in readme file

112

decreased by-5.88%

No dependency changes