govuk_frontend_toolkit - npm Package Compare versions

Comparing version 3.3.0 to 3.3.1

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 3.3.1
+
+- Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA 
+
 # 3.3.0
@@ -2,0 +6,0 @@

javascripts/govuk/analytics/google-analytics-classic-tracker.js

@@ -107,6 +107,22 @@ (function() {
   GoogleAnalyticsClassicTracker.prototype.setCustomVariable = function(index, value, name, scope) {
+    var PAGE_LEVEL_SCOPE = 3;
+    scope = scope || PAGE_LEVEL_SCOPE;
+
+    if (typeof index !== "number") {
+      index = parseInt(index, 10);
+    }
+
+    if (typeof scope !== "number") {
+      scope = parseInt(scope, 10);
+    }
+
     _gaq.push(['_setCustomVar', index, name, String(value), scope]);
   };
 
+  // Match tracker and universal API
+  GoogleAnalyticsClassicTracker.prototype.setDimension = function(index, value, name, scope) {
+    this.setCustomVariable(index, value, name, scope);
+  }
+
   GOVUK.GoogleAnalyticsClassicTracker = GoogleAnalyticsClassicTracker;
 })();

javascripts/govuk/analytics/tracker.js

@@ -45,13 +45,2 @@ (function() {
   Tracker.prototype.setDimension = function(index, value, name, scope) {
-    var PAGE_LEVEL_SCOPE = 3;
-    scope = scope || PAGE_LEVEL_SCOPE;
-
-    if (typeof index !== "number") {
-      index = parseInt(index, 10);
-    }
-
-    if (typeof scope !== "number") {
-      scope = parseInt(scope, 10);
-    }
-
     this.universal.setDimension(index, value);
@@ -58,0 +47,0 @@ this.classic.setCustomVariable(index, value, name, scope);

package.json

 {
   "name": "govuk_frontend_toolkit",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "description": "npm package for using the GOV.UK frontend toolkit",
@@ -5,0 +5,0 @@ "repository": {

VERSION.txt

@@ -1,1 +0,1 @@
-3.3.0
+3.3.1

No alert changes

Improved metrics

Total package byte prevSize

466858

increased by0.06%

Lines of code

848

increased by0.47%

No dependency changes