graphql-kafka-subscriptions - npm Package Compare versions

Comparing version 0.2.3 to 0.2.5

dist/kafka-pubsub.d.ts

@@ -11,2 +11,3 @@ /// <reference types="bunyan" />
     groupId?: any;
+    globalConfig?: object;
 }
@@ -13,0 +14,0 @@ export interface IKafkaProducer {

dist/kafka-pubsub.js

@@ -64,5 +64,3 @@ "use strict";
         var _this = this;
-        var producer = Kafka.Producer.createWriteStream({
-            'metadata.broker.list': this.brokerList()
-        }, {}, { topic: topic });
+        var producer = Kafka.Producer.createWriteStream(Object.assign({}, { 'metadata.broker.list': this.brokerList() }, this.options.globalConfig), {}, { topic: topic });
         producer.on('error', function (err) {
@@ -76,8 +74,6 @@ _this.logger.error(err, 'Error in our kafka stream');
         var groupId = this.options.groupId || Math.ceil(Math.random() * 9999);
-        var consumer = Kafka.KafkaConsumer.createReadStream({
+        var consumer = Kafka.KafkaConsumer.createReadStream(Object.assign({}, {
             'group.id': "kafka-group-" + groupId,
             'metadata.broker.list': this.brokerList(),
-        }, {}, {
-            topics: [topic]
-        });
+        }, this.options.globalConfig), {}, { topics: [topic] });
         consumer.on('data', function (message) {
@@ -84,0 +80,0 @@ var parsedMessage = JSON.parse(message.value.toString());

package.json

 {
   "name": "graphql-kafka-subscriptions",
-  "version": "0.2.3",
+  "version": "0.2.5",
   "description": "Apollo graphql subscription over Kafka protocol",
@@ -48,3 +48,3 @@ "main": "dist/index.js",
     "iterall": "^1.1.1",
-    "node-rdkafka": "^2.1.0"
+    "node-rdkafka": "^2.5.1"
   },
@@ -51,0 +51,0 @@ "devDependencies": {

README.md

@@ -10,2 +10,13 @@ # graphql-kafka-subscriptions
 
+### Mac OS High Sierra / Mojave
+
+OpenSSL has been upgraded in High Sierra and homebrew does not overwrite default system libraries. That means when building node-rdkafka, because you are using openssl, you need to tell the linker where to find it:
+
+```sh
+export CPPFLAGS=-I/usr/local/opt/openssl/include
+export LDFLAGS=-L/usr/local/opt/openssl/lib
+```
+
+Then you can run `npm install` on your application to get it to build correctly.
+
 ## Usage
@@ -19,2 +30,3 @@ ```javascript
   port: 'INSERT_KAFKA_PORT',
+  globalConfig: {} // options passed directly to the consumer and producer
 })
@@ -21,0 +33,0 @@ ```

No alert changes

Improved metrics

Total package byte prevSize

146567

increased by0.49%

Number of lines in readme file

64

increased by23.08%

Worsened metrics

Lines of code

472

decreased by-0.63%

Dependency changes

• Updatednode-rdkafka@^2.5.1