gulp-notify - npm Package Compare versions

Comparing version 1.7.1 to 1.8.0

CHANGELOG.md

 Changelog
 ===
 
+#### `v1.8.0`
+1. Changes notification to continue stream at once (unless when using the stream - i.e. when emitting errors)
+2. Fixes example gulpfile by returning stream for each task.
+
+
+#### `v1.7.1`
+1. Fixes issue with Windows 7 and Growl/Bubble conditional.
+
 #### `v1.7.0`
@@ -5,0 +13,0 @@ 1. Now supports native windows 7 and earlier notifications, through balloons! This means that gulp-notify can be used on any platform without any extra installs.

examples/gulpfile.js

@@ -15,3 +15,3 @@
 gulp.task("one", function () {
-  gulp.src("../test/fixtures/1.txt")
+  return gulp.src("../test/fixtures/1.txt")
       .pipe(notify());
@@ -21,3 +21,3 @@ });
 gulp.task("message", function () {
-  gulp.src("../test/fixtures/1.txt")
+  return gulp.src("../test/fixtures/1.txt")
       .pipe(notify("This is a message."));
@@ -34,3 +34,3 @@ });
 
-  gulp.src("../test/fixtures/1.txt")
+  return gulp.src("../test/fixtures/1.txt")
       .pipe(custom("This is a message."));
@@ -40,3 +40,3 @@ });
 gulp.task("template", function () {
-  gulp.src("../test/fixtures/1.txt")
+  return gulp.src("../test/fixtures/1.txt")
       .pipe(notify("Template: <%= file.relative %>"));
@@ -47,3 +47,3 @@ });
 gulp.task("templateadv", function () {
-  gulp.src("../test/fixtures/1.txt")
+  return gulp.src("../test/fixtures/1.txt")
       .pipe(notify({
@@ -64,3 +64,3 @@ message: "Template: <%= file.relative %>",
 gulp.task("function", function () {
-  gulp.src("../test/fixtures/1.txt")
+  return gulp.src("../test/fixtures/1.txt")
       .pipe(notify(function(file) {
@@ -72,3 +72,3 @@ return "Some file: " + file.relative;
 gulp.task("advanced", function () {
-  gulp.src("../test/fixtures/*")
+  return gulp.src("../test/fixtures/*")
       .pipe(notify({
@@ -87,3 +87,3 @@ "title": "Open Github",
 gulp.task("onlast", function () {
-  gulp.src("../test/fixtures/*")
+  return gulp.src("../test/fixtures/*")
       .pipe(notify({
@@ -98,3 +98,3 @@ onLast: true,
 gulp.task("error", function () {
-  gulp.src("../test/fixtures/*")
+  return gulp.src("../test/fixtures/*")
       .pipe(through.obj(function (file, enc, callback) {
@@ -115,3 +115,3 @@ this.emit("error", new Error("Something happend: Error message!"));
 
-  gulp.src("../test/fixtures/*")
+  return gulp.src("../test/fixtures/*")
       .pipe(through.obj(function (file, enc, callback) {
@@ -134,3 +134,3 @@ this.emit("error", new Error("Something happend: Error message!"));
 
-  gulp.src("../test/fixtures/*")
+  return gulp.src("../test/fixtures/*")
       .pipe(custom('<%= file.relative %>'))
@@ -137,0 +137,0 @@ .pipe(through.obj(function (file, enc, callback) {

lib/notify.js

@@ -24,7 +24,16 @@ var through = require("through2");
     var stream = this;
+
     report(reporter, file, options, templateOptions, function (err) {
       logError(err, stream);
+
+      if (options.emitError) {
+        stream.push(file);
+        return callback();
+      }
+    });
+
+    if (!options.emitError) {
       stream.push(file);
-      callback();
-    });
+      return callback();
+    }
   }
@@ -50,5 +59,11 @@
       logError(err, stream);
-      return callback();
+      if (options.emitError) {
+        return callback();
+      }
     });
+
     lastFile = null; // reset
+    if (!options.emitError) {
+      return callback();
+    }
   });
@@ -55,0 +70,0 @@

package.json

 {
   "name": "gulp-notify",
-  "version": "1.7.1",
+  "version": "1.8.0",
   "description": "gulp plugin to send messages based on Vinyl Files or Errors to Mac OS X, Linux or Windows using the node-notifier module. Fallbacks to Growl or simply logging",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

91151

increased by0.64%

Lines of code

1037

increased by1.07%

No dependency changes