halson - npm Package Compare versions

Comparing version 2.3.0 to 2.3.1

bower.json

 {
   "name": "halson",
   "main": "index.js",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "homepage": "https://github.com/seznam/halson",
@@ -6,0 +6,0 @@ "authors": [

CHANGELOG.md

 # Changelog
 
+## Release 2.3.1 (2015-01-14)
+ * Fixed an issue when a single item array is compacted to an object
+
 ## Release 2.3.0 (2015-01-11)
@@ -4,0 +7,0 @@ * Altered addEmbed to accept an array as a second argument

index.js

@@ -148,4 +148,2 @@ (function(module, win) {
     HALSONResource.prototype.insertEmbed = function(rel, index, embed) {
-        var items = [].concat(embed).map(createHALSONResource);
-
         if (!this._embedded) {
@@ -156,5 +154,8 @@ this._embedded = {};
         if (!(rel in this._embedded)) {
-            this._embedded[rel] = [];
+            this._embedded[rel] = Array.isArray(embed) ? embed.map(createHALSONResource) : createHALSONResource(embed);
+            return this;
         }
 
+        var items = [].concat(embed).map(createHALSONResource);
+
         this._embedded[rel] = [].concat(this._embedded[rel]);
@@ -161,0 +162,0 @@

package.json

 {
   "name": "halson",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "The HAL+JSON Resource Object",
@@ -5,0 +5,0 @@ "main": "index.js",

test.js

@@ -470,5 +470,5 @@ var assert = require('assert');
                 _embedded: {
-                    item: {
+                    item: [{
                         title: "Untitled"
-                    }
+                    }]
                 }
@@ -548,2 +548,27 @@ };
 
+        it('add first embed as array second as object', function() {
+            var res = halson();
+            var embed1 = [{title: "Untitled1"}, {title: "Untitled2"}];
+            var embed2 = {title: "Untitled3"};
+            var expected = {
+                _embedded: {
+                    item: [
+                        {
+                            title: "Untitled1"
+                        },
+                        {
+                            title: "Untitled2"
+                        },
+                        {
+                            title: "Untitled3"
+                        }
+                    ]
+                }
+            };
+
+            res.addEmbed('item', embed1);
+            res.addEmbed('item', embed2);
+            assert.deepEqual(res, expected);
+        });
+
     });
@@ -550,0 +575,0 @@

No alert changes

Improved metrics

Total package byte prevSize

39353

increased by2.75%

Lines of code

824

increased by3%

No dependency changes