happychat-service - npm Package Compare versions

Comparing version 0.8.5 to 0.8.6

lib/chat-list.js

@@ -112,2 +112,3 @@ 'use strict';
 		// 3) the assigned operator identity
+
 		var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(ChatList).call(this));
@@ -299,3 +300,3 @@
 					// TODO: Send a message to the chat that an operator was found/opened
-					_this4.operators.emit('message', chat, operator, (0, _assign2.default)((0, _util.makeEventMessage)('operator assigned'), {
+					_this4.operators.emit('message', chat, operator, (0, _assign2.default)((0, _util.makeEventMessage)('operator assigned', chat.id), {
 						meta: { operator: operator, event_type: 'assigned' }
@@ -302,0 +303,0 @@ }));

lib/controller.js

@@ -6,2 +6,3 @@ 'use strict';
 });
+exports.NO_OPS_AVAILABLE_MSG = undefined;
 
@@ -76,2 +77,4 @@ var _isFunction = require('lodash/isFunction');
 
+var NO_OPS_AVAILABLE_MSG = exports.NO_OPS_AVAILABLE_MSG = "No agents are currently available to chat, please try again later.";
+
 exports.default = function (_ref2) {
@@ -154,3 +157,3 @@ var customers = _ref2.customers;
 		};
-		var message = (0, _util.makeEventMessage)("No agents are currently available to chat. If you'd like to become available as an agent, log in at https://happychat.io", chat_id);
+		var message = (0, _util.makeEventMessage)(NO_OPS_AVAILABLE_MSG, chat_id);
 		message.type = 'message';
@@ -157,0 +160,0 @@ message.user = user;

lib/customer.js

@@ -16,5 +16,6 @@ 'use strict';
 	var id = _ref.id;
-	var displayName = _ref.displayName;
-	var avatarURL = _ref.avatarURL;
-	return { id: id, displayName: displayName, avatarURL: avatarURL };
+	var name = _ref.name;
+	var username = _ref.username;
+	var picture = _ref.picture;
+	return { id: id, name: name, username: username, picture: picture };
 };
@@ -21,0 +22,0 @@

lib/operator/index.js

@@ -7,2 +7,4 @@ 'use strict';
 
+var _slicedToArray = function () { function sliceIterator(arr, i) { var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"]) _i["return"](); } finally { if (_d) throw _e; } } return _arr; } return function (arr, i) { if (Array.isArray(arr)) { return arr; } else if (Symbol.iterator in Object(arr)) { return sliceIterator(arr, i); } else { throw new TypeError("Invalid attempt to destructure non-iterable instance"); } }; }();
+
 var _events = require('events');
@@ -131,16 +133,16 @@
 		return new Promise(function (resolve, reject) {
-			var operator = availability.filter(function (op) {
+			var _availability$filter$ = availability.filter(function (op) {
 				return op.capacity - op.load > 0;
 			}).sort(function (a, b) {
-				var a_open = a.capacity - a.load;
-				var b_open = b.capacity - b.load;
-				if (a_open === b_open) return 0;
-				return a_open > b_open ? -1 : 1;
-			}).sort(function (a, b) {
-				if (a.load === b.load) {
-					return 0;
-				}
-				return a.load < b.load ? -1 : 1;
-			})[0];
+				var a_weight = (a.capacity - a.load) / a.capacity;
+				var b_weight = (b.capacity - b.load) / b.capacity;
+				if (a_weight === b_weight) return 0;
+				return a_weight > b_weight ? -1 : 1;
+			});
 
+			var _availability$filter$2 = _slicedToArray(_availability$filter$, 1);
+
+			var operator = _availability$filter$2[0];
+
+
 			if (!operator) {
@@ -147,0 +149,0 @@ return reject(new Error('no operators available'));

lib/operator/store.js

@@ -86,4 +86,4 @@ 'use strict';
 		case REMOVE_USER_SOCKET:
-			var _sockets = (0, _get2.default)(state, user.id, []);
-			return (0, _assign2.default)({}, state, (0, _set2.default)({}, user.id, (0, _reject2.default)(_sockets, socket.id)));
+			var sockets = (0, _get2.default)(state, user.id, []);
+			return (0, _assign2.default)({}, state, (0, _set2.default)({}, user.id, (0, _reject2.default)(sockets, socket.id)));
 		case REMOVE_USER:
@@ -90,0 +90,0 @@ return (0, _omit2.default)(state, user.id);

package.json

 {
   "name": "happychat-service",
-  "version": "0.8.5",
+  "version": "0.8.6",
   "description": "Socket.IO based chat server for happychat.",
   "main": "index.js",
   "scripts": {
-    "test": "`npm bin`/mocha --compilers js:babel-register --recursive",
+    "test": "NODE_PATH=./src `npm bin`/mocha --compilers js:babel-register --recursive",
+    "test:coverage": "NODE_PATH=./src babel-node `npm bin`/isparta cover --include-all-sources --include 'src/**/*.js' _mocha -- --recursive",
     "build": "`npm bin`/babel -d lib ./src/",
@@ -25,3 +26,6 @@ "prepublish": "npm run build"
     "babel-register": "^6.7.0",
-    "mocha": "^2.4.5"
+    "isparta": "^4.0.0",
+    "mocha": "^2.4.5",
+    "mocha-junit-reporter": "^1.12.0",
+    "socket.io-client": "^1.4.8"
   },
@@ -28,0 +32,0 @@ "dependencies": {

Fixed alerts

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

56721

increased by0.83%

Number of package files

13

increased by8.33%

Number of medium quality alerts

1

decreased by-50%

Number of lines in readme file

17

increased byInfinity%

Worsened metrics

Dev dependency count

7

increased by75%

Lines of code

1427

decreased by-2.86%

No dependency changes