henrybuilt-js-library
Advanced tools
Comparing version 1.3.2 to 1.3.3
{ | ||
"name": "henrybuilt-js-library", | ||
"version": "1.3.2", | ||
"version": "1.3.3", | ||
"description": "", | ||
"main": "index.js", | ||
"scripts": { | ||
"develop": "concurrently --kill-others \"webpack --watch\" \"node ./development/app.js\" \"ssh -R henrybuilt-js-library:80:localhost:3152 serveo.net\"", | ||
"build": "webpack && node docs/build.js", | ||
@@ -19,2 +20,4 @@ "build-doc": "node docs/build.js", | ||
"chalk": "^2.4.1", | ||
"concurrently": "^4.0.1", | ||
"express": "^4.16.4", | ||
"mocha": "^5.2.0", | ||
@@ -21,0 +24,0 @@ "nyc": "^13.1.0", |
@@ -12,9 +12,13 @@ # `henrybuilt-js-library` | ||
1. inside `henrybuilt-js-library` | ||
1. determine the new version number, like 1.1.0 | ||
1. `git checkout -b v-X-X-X` where X-X-X is like `1-1-0` and corresponds to the version | ||
1. update `version:` in `package.json` to the new version number | ||
1. make your modifications inside `/src` | ||
1. write tests until you have 100% coverage | ||
1. set up a working branch and version | ||
1. determine the new version number, like 1.1.0 | ||
1. `git checkout -b v-X-X-X` where X-X-X is like `1-1-0` and corresponds to the version | ||
1. update `version:` in `package.json` to the new version number | ||
1. develop your feature(s) | ||
1. make your modifications inside `/src` and keep test coverage at 100% | ||
1. if you're working with henrybuilt-website | ||
1. open another terminal tab and run `npm run develop` | ||
1. temporarily uncomment line 116 in `henrybuilt-website/app/controllers/application_controller.rb` | ||
1. run `npm run build` until it builds without errors | ||
1. run `npm publish` - this will fail if you do not have an `npm` account with access to the `henrybuilt organization` | ||
1. push and max will manage | ||
1. inside `henrybuilt-website` | ||
@@ -21,0 +25,0 @@ 1. update `ENV['HENRYBUILT_JS_LIBRARY_VERSION']` inside `config/application.rb` |
@@ -34,6 +34,2 @@ var Class = require('../class'); | ||
this[modelsKey].push(child); | ||
if (this._canvasObjects[modelsKey]) { | ||
this._canvasObjects[modelsKey].push(...child.allCanvasObjects); | ||
} | ||
}); | ||
@@ -52,6 +48,2 @@ } | ||
if (this._canvasObjects[modelsKey]) { | ||
_.pull(this._canvasObjects[modelsKey], ...child.allCanvasObjects); | ||
} | ||
if (destroy) { | ||
@@ -58,0 +50,0 @@ child.destroy(); |
Sorry, the diff of this file is too big to display
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
155668
31
33
11
1653