homebridge-bigAssFans - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

index.js

@@ -251,19 +251,27 @@ var bigAssApi = require("BigAssFansAPI");
   
-  var existingLightBulbService;
-  if (existingAccessory){
-    existingLightBulbService = existingAccessory.getService(this.homekitLightName);
-  }
-  this.lightService = existingLightBulbService || new Service.Lightbulb(this.homekitLightName);
+  if (this.myBigAss.light.exists) {
+    this.log("Found a light for: " + this.homekitLightName);
   
-  setCharacteristicOnService(this.lightService, Characteristic.On,
-                             "light", "brightness",
-                             boolGetWrapper, lightSetWrapper)
+    var existingLightBulbService;
+    if (existingAccessory){
+      existingLightBulbService = existingAccessory.getService(this.homekitLightName);
+    }
+    this.lightService = existingLightBulbService || new Service.Lightbulb(this.homekitLightName);
   
-  setCharacteristicOnService(this.lightService, Characteristic.Brightness,
-                             "light", "brightness",
-                             getScalingWrapper(lightMaxBrightness), setScalingWrapper(lightMaxBrightness))
+    setCharacteristicOnService(this.lightService, Characteristic.On,
+                               "light", "brightness",
+                               boolGetWrapper, lightSetWrapper)
+  
+    setCharacteristicOnService(this.lightService, Characteristic.Brightness,
+                               "light", "brightness",
+                               getScalingWrapper(lightMaxBrightness), setScalingWrapper(lightMaxBrightness))
 
-  if (existingAccessory && !existingLightBulbService){
-    existingAccessory.addService(this.lightService);
+    if (existingAccessory && !existingLightBulbService){
+      existingAccessory.addService(this.lightService);
+    }
+
+  } else {
+    this.log("No light exists for: " + this.homekitLightName);
   }
+    
   var existingFanService;
@@ -289,3 +297,3 @@ if (existingAccessory){
   }
-/*
+
   var existingOccupancyService;
@@ -299,3 +307,3 @@ if (existingAccessory){
   setCharacteristicOnService(this.occupancyService, Characteristic.OccupancyDetected,
-                              "room", "isOccupied",
+                              "sensor", "isOccupied",
                               occupancyGetWrapper, null)
@@ -306,5 +314,5 @@
   }
-*/
+
   this.getServices = function() {
-    return [this.lightService, this.fanService]; //this.occupancyService];
+    return [this.lightService, this.fanService, this.occupancyService];
   }
@@ -311,0 +319,0 @@ if (existingAccessory){

package.json

 {
   "name": "homebridge-bigAssFans",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "A Homebridge plugin for Big Ass Fans",
@@ -22,5 +22,5 @@ "main": "index.js",
   "dependencies": {
-    "BigAssFansAPI": ">=1.1.0"
+    "BigAssFansAPI": ">=1.1.1"
   },
   "homepage": "https://github.com/sean9keenan/homebridge-bigAssFans"
 }

README.md

@@ -14,3 +14,4 @@ Homekit
             "platform": "BigAssFans",
-            "name": "Big Ass Fan"
+            "name": "Big Ass Fan",
+            "fan_count": 1
         }
@@ -20,2 +21,4 @@ ]
 
+This config will automatically scan and add *all* fans that are on your local wifi network. However you should also always add the expected number of fans with the optional config parameter `fan_count` (by default this assumes 1). Otherwise homebridge will not always discover all the fans.
+
 Install this package with
@@ -50,3 +53,3 @@ ```
 
-### About the legcay config
+### About the legacy config
 |        Field       |   Required?  |                Description               |
@@ -53,0 +56,0 @@ |--------------------|--------------|------------------------------------------|

No alert changes

Improved metrics

Total package byte prevSize

18175

increased by2.99%

Lines of code

278

increased by1.09%

Number of lines in readme file

79

increased by3.95%

Dependency changes

• UpdatedBigAssFansAPI@>=1.1.1