image-convert - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

index.js

@@ -8,9 +8,27 @@ // Copyright 2016 Arshpreet Wadehra
 module.exports = {
-  fromURL : (url,size,callback)=>{
-    let img = url;
+  fromURL : ()=>{
+    let quality = 100,output_format="jpg",size=undefined;
+    let max_allowed_parameters = 5;
+    let min_allowed_parameters = 2;
+    if(arguments.length>max_allowed_parameters || arguments.length < min_allowed_parameters)
+      arguments[arguments.length-1](new Error("Parameters Mismatch"),null);
+    else if(typeof quality[0] == "function")
+      arguments[arguments.length-1](new Error("Parameters Mismatch"),null);
+    let img = arguments[0];
+    if(typeof quality[1] != "function")
+      quality = arguments[1];
+    if(typeof quality[2] != "function")
+      output_format = arguments[2];
+    if(typeof quality[3] != "function")
+      size = arguments[3];
     try{
-    request.get(img, function (err, res, body) {
-        var buffer = image(body).size(size).encode("jpg");
-        callback(null,buffer);
-    });
+      request.get(img, function (err, res, body) {
+          var img = image(body);
+          var buffer;
+          if(size ==undefined)//original size
+            buffer = image(body).encode(output_format,{quality:quality});
+          else
+            buffer = image(body).size(size).encode(output_format,{quality:quality});
+          callback(null,buffer);
+      });
     }
@@ -17,0 +35,0 @@ catch(e){

package.json

 {
   "name": "image-convert",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "convert image and return static jpg and can resize from URL",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -12,3 +12,3 @@ # image-convert
 let imgConvert = require('image-convert').fromURL;
-imgConvert(<url>,<size>,function(err,res){
+imgConvert(<url>,<quality[0..100]>,<output_format>,<size{integer}>,function(err,res){
 	if(!err)
@@ -15,0 +15,0 @@ console.log(res);//img buffer

No alert changes

Improved metrics

Total package byte prevSize

3392

increased by36.55%

Lines of code

37

increased by94.74%

No dependency changes