imap-client - npm Package Compare versions

Comparing version 0.8.0 to 0.8.1

package.json

 {
   "name": "imap-client",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "scripts": {
@@ -5,0 +5,0 @@ "pretest": "dir=$(pwd) && cd node_modules/browserbox/node_modules/tcp-socket/node_modules/node-forge/ && npm install && npm run minify && cd $dir",

README.md

@@ -122,4 +122,4 @@ # imap-client
     answered: true/false/undefined // (optional) Marks the message as answered, no action if omitted
-}, function (error, flags) {
-    // all done, called the flags received from the server
+}, function (error) {
+    // all done
 });
@@ -133,3 +133,3 @@ ```
 ```
-imap.updateFlags({
+imap.moveMessage({
     path: 'foo/bar', // the origin folder
@@ -148,3 +148,3 @@ uid: someMessage.uid, // the message's uid
 ```
-imap.updateFlags({
+imap.uploadMessage({
     path: 'foo/bar', // the target folder
@@ -162,3 +162,3 @@ message: '...' // RFC-2822 compliant string
 ```
-imap.updateFlags({
+imap.deleteMessage({
     path: 'foo/bar', // the folder from which to delete the message
@@ -165,0 +165,0 @@ uid: someMessage.uid, // the message's uid

src/imap-client.js

@@ -860,3 +860,3 @@ (function(factory) {
      * @param {Boolean} options.flagged (optional) Marks the message as answered
-     * @param {Function} callback(error, flags) will be called the flags have been received from the server
+     * @param {Function} callback(error) will be called the flags have been updated
      */
@@ -933,5 +933,5 @@ ImapClient.prototype.updateFlags = function(options, callback) {
 
-        function onFlagsAdded(error, messages) {
+        function onFlagsAdded(error) {
             if (error || remove.length === 0) {
-                onFlagsRemoved(error, messages);
+                onFlagsRemoved(error);
                 return;
@@ -943,3 +943,3 @@ }
 
-        function onFlagsRemoved(error, messages) {
+        function onFlagsRemoved(error) {
             if (error) {
@@ -951,8 +951,4 @@ axe.error(DEBUG_TAG, 'error updating flags for uid ' + options.uid + ' in folder ' + options.path + ' : ' + error + '\n' + error.stack);
 
-            axe.debug(DEBUG_TAG, 'successfully updated flags for uid ' + options.uid + ' in folder ' + options.path + ': flags are ' + messages[0].flags + '. added ' + add + ' and removed ' + remove);
-            callback(null, {
-                unread: messages[0].flags.indexOf(READ_FLAG) === -1,
-                answered: messages[0].flags.indexOf(ANSWERED_FLAG) > -1,
-                flagged: messages[0].flags.indexOf(FLAGGED_FLAG) > -1
-            });
+            axe.debug(DEBUG_TAG, 'successfully updated flags for uid ' + options.uid + ' in folder ' + options.path + ': added ' + add + ' and removed ' + remove);
+            callback();
         }
@@ -959,0 +955,0 @@ };

test/local-integration-test.js

@@ -229,7 +229,4 @@ 'use strict';
             answered: true
-        }, function(error, flags) {
-            expect(error).to.be.null;
-            expect(flags.unread).to.be.true;
-            expect(flags.flagged).to.be.true;
-            expect(flags.answered).to.be.true;
+        }, function(error) {
+            expect(error).to.not.exist;
             done();
@@ -236,0 +233,0 @@ });

test/unit-test.js

@@ -220,3 +220,3 @@ (function(factory) {
                 }, function(error, uids) {
-                    expect(error).to.be.null;
+                    expect(error).to.not.exist;
                     expect(uids.length).to.equal(3);
@@ -240,3 +240,3 @@ done();
                 }, function(error, uids) {
-                    expect(error).to.be.null;
+                    expect(error).to.not.exist;
                     expect(uids.length).to.equal(3);
@@ -260,3 +260,3 @@ done();
                 }, function(error, uids) {
-                    expect(error).to.be.null;
+                    expect(error).to.not.exist;
                     expect(uids.length).to.equal(3);
@@ -280,3 +280,3 @@ done();
                 }, function(error, uids) {
-                    expect(error).to.be.null;
+                    expect(error).to.not.exist;
                     expect(uids.length).to.equal(3);
@@ -360,3 +360,3 @@ done();
                 }, function(error, msgs) {
-                    expect(error).to.be.null;
+                    expect(error).to.not.exist;
                     expect(bboxMock.selectMailbox.calledOnce).to.be.true;
@@ -555,7 +555,4 @@ expect(bboxMock.listMessages.calledOnce).to.be.true;
                     answered: true
-                }, function(error, flags) {
-                    expect(error).to.be.null;
-                    expect(flags.unread).to.be.true;
-                    expect(flags.answered).to.be.true;
-                    expect(flags.flagged).to.be.true;
+                }, function(error) {
+                    expect(error).to.not.exist;
 
@@ -583,6 +580,4 @@ expect(bboxMock.selectMailbox.calledOnce).to.be.true;
                     answered: true
-                }, function(error, flags) {
-                    expect(error).to.be.null;
-                    expect(flags.unread).to.be.true;
-                    expect(flags.answered).to.be.true;
+                }, function(error) {
+                    expect(error).to.not.exist;
 
@@ -610,6 +605,4 @@ expect(bboxMock.selectMailbox.calledOnce).to.be.true;
                     unread: true
-                }, function(error, flags) {
-                    expect(error).to.be.null;
-                    expect(flags.unread).to.be.true;
-                    expect(flags.answered).to.be.false;
+                }, function(error) {
+                    expect(error).to.not.exist;
 
@@ -632,5 +625,4 @@ expect(bboxMock.selectMailbox.calledOnce).to.be.true;
                     answered: true
-                }, function(error, flags) {
+                }, function(error) {
                     expect(error).to.exist;
-                    expect(flags).to.not.exist;
 
@@ -649,5 +641,4 @@ done();
                     answered: true
-                }, function(error, flags) {
+                }, function(error) {
                     expect(error).to.exist;
-                    expect(flags).to.not.exist;
 
@@ -768,3 +759,3 @@ done();
                 }, function(error) {
-                    expect(error).to.be.null;
+                    expect(error).to.not.exist;
                     expect(bboxMock.selectMailbox.calledOnce).to.be.true;
@@ -771,0 +762,0 @@ expect(bboxMock.deleteMessages.calledOnce).to.be.true;

No alert changes

Worsened metrics

Total package byte prevSize

109898

decreased by-0.91%

Lines of code

2356

decreased by-0.67%

No dependency changes