iobroker - npm Package Compare versions

Comparing version 2.0.0 to 2.0.1

CHANGELOG_INSTALLER_LINUX.md

 # Changelog for Linux-Installer-Script
 
+## 2019-01-22
+* Use `KillMode=process` in `systemd` to prevent detached processes from being killed aswell
+
 ## 2019-01-21 (fixes #106, #107)
@@ -7,3 +10,2 @@ * Move temp_sudo_file instead of copying
 
-
 ## 2019-01-20 (see #99)
@@ -16,7 +18,9 @@ * User creation and specifying which commands may be executed as sudo without password
 * Automatic IP address detection for the final message
-* Detection if the installer script is being run as a result of npm install or some other command. - This should fix failures during execution of npm rebuild
+* Detection if the installer script is being run as a result of npm install or some other command. _This should fix failures during execution of npm rebuild._
 * Run all iobroker commands as the iobroker user if possible
 * Fix iobroker start/stop/restart/status when systemd is used
 
+**Note:** Since so much is now being done in the installer script, manual installations on Linux/OSX/FreeBSD using `npm` are forbidden since `v2.0.0`, which was released on 2019-01-21.
 
+
 ## 2019-01-02 (and earlier)
@@ -23,0 +27,0 @@ * this version introducted writing INSTALLER_INFO.txt into the ioBroker directory with installation details used later on for support reasons

lib/installSetup.js

@@ -24,3 +24,3 @@ /**
 const child_process = require('child_process');
-const exec = child_process.exec;
+const execSync = child_process.execSync;
 const tools = require('./tools.js');
@@ -75,15 +75,26 @@
 
-    const child = exec('npm install node-windows@0.1.14 --production --save --prefix "' + npmRootDir + '"');
-    child.stderr.pipe(process.stdout);
-    child.on('exit', () => {
-        // call node install.js
-        // install node as service
-        const child1 = exec('node "' + path.join(rootDir, 'install.js') + '"');
-        child1.stderr.pipe(process.stdout);
-        child1.on('exit', () => {
-            console.log('ioBroker service installed. Write "serviceIoBroker start" to start the service and go to http://localhost:8081 to open the admin UI.');
-            console.log('To see the outputs do not start the service, but write "node node_modules/iobroker.js-controller/controller"');
-            if (callback) callback();
-        });
-    });
+    try {
+        execSync('npm install node-windows@0.1.14 --production --save --prefix "' + npmRootDir + '"', {stdio: 'inherit'});
+    }
+    catch (error) {
+        console.log('Error when installing Windows Service Library: ' + error);
+        if (callback) callback(error.code);
+        return;
+    }
+
+    //console.log('Windows service library installed, now register ioBroker as Service');
+    //console.log('node "' + path.join(rootDir, 'install.js') + '"');
+
+    try {
+        execSync('node "' + path.join(rootDir, 'install.js') + '"', {stdio: 'inherit'});
+    }
+    catch (error) {
+        console.log('Error when registering ioBroker as service: ' + error);
+        if (callback) callback(error.code);
+        return;
+    }
+
+    console.log('ioBroker service installed. Write "serviceIoBroker start" to start the service and go to http://localhost:8081 to open the admin UI.');
+    console.log('To see the outputs do not start the service, but write "node node_modules/iobroker.js-controller/controller"');
+    if (callback) callback();
 }
@@ -90,0 +101,0 @@

package.json

 {
   "name": "iobroker",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "engines": {
@@ -5,0 +5,0 @@ "node": ">=8.12"

No alert changes

Improved metrics

Total package byte prevSize

55650

increased by1.08%

Lines of code

938

increased by0.86%

No dependency changes