ionic1-star-rating - npm Package Compare versions

Comparing version 1.2.11-beta.0 to 1.2.12

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="1.2.12"></a>
+## [1.2.12](https://github.com/BioPhoton/ionic1-star-rating/compare/v1.2.11-beta.0...v1.2.12) (2017-04-09)
+
+
+### Bug Fixes
+
+* **removed code:** removed old code ([d930f61](https://github.com/BioPhoton/ionic1-star-rating/commit/d930f61))
+
+
+
 <a name="1.2.9"></a>
@@ -2,0 +12,0 @@ ## [1.2.9](https://github.com/BioPhoton/angular1-star-rating/compare/v1.2.8...v1.2.9) (2017-02-25)

package.json

 {
   "name": "ionic1-star-rating",
-  "version": "1.2.11-beta.0",
+  "version": "1.2.12",
   "license": "MIT",
@@ -5,0 +5,0 @@ "keywords": [

src/star-rating.controller.spec.ts

 import IRootScopeService = angular.IRootScopeService;
 import IComponentController = angular.IComponentController;
 import createSpy = jasmine.createSpy;
-import {
-    starRatingColors,
-    IStarRatingCompBindings
-} from "../examples/ionic1/temp/lib/angular1-star-rating/src/star-rating.structs";
 
 describe('Star rating controller', () => {
 
-    let $componentController;
-    let starRatingCtrl;
-    let scope;
-    let element;
 
-    let negativeValue: number = -1;
-    let defaultValue: number = 0;
-
-    let defaultColor: starRatingColors = "default";
-    let negativeColor: starRatingColors = "negative";
-    let okColor: starRatingColors = "ok";
-    let positiveColor: starRatingColors = "positive";
-
-    let lowRating = 1;
-    let okRating = 3;
-    let highRating = 5;
-
-    beforeEach(angular.mock.module('star-rating'));
-
-    beforeEach(inject(($rootScope, $element, _$componentController_) => {
-        scope = $rootScope.$new();
-        element = $element;
-        $componentController = _$componentController_;
-    }));
-
-    //////////////////////////////////////////////////////////////////////////////
-
-
-    /**
-     * getStarRatingCtrl
-     *
-     * A factory for StarRatingController
-     *
-     * @param bindingsProperties
-     * @returns {*}
-     */
-    function getStarRatingCtrl(bindingsProperties?: IStarRatingCompBindings): any {
-        bindingsProperties = angular.copy(bindingsProperties) || <IStarRatingCompBindings>{};
-        element = angular.element('<div id="{{$ctrl.id}}" class="rating" ng-class="$ctrl.getComponentClassNames()"><div ng-show="$ctrl.labelText" class="label-value">{{$ctrl.labelText}}</div><div class="star-container"><div class="star" id="{{star}}" ng-repeat="star in $ctrl.stars track by $index" ng-click="$ctrl.onStarClicked(star)"><i class="star-empty {{$ctrl.classEmpty}}" ng-if="!$ctrl.svgVisible()"></i><i class="star-half {{$ctrl.classHalf}}" ng-if="!$ctrl.svgVisible()"></i><i class="star-filled {{$ctrl.classFilled}}" ng-if="!$ctrl.svgVisible()"></i><svg class="star-empty {{$ctrl.classEmpty}}" ng-if="$ctrl.svgVisible()"><use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="{{$ctrl.pathEmpty}}"></use></svg><svg class="star-half {{$ctrl.classHalf}}" ng-if="$ctrl.svgVisible()"><use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="{{$ctrl.pathHalf}}"></use></svg><svg class="star-filled {{$ctrl.classFilled}}" ng-if="$ctrl.svgVisible()"><use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="{{$ctrl.pathFilled}}"></use></svg></div></div></div>');
-
-        return $componentController('starRatingComp', {$element:element}, bindingsProperties);
-    }
-
 });

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

328784

decreased by-0.67%

Lines of code

591

decreased by-6.49%

No dependency changes