karma-electron - npm Package Compare versions

Comparing version 3.1.1 to 3.2.0

CHANGELOG.md

 # karma-electron changelog
+3.2.0 - Added tolerance for EOF comments
+
 3.1.1 - Added notice about submodule support
@@ -3,0 +5,0 @@

lib/karma-electron-preprocessor.js

@@ -15,2 +15,4 @@ // Load our dependencies
 var minifiedTemplateStr = templateStr.replace(/\/\/[^\n]+/g, '\n').replace(/\n/g, '');
+// DEV: We inject a newline after content to prevent `//` comments from breaking our closure
+minifiedTemplateStr = minifiedTemplateStr.replace(/(content}})/, '$1\n');
 var template = minstache.compile(minifiedTemplateStr);
@@ -17,0 +19,0 @@

package.json

 {
   "name": "karma-electron",
   "description": "Karma launcher and preprocessor for Electron",
-  "version": "3.1.1",
+  "version": "3.2.0",
   "homepage": "https://github.com/twolfson/karma-electron",
@@ -27,4 +27,5 @@ "author": {
     "test": "npm run test-karma-all && npm run lint",
-    "test-karma-all": "npm run test-karma-single-run && npm run test-karma-failure && npm run test-karma-uncaught-exception && npm run test-karma-karma && npm run test-karma-phantomjs && npm run test-karma-source-map",
+    "test-karma-all": "npm run test-karma-single-run && npm run test-karma-failure && npm run test-karma-uncaught-exception && npm run test-karma-karma && npm run test-karma-phantomjs && npm run test-karma-eof-comment && npm run test-karma-source-map",
     "test-karma-continuous": "karma start test/integration-test/karma.conf.js --no-single-run",
+    "test-karma-eof-comment": "cross-env TEST_TYPE=EOF_COMMENT karma start test/integration-test/karma.conf.js --single-run",
     "test-karma-karma-comment": "# DEV: We run `test-karma-karma` twice to verify no user-data-dir is leaking",
@@ -31,0 +32,0 @@ "test-karma-karma": "cross-env TEST_TYPE=KARMA karma start test/integration-test/karma.conf.js --single-run && cross-env TEST_TYPE=KARMA karma start test/integration-test/karma.conf.js --single-run",

test/integration-test/karma.conf.js

@@ -9,2 +9,3 @@ // Karma configuration
   var phantomJsTest = 'phantomjs-test.js';
+  var eofCommentTest = 'eof-comment-test.js';
   var failureTest = 'failure-test.js';
@@ -20,2 +21,5 @@ var sourceMapTest = 'source-map-test.js';
     excludeFiles.delete(uncaughtExceptionTest);
+  } else if (process.env.TEST_TYPE === 'EOF_COMMENT') {
+    testFiles = [eofCommentTest];
+    excludeFiles.delete(eofCommentTest);
   } else if (process.env.TEST_TYPE === 'FAILURE') {
@@ -22,0 +26,0 @@ testFiles = [failureTest];

No alert changes

Improved metrics

Total package byte prevSize

34008

increased by2.67%

Number of package files

26

increased by4%

Lines of code

502

increased by2.87%

Worsened metrics

Number of low supply chain risk alerts

10

increased by11.11%

No dependency changes