kraken-api - npm Package Compare versions

Comparing version 0.1.6 to 0.1.7

kraken.js

@@ -135,4 +135,3 @@ var request		= require('request');
 				if(error) {
-					callback.call(self, new Error('Error in server response: ' + JSON.stringify(error)), null);
-					return;
+					return callback.call(self, new Error('Error in server response: ' + JSON.stringify(error)), null);
 				}
@@ -144,15 +143,23 @@
 				catch(e) {
-					callback.call(self, new Error('Could not understand response from server: ' + body), null);
-					return;
+					return callback.call(self, new Error('Could not understand response from server: ' + body), null);
 				}
-
+				//If any errors occured, Kraken will give back an array with error strings under
+				//the key "error". We should then propagate back the error message as a proper error.
 				if(data.error && data.error.length) {
-					callback.call(self, data.error, null);
+					var krakenError = null;
+					data.error.forEach(function(element) {
+						if (element.charAt(0) === "E") {
+							krakenError = element.substr(1);
+							return false;
+						}
+					});
+					if (krakenError) {
+						return callback.call(self, new Error('Kraken API returned error: ' + krakenError), null);
+					}
 				}
 				else {
-					callback.call(self, null, data);
+					return callback.call(self, null, data);
 				}
 			}
 		});
-
 		return req;
@@ -159,0 +166,0 @@ }

package.json

 {
   "name": "kraken-api",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "kraken.com API client library for NodeJS",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

8570

increased by5.66%

Number of package files

5

increased by25%

Lines of code

149

increased by6.43%

No dependency changes